Skull of Flames [GUI] [v.1.00]

[Moderator]

14:09, 13ndth Sep 2015

This resource has been re-approved by BPower,

Criticism:
A good implementation of the original vJass version. I totally agree with Hanky's review from 2008.

For the sake of completeness I will point out weaknesses in your code.
The code runs RemoveLocation on a null handle in two cases.
It's not a big deal, as this native does not break the code when using null as argument.
Everything is hardcoded, which is not the standard of public spell submissions nowadays.
Not only trees, but every destructable type is considered as valid "kill" target.
This includes bridges, path blockers and platforms.

From moderator to user:
You should consider an implementation of IsDestructableTree to ensure only
trees are the only destructable types damaged by this spell.

previous review from 2008

19:31, 7th Dec 2008
Hanky:
You made a good conversion of the vJASS spell. The triggering is really effective. Also the spell is MUI and leakless. The visual effects are really good copied and look really like the original. The documentation and tooltips are ok too.

Well, you done a good job. I can only recommend to use this spell if this spell is that what you are searching for.

 

[NiddHogg-kun]

ahahaha))
Paladon you are the best)
*everything that was made with JASS i can make in GUI*
that was true
5/5 man)

 

[Jack_Sparrow93]

Really nice spell! +rep

But why have the effector the sound of a child?

 

[TheBlooddancer]

Haha!

Awesome! Paladon teh Almighty has striken again~~

(But why is there a Peasant?)

 

[kewlthis]

Its pretty nice.

 

[Eccho]

Yeah, Paladon you are an awesome Gui-coder I think I have lost some knowledge of Gui. Would never found that out myself^^.

Good job!

 

[Paladon]

PS: The Jass version can be found here:
Skull of Flames by Eccho

But why is there a Peasant?

Spell damages enemies only

But why have the effector the sound of a child?

Yoghurt has no fishbones.

 

[Darkt3mpl3r]

pretty lame uploading another one's spell and earning credits for it.

Even though you got permission and it's GUI and such...

Simply put the spell into his spellmap.

 

[Paladon]

I made this version because a GUI version was requested, not to profile myself.
Everything is arranged with Eccho, we posted a link to each other´s version.
I don´t claim any credits for the idea, in fact i prompt users to credit Eccho for the original spell as well as for the idea.
You may have noticed that the GUI triggering is different.
I don´t care whether i´m nothing but a stealer in your eyes.
I additonally don´t care about those who call me a lamer.
I guess that´s it.

 

[Eccho]

Darkt3mpl3r he is right. Since I am a pretty lousy Gui coder myself when it comes to spells, he illustrated that it wasnt impossible to do a Gui version out of the original Jass version. So do not call him lame. This is a decision we both have agreed upon. About the publicity, why is he earning more credits? Simply, it is a remade work of the Jass spell allowing 'those with less knowledge of Jass or JNGP' to still try it out.
He is not stealing anything.

And yes, there was a request for it, and I hesitated whether I was being able to make a GUI version of it. Paladon solved that cake instead.

 

[Kwah]

Nice, very nice.

 

[Zylus]

always fun to import new spells for loap secrete heros (=

 

[Zylus]

umm for some reason i cant paste the spell into my custom spell sheet can someone explain why

 

[Kwah]

Convert to Custom Text.

It's one of the options on the tabs along the top.