Simple system needed

[.VTZ.]

*need to be MUI, (for 10 players)
*every 5 sec add 10 lumber to the Builded structure (the market)
*need to show every seconds the +10 lumber count number
*if the building is destroyed cancels de lumber gained.

(sorry bad english)
thanks.

 

[Mac_MacNuggets]

• Trigger
• Event
• Every 10 seconds
• Condition
• Action
• Unit group - Pick every unit in playable map area and do actions
• Loop - actions
• If (all conditions are true) then do (then actions) else do (else actions)
• If - conditions
• Unit type of picked unit is market equals to true
• Then - actions
• Set tempPoint = position of market
• Player - set lumber of owner of picked unit = lumber of owner of picked unit + 10
• Floating text - Create a floating text at tempPoint saying +10 with colour 00 00 100
• Set tempText = last created floating text
• Floating text - Change velocity of tempText to 64 to 90 degrees
• Floating text - Change fading age of tempText to 2 seconds
• Custom Script: call RemoveLocation(udg_tempPoint)
• Set tempPoint = no floating text
• Else - actions

 

[.VTZ.]

• Trigger
• Event
• Every 10 seconds
• Condition
• Action
• Unit group - Pick every unit in playable map area and do actions
• Loop - actions
• If (all conditions are true) then do (then actions) else do (else actions)
• If - conditions
• Unit type of picked unit is market equals to true
• Then - actions
• Set tempPoint = position of market
• Player - set lumber of owner of picked unit = lumber of owner of picked unit + 10
• Floating text - Create a floating text at tempPoint saying +10 with colour 00 00 100
• Set tempText = last created floating text
• Floating text - Change velocity of tempText to 64 to 90 degrees
• Floating text - Change fading age of tempText to 2 seconds
• Custom Script: call RemoveLocation(udg_tempPoint)
• Set tempPoint = no floating text
• Else - actions

thanks +rep

 

[wolfman]

The unit group leaks, you should set all units in map = tempgroup
then do custom script: call DestroyGroup(ugdtempgroup) at the end of the trigger

 

[defskull]

OR just :

• Custom script: set bj_wantDestroyGroup

?

 

[Mac_MacNuggets]

. Thanks. But How does the custom script work?

 

[defskull]

It destroys a Unit Group action right after its usage
Usually, this custom script is used IF your Unit Group is NOT a variable
If it's a variable, you must follow wolfman's suggestion

Put that custom script right above the Unit Group action

 

[mckill2009]

• Farm
• Building
  • Events
    • Time - Every 5.00 seconds of game time
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup=true
    • Unit Group - Pick every unit in (Units of type Farm) and do (Actions)
      • Loop - Actions
        • Custom script: local unit building = GetEnumUnit()
        • Custom script: local location b = GetUnitLoc(building)
        • Custom script: call CreateTextTagLocBJ( "+10", b, 0, 10, 100, 100, 100, 0 )
        • Floating Text - Change (Last created floating text): Disable permanence
        • Floating Text - Set the velocity of (Last created floating text) to 100.00 towards 90.00 degrees
        • Floating Text - Change the age of (Last created floating text) to 3.00 seconds
        • Custom script: set building = null
        • Custom script: set b = null

 

[Garfield1337]

It destroys a Unit Group action right after its usage
Usually, this custom script is used IF your Unit Group is NOT a variable
If it's a variable, you must follow wolfman's suggestion

Put that custom script right above the Unit Group action

It would work for a global variable too.

• Farm
• Building
  • Events
    • Time - Every 5.00 seconds of game time
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup=true
    • Unit Group - Pick every unit in (Units of type Farm) and do (Actions)
      • Loop - Actions
        • Custom script: local unit building = GetEnumUnit()
        • Custom script: local location b = GetUnitLoc(building)
        • Custom script: call CreateTextTagLocBJ( "+10", b, 0, 10, 100, 100, 100, 0 )
        • Floating Text - Change (Last created floating text): Disable permanence
        • Floating Text - Set the velocity of (Last created floating text) to 100.00 towards 90.00 degrees
        • Floating Text - Change the age of (Last created floating text) to 3.00 seconds
        • Custom script: set building = null
        • Custom script: set b = null

Leaks location b. Add RemoveLocation(b) before setting the var to null. Also,if you're going to use JASS,don't use locations at all. (use coordinates)

 

[defskull]

It would work for a global variable too.

And who said I was saying that it works ONLY for... Local ???
I just said variable, not local only, lol...

 

[Garfield1337]

If it's a variable, you must follow wolfman's suggestion

According to this,set bj_wantDestroyGroup = true works only when you don't use global variables,something like

• Custom script: set bj_wantDestroyGroup = true
• Unit Group - Pick every unit in (Units in (Playable map area)) and do (Actions)
  • Loop - Actions

However,^ creates a local group as BJ.
It would be leakless like this too

• Set GroupVar = (Units in (Playable map area))
• Custom script: set bj_wantDestroyGroup = true
• Unit Group - Pick every unit in GroupVar and do (Actions)
  • Loop - Actions

I didn't mean just global variables,but local ones can't be referenced in GUI functions.

 

[Bribe]

That has to do with handle-pointer leaks, and if you want to bother GUI users that much you need to tell them not to use "Wait - Game Time", don't pre-place units in editor, many other hidden errors. Handle-pointer leaks should only be a factor for advanced users.

 

[.VTZ.]

yeah doesnt works fine.
ok, i need this system working in MUI and I need a way to make the market be built in just over a mine. but when I build on top of mine (based on mine undead) when it is destroyed the mine is destroyed and I want to join a system like Anihhinlation Total Kingdoms mine
at 0:56

 

[mckill2009]

Leaks location b. Add RemoveLocation(b) before setting the var to null. Also,if you're going to use JASS,don't use locations at all. (use coordinates)

- I forgot to add remove location
- about locations, yes I agree but this is a pactice dude so it does not hurt to do so

 

[Garfield1337]

It's good to practice,but the sooner you get used to coordinates the better.