Simple Spell Power System v1.4 [GUI]

[Moderator]

Approved
The system works fine and is easy to use.

You could do SP_Value != 0 check in save and lose triggers,
and skip the rest of the actions if it is 0.

Older reviews

20:09, 15th Jul 2012

Pharaoh_: The custom function is not really flexible at the moment.
Make it get Unit as a parameter and return real:

function GetUnitSpellPower takes unit u returns real
    return LoadReal (udg_SP_Hashtable, GetHandleId (u), 1)
endfunction

What is more, ShowSP function is not necessary, just add a flag in the GetUnitSpellPower function, e.g.
function GetUnitSpellpower takes unit u, boolean b returns real
check in the function if b then -> create tag. In both cases (outside of the if/then), return the Spell Power value.


22:07, 6th Jul 2012

Fix the BJ's; address it to Triggers & Scripts, if necessary.

 

[defskull]

Reserved.

 

[KnnO]

• I was expecting some spells example. I know how to use it, but from seeing the spell thumbnail I thought there must be some demo spells
  I think you can post them in a hidden tag other than triggers ^^
  
  
• The Idea of this is really nice, so now for example you can reserve leveling your abilities
  for other things like lowering cd/mana ..etc
  
  
• I like the "-sp" trigger, it can be used with the system immediately in the user's map, but it needs a better floating text display though, I would change the text properties to these (just so it would be noticable):
  • Velocity: 64 -> 32
  • Lifespan: 1.5 -> 2.5
  • FadeAge: 0.75 -> 1.5
  (Because I was typing -sp for alot of time while expecting a text message, not a floating one ' )
  I think I didn't notice it because of the static tip message...

 

[defskull]

I was expecting some spells example. I know how to use it, but from seeing the spell thumbnail I thought there must be some demo spells
I think you can post them in a hidden tag other than triggers ^^

There was an example of usage in the test map, yeah
Do you mean to include the trigger example in the description (here) ?
I think I should just put the main trigger here.

I like the "-sp" trigger, it can be used with the system immediately in the user's map, but it needs a better floating text display though, I would change the text properties to these (just so it would be noticable):
Velocity: 64 -> 32
Lifespan: 1.5 -> 2.5
FadeAge: 0.75 -> 1.5
(Because I was typing -sp for alot of time while expecting a text message, not a floating one ' )
I think I didn't notice it because of the static tip message...

Well, it works well for my eyes, I could notice the message in 1.5s
This system will work if you select multiple units at once (MUI), that's why I made a Floating Text instead of Game Message because we don't know which units do we refer to.

Thanks for comments and feedbacks

 

[maddeem]

You could make this more efficient by having the same integer setup. But after that save the spell power to the item in a hashtable and load it directly from an acquired item so it doesn't have to cycle through a ton of items.

 

[defskull]

Velocity: 64 -> 32
Lifespan: 1.5 -> 2.5
FadeAge: 0.75 -> 1.5

Has been implemented.

You could make this more efficient by having the same integer setup. But after that save the spell power to the item in a hashtable and load it directly from an acquired item so it doesn't have to cycle through a ton of items.

Has been implemented.

 

[Kgg123]

Looks really nice and i think i use this in my map =)

great work!! 8.5/10

 

[defskull]

Looks really nice and i think i use this in my map =)

Thanks

great work!! 8.5/10

You said 8.5/10 -> 4.25/5
But you did not rate it

 

[KnnO]

I rated it for you 5/5

 

[defskull]

I rated it for you 5/5

It is 2/5

 

[KnnO]

Hey hey hold on a sec you replied so fast... I am having bugs with this browser
Here, changed it, really sorry for inconvenience

 

[Tank-Commander]

Sounds likem something based off of LoL, So what this is, basically is a "system" which increases SP when you get given an item, and you lose it when you drop it, giving the unit a value which can be adde in spell formula to increase spell damage or decrease spell damage, however only applies /really/ to custom spells?

And you must put in every item individually to do this (obviously)

Well, I think it's a nice idea, it's not practical really for others, but a nice idea I guess, most custom spells do not have a damage formula as part of the configurables and most do not use hashtables - even so it'd require modification by somebody who understands hashtables to actually use the values and thus require them to go delving into potentially complicated spells to find where they should be adding this data. Thus it can't /really/ be used by people who don't already have a semi-decent understanding of spell-making, who could also easily recreate this effect in a manner.

Also, I think the system is /far/ too simple to warrant the use of hashtables. Since you're saving one value for each unit (the SP) it could just all be stored in a dynamic array and then you can find the unit in the array during the spell being cast using a second array variable and then you could get the value more easily. As for the items SP the exact same could be done, just with an array for item-types.

Edit: Oh and on the -sp trigger you should have it in conditions to check that once the string is converted into lowercase (or uppercase) that it matches "-sp" or "-SP" (depending on which way you convert it so that it cannot be triggered by a sentence which just happens to have it in.

 

[defskull]

Sounds likem something based off of LoL, So what this is, basically is a "system" which increases SP when you get given an item, and you lose it when you drop it, giving the unit a value which can be adde in spell formula to increase spell damage or decrease spell damage, however only applies /really/ to custom spells?

And you must put in every item individually to do this (obviously)

Well, I think it's a nice idea, it's not practical really for others, but a nice idea I guess, most custom spells do not have a damage formula as part of the configurables and most do not use hashtables - even so it'd require modification by somebody who understands hashtables to actually use the values and thus require them to go delving into potentially complicated spells to find where they should be adding this data. Thus it can't /really/ be used by people who don't already have a semi-decent understanding of spell-making, who could also easily recreate this effect in a manner.

Also, I think the system is /far/ too simple to warrant the use of hashtables. Since you're saving one value for each unit (the SP) it could just all be stored in a dynamic array and then you can find the unit in the array during the spell being cast using a second array variable and then you could get the value more easily. As for the items SP the exact same could be done, just with an array for item-types.

Edit: Oh and on the -sp trigger you should have it in conditions to check that once the string is converted into lowercase (or uppercase) that it matches "-sp" or "-SP" (depending on which way you convert it so that it cannot be triggered by a sentence which just happens to have it in.

Blur~

I don't know where to start, I think the system currently good enough before I go far more advance such as dynamic array and what not.
I did not even know what that is.

I think I'll stick to the current setup trigger since it does not give any bugs at all.

 

[maddeem]

It looks so so much better, but to make it easier for a GUIer to read you can set udg_SP_Key directly to an item type, instead of an integer and it will act the same way
Other then that, 5/5

Thus it can't /really/ be used by people who don't already have a semi-decent understanding of spell-making, who could also easily recreate this effect in a manner.

You could make a function like call GetUnitSpellPower(udg_Unit) that would return a real. But then you would have to add some vjass, and some people hate vjass xD

But for anyone who doesn't understand this system, it allows you to add a custom stat to any item, and load that stat any time you please.
It seems pretty flexible, and with slight configuration you could easily add more than 1 custom stat to an item.

 

[defskull]

The system has been updated (check the changelogs)

without having to hit that chat text all the time

At that time, that action acts as an "example" on how to execute (check) the current unit's SP Value, now I added a new custom function, it's gonna be easy to retrieve the value from units.
I also added 3 more examples how to check current SP Value for units.

Additionally, you could merge a multiboard system to make this system visible on it; it would be destined for such uses anyway

I said it earlier, this system is MUI, you can't have too much unit to keep track of the info in the multiboards, it will become messy.

The unit group leaks.

I do not care about Leaks or Unefficient Coding outside of the Simple Spell Power System folder because that's just showing an example on how to use this system.
That is why I don't bother at all to clean location leaks or unit group leaks, because that is up to the user to use this function and clean for themselves, that trigger is just an example.

Please moderate it again, thank you

Also, if you guys know how to exactly execute all these actions in JASS, please tell me;

• Floating Text - Create floating text that reads (String((Integer(SP_CurrentValue)))) above (Picked unit) with Z offset 0.00, using font size 10.00, color (100.00%, 0.00%, 0.00%), and 0.00% transparency
• Floating Text - Set the velocity of (Last created floating text) to 64.00 towards 90.00 degrees
• Floating Text - Change (Last created floating text): Disable permanence
• Floating Text - Change the lifespan of (Last created floating text) to 1.50 seconds
• Floating Text - Change the fading age of (Last created floating text) to 0.75 seconds

Currently, my custom function contains all BJs which is not good.

 

[defskull]

Fix the BJ's

Ok fixed.

 

[shadowvzs]

maybe noob question but why don't store to variable array where the index is the unit custom value?

i mean the spell power value

 

[krolergmp]

5/5