Antares
Spell Reviewer
- Joined
- Dec 13, 2009
- Messages
- 982
Can one use mana as the shield resource? That seems to me like the more natural choice for a lot of maps.
I've only skimmed over the triggers yet. The implementation of the core system looks quite solid, but I think you need to make some architectural changes to get your resource approved.
In general, you want to split your code into three parts. A configurable part that the user can safely edit to customize the system to his or her needs. A core part that the user better not touch and a part for your test map, where you show possible applications of your systems and give examples of how to make it work. This is not always possible, especially in GUI, but it is something to aim towards.
From skimming over your triggers, I didn't really get a sense which parts I'm supposed to configure. The registering of unit types, for example, could be achieved by setting up an array of units in the config section. If you want your system to be slightly faster, you could then transform that list into a hashtable with a boolean set to true for unit ids that were added.
The shield effect doesn't appear to be perfectly centered to me (but I couldn't tell you why).
I've only skimmed over the triggers yet. The implementation of the core system looks quite solid, but I think you need to make some architectural changes to get your resource approved.
In general, you want to split your code into three parts. A configurable part that the user can safely edit to customize the system to his or her needs. A core part that the user better not touch and a part for your test map, where you show possible applications of your systems and give examples of how to make it work. This is not always possible, especially in GUI, but it is something to aim towards.
From skimming over your triggers, I didn't really get a sense which parts I'm supposed to configure. The registering of unit types, for example, could be achieved by setting up an array of units in the config section. If you want your system to be slightly faster, you could then transform that list into a hashtable with a boolean set to true for unit ids that were added.
The shield effect doesn't appear to be perfectly centered to me (but I couldn't tell you why).