Shadowstep

[Palaslayer]

Maybe u remember my question on my idea shadowstep. that is my trigger and i wanted to know if i can make things better and if i can, what. Maybe u can have a look.

• Shadowstep
  • Ereignisse
    • Einheit - A unit Beginnt, eine Fähigkeit zu wirken
  • Bedingungen
    • (Ability being cast) Gleich Shadowstep
  • Aktionen
    • Einheit - Make (Triggering unit) Unverwundbar
    • Einheit - Turn collision for (Casting unit) Aus
    • Einheit - Add Dauerhafte Unsichtbarkeit to (Casting unit)
    • Wait 1.00 seconds
    • Einheit - Cause (Casting unit) to damage (Target unit of ability being cast), dealing ((Real((Level of (Casting unit)))) x ((Real((Level of Shadowstep for (Casting unit)))) x 9.00)) damage of attack type Zaubersprüche and damage type Normal
    • Einheit - Move (Casting unit) instantly to (Position of (Target unit of ability being cast))
    • Spezialeffekt - Create a special effect at (Position of (Casting unit)) using war3mapImported\DarkLightningNova.mdx
    • Wait 0.30 seconds
    • Einheit - Make (Triggering unit) Verwundbar
    • Spezialeffekt - Create a special effect at (Position of (Target unit of ability being cast)) using war3mapImported\DarkLightningNova.mdx
    • Einheit - Order (Casting unit) to Angreifen (Target unit of ability being cast)
    • Einheit - Turn collision for (Casting unit) Ein
    • Einheit - Remove Dauerhafte Unsichtbarkeit from (Casting unit)

 

[emperor_d3st]

Maybe you could learn some english :S

At first sight: don't use Waits. Use polledwaits or use timers.
You also leak.

 

[NoNZealot]

What is the difference between polled waits and normal waits?

It's hard to guess what do the Deutch words mean in English... Perhaps you can explain a litte? Oh use triggering unit instead of casting unit.

 

[spiwn]

What is the difference between polled waits and normal waits?

Polled wait is more precise, but is it the same piece of crap(yes it uses the same native - TriggerSleepAction).
P.s. You can make your very own Polled wait that will be really really accurate. But still TriggerSleepAction

 

[Drak Zelthor]

this dosn't look to bad but I do have a few pointers.
First could you please explain here what your idea for the spell was ( I never saw it before)?

Second could you tell me what the event is? I can't speak more than a few works of german and the translation program I am using doesn't produce any inteligable result for that line.

Thirdly search for things that leak in the forums you should find some infomation on how to stop leaks in your trigger this should made it work a bit better. also maybe look at how to use better waits in the tutorial section as the in game wait have some problems with them.

 

[emperor_d3st]

Well, the main advantage of polled wait is that it waits through multiplayer lag.

Here's a discussion about Timers / Wait / PolledWait
I would like to note that not all information is 100% realiable there, but

Here's a tutorial on timers which tells you a little about waits and polled waits too

 

[spiwn]

And a little more:

function PolledWait takes real duration returns nothing
    local timer t
    local real  timeRemaining

    if (duration > 0) then
        set t = CreateTimer()
        call TimerStart(t, duration, false, null)
        loop
            set timeRemaining = TimerGetRemaining(t)
            exitwhen timeRemaining <= 0

            // If we have a bit of time left, skip past 10% of the remaining
            // duration instead of checking every interval, to minimize the
            // polling on long waits.
            if (timeRemaining > bj_POLLED_WAIT_SKIP_THRESHOLD) then
                call TriggerSleepAction(0.1 * timeRemaining)
            else
                call TriggerSleepAction(bj_POLLED_WAIT_INTERVAL)
            endif
        endloop
        call DestroyTimer(t)
    endif

JNGP rocks

 

[Squiggy]

Urgh.. hell i know, it's a hell to translate triggers from german to english.
Next, i'd hide the unit instead of giving invisibility, if you want a special effect on a certain unit then set the right function (create a special... on unit).
And last, use leakcheck

 

[Palaslayer]

i will add my new version (different and some fixes) tomorrow

 

[Palaslayer]

• Shadowstep
  • Events
    • Unit - A unit starts the effect of an ability
  • Bedingungen
    • (Ability being cast) equal to Shadowstep
  • Aktionen
    • Set Caster = (Casting unit)
    • Set Target = (Target unit of ability being cast)
    • Set TempLoc00 = (Position of (Target unit of ability being cast))
    • special effect - Create a special effect at (Position of Caster) using war3mapImported\DarkLightningNova.mdx
    • unit - Make Caster invulnerable
    • unit - Turn collision for Caster off
    • unit - Add permanent invisibility to Caster
    • Wait 1.00 seconds
    • For each (Integer A) from 1 to ((Level of Shadowstep for Caster) x 1), do (Actions)
      • Schleifen - actions
        • unit - Cause Caster to damage Target, dealing ((Real((Level of (Casting unit)))) x ((Real((Level of Shadowstep for (Casting unit)))) x 9.00)) damage of attack type spells and damage type normal
        • unit - Move Caster instantly to (Position of Target)
        • special effect - Create a special effect at (Position of Target) using Objects\Spawnmodels\Human\HumanBlood\BloodElfSpellThiefBlood.mdl
        • Wait 0.50 seconds
    • Wait 0.30 seconds
    • unit - Make (Triggering unit) vulnerable
    • unit - Order (Casting unit) to attack (Target unit of ability being cast)
    • unit - Turn collision for (Casting unit) on
    • unit - Remove permanent invisibility from (Casting unit)
    • Custom script: call RemoveLocation(udg_TempLoc00)
    • Custom script: set udg_Caster = null
    • Custom script: set udg_Target = null

hmm this is my new version of the trigger. the spell is an ulti now and as an result a bit mightier ^^
i tried to translate as many words as i could. hope its understandable.

 

[Squiggy]

It's still not MUI and you forgot to destroy the special effects

 

[Palaslayer]

Mui

what is mui?

 

[emperor_d3st]

Multi Unit Instanceable

 

[Squiggy]

means, the ability can be used multiple times at the same time.. waits interrupt being MUI and it can cause small upto huge graphical bugs or sometimes even gamecrashes.
Well, if you limit the amount of heros to 1 per player (each one a different) it doesn't need to be MUI