See anything wrong with this?

[Rugarus]

Edit: found the issue.

 

[MyPad]

That's quite a lot of maxSendLimits you have there. You could actually (drastically) shorten the code into something like this:

if (maxSendLimit[GetPlayerId(p)]+r_amount <= 2 && GetPlayerState(p, PLAYER_STATE_RESOURCE_GOLD) > 0)    {
    maxSendLimit[GetPlayerId(p)] = maxSendLimit[GetPlayerId(p)] + r_amount;
    sender = ResourceSender.create(r_amount, p, r_player, PLAYER_STATE_RESOURCE_GOLD);
    sender.send();
    sender.destroy();
}

Using the index of the player directly as opposed to running a lot of conditions that would only achieve the same thing would be preferred.
For even more optimization, you can save it to a variable and reference that variable instead of manually getting the index of the player each time.

 

[Rugarus]

That's quite a lot of maxSendLimits you have there. You could actually (drastically) shorten the code into something like this:

if (maxSendLimit[GetPlayerIndex(p)]+r_amount <= 2 && GetPlayerState(p, PLAYER_STATE_RESOURCE_GOLD) > 0)    {
    maxSendLimit[GetPlayerIndex(p)] = maxSendLimit[GetPlayerIndex(p)] + r_amount;
    sender = ResourceSender.create(r_amount, p, r_player, PLAYER_STATE_RESOURCE_GOLD);
    sender.send();
    sender.destroy();
}

Using the index of the player directly as opposed to running a lot of conditions that would only achieve the same thing would be preferred.
For even more optimization, you can save it to a variable and reference that variable instead of manually getting the index of the player each time.

Ok thanks, I found the issue it was that when I was adding the maxSendLimit + r_amount I didn't index it properly for the other colors so they were werent adding it. I'll do what you said though.

 

[Rugarus]

That's quite a lot of maxSendLimits you have there. You could actually (drastically) shorten the code into something like this:

It says 'GetPlayerIndex' undeclared function.[/QUOTE]

 

[MyPad]

My mistake. It should be GetPlayerId, instead of GetPlayerIndex.

@Rugarus
And also, one must not double-post his or her message within 48 hours unless it is an update. You can use the edit button to merge your previous and current message.