[JASS] Sacing integer in hashtable

[Garfield1337]

Can someone explain me why in this function...

function Track_Actions takes nothing returns nothing
    set bj_lastCreatedUnit =  CreateUnit(GetOwningPlayer(GetTriggerUnit()),'h005',GetUnitX(GetSpellTargetUnit()),GetUnitY(GetSpellTargetUnit()),0.00)
    call UnitApplyTimedLife(bj_lastCreatedUnit, 'BTLF',1.00)
    call IssueTargetOrder(bj_lastCreatedUnit, "faeriefire", GetSpellTargetUnit())
    call SaveInteger(udg_Hashtable,GetHandleId(GetSpellTargetUnit()),1,10)
    call SaveInteger(udg_Hashtable,GetHandleId(GetSpellTargetUnit()),2,GetPlayerId(GetOwningPlayer(GetTriggerUnit())))
endfunction

...the SaveInteger functions don't work? (The values don't get saved)
Also if i put them on function start like...

function Track_Actions takes nothing returns nothing
    call SaveInteger(udg_Hashtable,GetHandleId(GetSpellTargetUnit()),1,10)
    call SaveInteger(udg_Hashtable,GetHandleId(GetSpellTargetUnit()),2,GetPlayerId(GetOwningPlayer(GetTriggerUnit())))    
    set bj_lastCreatedUnit =  CreateUnit(GetOwningPlayer(GetTriggerUnit()),'h005',GetUnitX(GetSpellTargetUnit()),GetUnitY(GetSpellTargetUnit()),0.00)
    call UnitApplyTimedLife(bj_lastCreatedUnit, 'BTLF',1.00)
    call IssueTargetOrder(bj_lastCreatedUnit, "faeriefire", GetSpellTargetUnit())
endfunction

...they do work!
How can function schedule affect it?!

Oh and "Sacing" is a typo,it's supposed to be "Saving"...

 

[Berb]

Have you tried putting debug messages throughout the code? Perhaps one of your other lines of code is causing the thread to crash. It doesn't appear to be wrong in any way but maybe I am missing something, I would check anyways. Also where do you initialize udg_Hashtable?

 

[D4RK_G4ND4LF]

call IssueTargetOrder(bj_lastCreatedUnit, "faeriefire", GetSpellTargetUnit())
this will change the result of
GetSpellTargetUnit()
so actually you are saving the stuff to bj_lastCreatedUnit instead

edit:
right
that does not make sense
I once had a similar problem (a little more obfuscated though)
but even if it does not make sense it might be the cause
I'm curious about what will happen if you comment out the order (it's a spell order nevertheless and GetSpellTargetUnit is very touchy)

 

[Garfield1337]

@Berb,
It doesn't crash or give errors,it doesn't seem to save it properly. It returns 0 when i load it in other trigger. Also i do init hashtable at another trigger,the hashtable works in some other triggers.

@G4ND4LF,
How can issuing order change the result of GetSpellTargetUnit?
The last created unit isn't the target

 

[WaterKnight]

How can issuing order change the result of GetSpellTargetUnit?
The last created unit isn't the target

Well, because it does. Probably it's a bug but GetSpellTargetUnit is not very constantly (maybe even locally) protected. Issuing an order overwrites it. I do not know whether it changes to the ordered unit but imho it is common sense to save event responses at the beginning of the thread.

 

[Bribe]

I would like to see the initialiser for this trigger (including how it is called). Other than that, use this because it doesn't leak the locations.

function Track_Actions takes nothing returns nothing
    local unit u = GetSpellTargetUnit()
    set bj_lastCreatedUnit = CreateUnit(GetTriggerPlayer(), 'h005', GetSpellTargetX(), GetSpellTargetY(), 0.)
    call BJDebugMsg("dummy created")
    call UnitApplyTimedLife(bj_lastCreatedUnit, 'BTLF', 1.)
    call IssueTargetOrder(bj_lastCreatedUnit, "faeriefire", u)
    call BJDebugMsg("dummy cast spell")
    call SaveInteger(udg_Hashtable, GetHandleId(u), 1, 10)
    call SaveInteger(udg_Hashtable, GetHandleId(u), 2, GetPlayerId(GetTriggerPlayer()))
    call BJDebugMsg("variables saved")
    set u = null
endfunction

If all three debug messages show up, your problem lies elsewhere.

 

[Garfield1337]

After setting local unit 'u' that would be SpellTargetUnit it worked. It seems that Issuing target order does change GetSpellTargetUnit() result.
Thanks to everyone who helped.

 

[Berb]

What a bug.