[vJASS] Running Method on Event occurs

[khamarr3524]

How do I make a method inside a struct run when an event other than onInit occurs?

 

[WaterKnight]

An event runs a trigger. The trigger registers functions to run via TriggerAddCondition or TriggerAddAction.

When the function is inside the same struct, write

call TriggerAddCondition(trigger, Condition(function thistype.method))

respectively

call TriggerAddAction(trigger, function thistype.method)

From outside of the struct, use

call TriggerAddCondition(trigger, Condition(function struct.method))

call TriggerAddAction(trigger, function struct.method)

For this, the method must be public (it is on default).

 

[PurplePoot]

Note that that only works for static methods. You can't make a non-static method run (for obvious reasons, but a lot of people seem to get tripped up on this).

 

[khamarr3524]

To save forum space, I was wondering if anyone knew why running a ForGroup() native inside a struct isn't working for me. I tried a workaround in the GroupEnumUnit using the function as a filter, as suggested by Illidan, and that also didn't work o.o

 

[Dr Super Good]

The filter/iterator function does not inherit the object the method is running on. The function passed to ForGroup() has to take nothing and return nothing.

 

[khamarr3524]

They are. See code below.

struct Jump extends array
    private static integer spell = 'Aroc'
    private static rect area = gg_rct_GiveSpell
    
    private static method GiveSpell takes nothing returns nothing
        local unit u = GetEnumUnit()
        local location loc = Location(GetRectCenterX(gg_rct_ResendSpell),GetRectCenterY(gg_rct_ResendSpell))
        call UnitAddAbility(u, spell)
        call SetUnitPositionLoc(u, loc)
        set loc = null
        set u = null
    endmethod
    
    private static method CheckUnit takes nothing returns nothing
        local group g = CreateGroup()
        call GroupEnumUnitsInRect(g, area, null)
        call ForGroup(g, function thistype.GiveSpell)
        call DestroyGroup(g)
        set g = null
    endmethod
    
    static method Main takes nothing returns nothing
        call .CheckUnit()
    endmethod
endstruct

They are taking and returning nothing. Should I not use static method main to call the private method CheckUnit and then just call CheckUnit in the trigger?

 

[Dr Super Good]

You sure area has a value?

private static rect area = gg_rct_GiveSpell
The allocation might be occuring before gg_rct_GiveSpell is given a value.

 

[khamarr3524]

I'll try setting the area variable before I call the initiation method to run in Main.

 

[khamarr3524]

Same result, nothing is happening.

 

[PurgeandFire]

When is the static method "Main" being called? Try doing this instead:

struct Jump extends array
    private static integer spell = 'Aroc'
    private static rect area = null
    
    private static method GiveSpell takes nothing returns nothing
        local unit u = GetEnumUnit()
        local location loc = Location(GetRectCenterX(gg_rct_ResendSpell),GetRectCenterY(gg_rct_ResendSpell))
        call UnitAddAbility(u, spell)
        call SetUnitPositionLoc(u, loc)
        set loc = null
        set u = null
    endmethod
    
    private static method CheckUnit takes nothing returns nothing
        local group g = CreateGroup()
        call DestroyTimer(GetExpiredTimer())
        set thistype.area = gg_rct_GiveSpell
        call GroupEnumUnitsInRect(g, area, null)
        call ForGroup(g, function thistype.GiveSpell)
        call DestroyGroup(g)
        set g = null
    endmethod
    
    private static method onInit takes nothing returns nothing
        call TimerStart(CreateTimer(), 0, false, function thistype.CheckUnit)
        // by running a 0 second timer you ensure that the region has been
        // created... otherwise it may return null as DSG said
    endmethod
endstruct

 

[Dr Super Good]

Could you post the compiled script? Do remember that vJASS still compiles to JASS inorder for WC3 to be able to understand it.

 

[khamarr3524]

Sorry, I use a jass trigger to compare multiple things and do more functions to call Main. I'll post this code now.

function CheckUnitCond takes unit u returns boolean
    local integer typeUnit = 'hfoo'
    local region r = CreateRegion()
    call RegionAddRect(r, gg_rct_GiveSpell)
    if GetUnitTypeId(u) == typeUnit and IsUnitInRegion(r, u) == true then
        return true
    else
        return false
    endif
endfunction

function DoSpellGive takes nothing returns nothing
local unit u = GetEnumUnit()
   if CheckUnitCond(u) == true then
        call Jump.Main()
    endif
    set u = null
endfunction

function Main takes nothing returns nothing
    local group g = CreateGroup()
    call GroupEnumUnitsInRect(g, gg_rct_GiveSpell, null)
    call ForGroup(g, function DoSpellGive)
    call DestroyGroup(g)
    set g = null
endfunction
function InitTrig_Run_Jump takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterTimerEvent(t, 1., true)
    call TriggerAddAction(t, function Main)
    set t = null
endfunction

 

[Arhowk]

If my workaround didnt work, than you did something wrong

First, it would be GetFilterUnit() not GetEnumUnit()
you would also have to do returns boolean and return false at the end

in order to use the filter as the function

also, at your function, wtf is Jump.main()? if that was inside the script, it would just enum the units again causing a loop crash

 

[khamarr3524]

Jump.Main() is used by ForGroup(). ForGroup() sends a EnumUnit to the function called. From this function I run the checks on the unit, then if it returns true, i run Jump.Main() for that unit which gives it the command to train the unit to have an ability and move it through the struct.