[JASS] return not working

[Chaosy]

hey, im trying to return a boolean value but it allways returns false for some reason.

function IsDestructableTree takes destructable udg_ISD_d returns boolean udg_ISD_boolean
return GetUnitCurrentOrder(udg_ISD_dummy) == 852018
endfunction

 

[rulerofiron99]

Try:

function IsDestructableTRee takes destructable d returns boolean
    if GetUnitCurrentOrder(udg_ISD_dummy) == 852018 then
        call BJDebugMsg("yep")
        return true
    endif
    return false
endfunction

EDIT: Why does it even take a destructable?

 

[Chaosy]

I did that then it only returns false

edit: that is not the full trigger but I use it within the trigger

 

[ap0calypse]

I'm going to assume you shortened the code for us (because that would throw in an error and there's some obsolete stuff).

If you right-click harvest, then it's a "smart" order and not a "harvest" one. Keep that in mind (I believe it should return true if you specifically click "gather" and then click the tree).

 

[Chaosy]

The rest of the code works fine it workef before when I used a hashtable to store a boolean. And I order a unit to harvest via triggers not manually

 

[themerion]

Well, all you can do is to check the unit and the return from GetUnitCurrentOrder. Either that function doesn't work like you think it does, or the unit is null...

function IsDestructableTree takes destructable d returns boolean
    call BJDebugMsg("Unit: "+GetUnitName(udg_ISD_dummy))
    call BJDebugMsg("Order: "+I2S(GetUnitCurrentOrder(udg_ISD_dummy)))
    return GetUnitCurrentOrder(udg_ISD_dummy) == 852018
endfunction

But... if you want to check if a destructable is a tree, I think you can just use (with a unit that has eat-tree, on a copy of the targeted object).

if IssueTargetOrder(dummy, "eattreeorwhatev", destructible) then
   // Is tree
endif

 

[Teelo]

Post the entire function. Doesn't matter if the rest of it works - we can't help with with why a "return" isn't working if you only give us half the code.

 

[Almia]

Just do what i suggested to you.

It is from Mag's Atomic Bomb's way of destroying/checking trees

 

[Teelo]

If you want our help, you need to put in the effort of providing the code you want help with. It is a bit rude to expect us to go looking for your code.

 

[Almia]

set bool = IssueTargetOrderById(checker, OrderId("harvest"), d) and IssueImmediateOrderById(checker, OrderId("stop"))

This is want im talking about.He never listened