[JASS] Can this be shortened??

[CrueIIntentions]

I read one tutorial (or i misinterpreted it) that you can use multiple conditions if you separate them with a comma. If this is so, can this be shortened??

function Trig_Max_Red_Func003001 takes nothing returns boolean
    return ( GetUnitTypeId(GetTrainedUnit()) != 'u008' )
endfunction

function Trig_Max_Red_Func003002001 takes nothing returns boolean
    return ( GetUnitTypeId(GetTrainedUnit()) != 'nhem' )
endfunction

function Trig_Max_Red_Func003002002001 takes nothing returns boolean
    return ( GetUnitTypeId(GetTrainedUnit()) != 'ohun' )
endfunction

function Trig_Max_Red_Func003002002002001 takes nothing returns boolean
    return ( GetUnitTypeId(GetTrainedUnit()) != 'ushd' )
endfunction

function Trig_Max_Red_Func003002002002002001 takes nothing returns boolean
    return ( GetUnitTypeId(GetTrainedUnit()) != 'n00O' )
endfunction

function Trig_Max_Red_Func003002002002002002001 takes nothing returns boolean
    return ( GetUnitTypeId(GetTrainedUnit()) != 'efon' )
endfunction

function Trig_Max_Red_Func003002002002002002002 takes nothing returns boolean
    return ( GetUnitTypeId(GetTrainedUnit()) != 'ncer' )
endfunction

function Trig_Max_Red_Func003002002002002002 takes nothing returns boolean
    return GetBooleanOr( Trig_Max_Red_Func003002002002002002001(), Trig_Max_Red_Func003002002002002002002() )
endfunction

function Trig_Max_Red_Func003002002002002 takes nothing returns boolean
    return GetBooleanOr( Trig_Max_Red_Func003002002002002001(), Trig_Max_Red_Func003002002002002002() )
endfunction

function Trig_Max_Red_Func003002002002 takes nothing returns boolean
    return GetBooleanOr( Trig_Max_Red_Func003002002002001(), Trig_Max_Red_Func003002002002002() )
endfunction

function Trig_Max_Red_Func003002002 takes nothing returns boolean
    return GetBooleanOr( Trig_Max_Red_Func003002002001(), Trig_Max_Red_Func003002002002() )
endfunction

function Trig_Max_Red_Func003002 takes nothing returns boolean
    return GetBooleanOr( Trig_Max_Red_Func003002001(), Trig_Max_Red_Func003002002() )
endfunction

function Trig_Max_Red_Conditions takes nothing returns boolean
    if ( not GetBooleanOr( Trig_Max_Red_Func003001(), Trig_Max_Red_Func003002() ) ) then
        return false
    endif
    if ( not ( CountUnitsInGroup(GetUnitsOfPlayerAll(Player(10))) > 100 ) ) then
        return false
    endif
    return true
endfunction

function Trig_Max_Red_Actions takes nothing returns nothing
    call KillUnit( GetTrainedUnit() )
endfunction

//===========================================================================
function InitTrig_Max_Red takes nothing returns nothing
    set gg_trg_Max_Red = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Max_Red, EVENT_PLAYER_UNIT_TRAIN_FINISH )
    call TriggerAddCondition( gg_trg_Max_Red, Condition( function Trig_Max_Red_Conditions ) )
    call TriggerAddAction( gg_trg_Max_Red, function Trig_Max_Red_Actions )
endfunction

EDIT: I just converted GUI to custom, obviously.

 

[GhostWolf]

and
or

 

[CrueIIntentions]

uh. I dont follow. If the trigger is in JASS format, and/or would work???

 

[aznricepuff]

Jass has two boolean operators besides the == (equal to) operator that can operate on booleans (>, <, >=, <=, != only work on numerical types):

• and
• or

EDIT: Jass also has the operator NOT, which basically flips the boolean (if true, then return false; if false, then return true)

so instead of

function func_01 takes nothing returns boolean
    return true
endfunction

function func_02 takes nothing returns boolean
    return false
endfunction

function conditions takes nothing returns boolean
    if ( GetBooleanOr( func_01(), func_02() ) ) then
        return true
    endif
    return false
endfunction

you could instead do:

function conditions takes nothing returns boolean
    if ( func_01() or func_02() ) then
        return true
    endif
    return false
endfunction

or better yet:

function conditions takes nothing returns boolean
    return ( func_01() or func_02() )
endfunction

and you can link as many booleans together with or's/and's as you want. However, if you mix the two, you need to think about which get evaluated first, as in that case order matters. To force certain ones to be evaluated first, just use parentheses.

 

[CrueIIntentions]

Well, when i converted the trigger. all of those where "or" already.

• Events
• Unit - A unit finishes training
• Conditions
• ((unit type of (trained unit)) not equal to (citizen_one ) or (((unit-type of (trained unit)) not equal to (citizen_2) // < I have 7 of these, all of them are the same.>
• (Number of units in (Units owned by Player x (color) greater than or 100
• Actions
• Unit - Kill trained unit.

Does this still apply? I substituted "Red max" to "citizen_1" etc.

 

[bountygiver]

Well, usually I use a dummy boolean for "or" functions. Every time an "or" condition is met then it changes the value of the dummy boolean. Finally, I add an "if" function for the dummy boolean to run my actions. This is useful if I have more than 2 "or" conditions to take account of.

 

[CrueIIntentions]

what do you mean by a dummy boolean? Im still pretty new to JASS, I dont really understand what you mean.
Sorry

 

[Element of Water]

what do you mean by a dummy boolean? Im still pretty new to JASS, I dont really understand what you mean.
Sorry

He means make one global boolean, then set it every time he needs a boolean value... but I don't see the point in that.

 

[aznricepuff]

You can chain as many OR's together as you want.

if ( a or b or c or d or e or f or g ) then
return true
endif
return false

if one of those conditions is true, then it will return true. If all of them are false, then it will return false

 

[bountygiver]

He means make one global boolean, then set it every time he needs a boolean value... but I don't see the point in that.

Oops, I NEVER use global booleans, I'll always make it local. Or, you may create a dummy unit and kill it as soon as one of the "or" conditions fail to meet. This method is basically quite the same as above, and it's more suited for JASS beginners.