-
Demon Slash Loop
-
Events
-
Time - Every 0.03 seconds of game time
-
Conditions
-
Actions
-
Set TempPoint = (Position of DemonSlash_TrigUnit)
-
Set DemonSlash_UnitGroup = (Units within 75.00 of TempPoint)
-
Unit Group - Pick every unit in DemonSlash_UnitGroup and do (Actions)
-
Loop - Actions
-
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
-
If - Conditions
-
(((Picked unit) belongs to an enemy of (Owner of DemonSlash_TrigUnit)) Equal to True) and (((Picked unit) is alive) Equal to True) and (Picked unit) is in (UnitGroup2) Equal to False
-
Then - Actions
-
Special Effect - Create a special effect attached to the origin of (Picked unit) using Abilities\Spells\Human\Banish\BanishTarget.mdl
-
Special Effect - Destroy (Last created special effect)
-
Unit - Cause DemonSlash_TrigUnit to damage (Picked unit), dealing Damage[Damage_Integer] damage of attack type Spells and damage type Normal
-
Unit - Add (Picked Unit) to (UnitGroup2)
-
Else - Actions
-
Custom script: call DestroyGroup(udg_DemonSlash_UnitGroup)
-
Custom script: call RemoveLocation(udg_TempPoint)
Some issues:
1st: You use (Picked Unit) Many, many times. Use a Variable = (Picked Unit) and use the variable instead. Is faster, and matters if you have a 0.03 loop.
2nd: When does this trigger turns on?
3rd: When does this trigger turns off?
4th: Why 2 unit groups, if you don't really need them? These takes important memory space.
5th: Ussually attached special effects doesn't work if destroyed inmediatly.
So far, we have a constantly on periodic trigger (even if it isn't needed) creating/destroying groups, points and effects every 0.03 seconds just to detect if there's a unit near and do damage once.
I would rather use a Damage Detection System to detect 0 damage with inmolation (wich resembles the constant pick every unit around), check for the Unit Type of the damage source to match this Unit Type, if true, then check if the unit is in NoDamageGroup = false, then check the distance, if less than 75, do the triggered damage and add to NoDamageGroup
I could also avoid the Unit Group with Bribe's Unit Indexer and a NoDamageBoolean array wich is way faster than Unit Group Loops. Alternatively, I could also use a Hashtable instead of a NoDamageGroup and save a boolean in the UnitID to know if it has already been damage once for being near.
SO FAR, most maps will need a Hashtable/UnitIndexer and a Damage Detection System. Both systems are pretty safe and efficient, and are used to improve efficiency of all these things. I would also jass it all, use locals, avoid locations, and creating/destroying the effect, but just destroy it. Could also avoid One group to pick units, and another to Nodamage, and use call GroupEnumUnitsInRange wich already enums units around into a default group as bj_lastCreatedGroup and add these picked units to the NoDamageGroup
If the whole map consist on just this ability (which I doubt), then it's fine, but if it's going to have more things that requires damage being detected, then DDS is the way.
BTW, what damage detection does is creating in an efficient way specific unit events "A unit takes damage" and adds to a variable the DamageSource and DamagedUnit, so the trigger destroys itselfs and recreates itselfs to clean the event leaks (like units that already died, and there's no need to detect if those units are damaged, that would be an Event Leak). And bribe's indexer is, precisely, to avoid using unit groups and/or hashtables, since arrays are faster.
Demon Slash Loop
