[Solved] How can i remove these leaks?

[JFAMAP]

I believe i make it mui but i am not 100% sure

• Shockwaves
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Shockwave //
  • Actions
    • Set TempPointShockwave[(Custom value of (Triggering unit))] = (Target point of ability being cast)
    • Set TempCasterShockwave[(Custom value of (Triggering unit))] = (Triggering unit)
    • Wait 0.75 seconds
    • Set TempGroupShockwave[(Custom value of (Triggering unit))] = (Units within 300.00 of TempPointShockwave[(Custom value of (Triggering unit))])
    • Special Effect - Create a special effect at TempPointShockwave[(Custom value of (Triggering unit))] using Units\NightElf\Wisp\WispExplode.mdl
    • Special Effect - Destroy (Last created special effect)
    • Unit Group - Pick every unit in TempGroupShockwave[(Custom value of (Triggering unit))] and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) belongs to an enemy of (Owner of TempCasterShockwave[(Custom value of (Triggering unit))])) Equal to True
            • ((Picked unit) is A structure) Equal to False
            • ((Picked unit) is Mechanical) Equal to False
            • ((Picked unit) is alive) Equal to True
            • ((Picked unit) is Magic Immune) Equal to False
          • Then - Actions
            • Unit - Cause TempCasterShockwave[(Custom value of (Triggering unit))] to damage (Picked unit), dealing (Real((Strength of TempCasterShockwave[(Custom value of (Triggering unit))] (Include bonuses)))) damage of attack type Spells and damage type Magic
          • Else - Actions
    • Custom script: call RemoveLocation(udg_TempPointShockwave)
    • Custom script: call DestroyGroup(udg_TempGroup)

First i want to be sure that. Every player only can have one Hero.
Does it works without issue and how can i remove this leaks? I am not familiar with arrays.

 

[Pyrogasm]

• Custom script: call RemoveLocation(udg_TempPointShockwave)
• Custom script: call DestroyGroup(udg_TempGroup)

Those variables are arrays and you are not giving an array index like [6]. You need to convert "Custom value of (Triggering unit)" into JASS and use it in those variable removal lines.

How do you learn what JASS means what? Make a new, blank trigger. Copy and paste the line into this new blank trigger. Navigate at the top to Edit > Convert to Custom Text, which will convert the trigger from GUI to JASS. Then look at the line and grab the part you need. Most JASS functions have names that make it obvious what they do.

[GetUnitUserData(GetTriggerUnit())]

---

That said... there is no reason the point and group have to be array variables here. They aren't saved during a wait or while another trigger does something, so they can just be some temporary variables. Make them regular non-arrays and it will be fine. This is what people use tempgroup or temppoint for.

 

[JFAMAP]

Wow. I was using this but i forgot. By the way is it works now? If Player 2 and Player 3 Casts shockwave, this 0.50 seconds wait will work "without any issue" for both? If yes, it is solved.

 

[Pyrogasm]

I’m not going to answer that question directly and instead ask you to think about it yourself so you can practice this skill. Which variables are being used? Would a second simultaneous cast overwrite them and cause issues? Are the objects they point to properly removed/destroyed?

 

[JFAMAP]

I have tested and it seems ok. But i am never using wait action just like this. This is why i am not sure 100% but i can say it is 99% correct. Because each Integers are unique. Solved.

 

[GIMLI_2]

That would work if
1. you have a unit indexer
2. the same unit does not cast the ability again in 0.75 seconds

There is a lot of unnecessary stuff and you are leaking, but it would work.

 

[JFAMAP]

That would work if
1. you have a unit indexer
2. the same unit does not cast the ability again in 0.75 seconds

There is a lot of unnecessary stuff and you are leaking, but it would work.

This is why i have asked actually. This is the trigger after Pyrogasm show me the [GetUnitUserData(GetTriggerUnit())]

• Shockwaves
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Shockwave //
  • Actions
    • Set TempPointShockwave[(Custom value of (Triggering unit))] = (Target point of ability being cast)
    • Set TempCasterShockwave[(Custom value of (Triggering unit))] = (Triggering unit)
    • Wait 0.75 seconds
    • Set TempGroupShockwave[(Custom value of (Triggering unit))] = (Units within 300.00 of TempPointShockwave[(Custom value of (Triggering unit))])
    • Special Effect - Create a special effect at TempPointShockwave[(Custom value of (Triggering unit))] using Units\NightElf\Wisp\WispExplode.mdl
    • Special Effect - Destroy (Last created special effect)
    • Unit Group - Pick every unit in TempGroupShockwave[(Custom value of (Triggering unit))] and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • ((Picked unit) belongs to an enemy of (Owner of TempCasterShockwave[(Custom value of (Triggering unit))])) Equal to True
            • ((Picked unit) is A structure) Equal to False
            • ((Picked unit) is Mechanical) Equal to False
            • ((Picked unit) is alive) Equal to True
            • ((Picked unit) is Magic Immune) Equal to False
          • Then - Actions
            • Unit - Cause TempCasterShockwave[(Custom value of (Triggering unit))] to damage (Picked unit), dealing (Real((Strength of TempCasterShockwave[(Custom value of (Triggering unit))] (Include bonuses)))) damage of attack type Spells and damage type Magic
          • Else - Actions
    • Custom script: call RemoveLocation(udg_TempPointShockwave[GetUnitUserData(GetTriggerUnit())])
    • Custom script: call DestroyGroup(udg_TempGroupShockwave[GetUnitUserData(GetTriggerUnit())])