[JASS] RemoveDestructable -> Crash

[pred1980]

Hey hivers,

what im doing?

Well, i created a destructable which looks like a gravestone. The players can just attack it by right click and im listen to the death event of it.
When the gravestone is destroyed i want to remove it but the call of RemoveDestructalbe() crashes the game.

It's strange that the destructable after killing is still there. it cant be attack but its visual there and that sucks... I could hide it, i think that should work but can i remove it correctly to avoid leaks... is hiding and d=null enough??


Reg.

 

[chobibo]

Use an immobile(and non-attacking) unit instead of a destructable.
If you don't want to, post the map or the script for debugging.

 

[pred1980]

Use an immobile(and non-attacking) unit

Example unit? And... can that unit attacked by right-click?

 

[chobibo]

You could just set a unit's movespeed to 0 (in the object editor of world editor), that would make it immobile. It can be targeted by a smart command (right-click), but if you want player to be able to attack right-click on it then you need to make it owned by the player Neutral Hostile.

 

[pred1980]

ok, I'll test it. But a MS to 0 is only possible if you change the minimum MS to 0 in the gameplay constants, afaik....

 

[chobibo]

Oh right, why don't you just post the triggers, maybe someone could help. (the destructable triggers)

 

[pred1980]

im not@home

code looks like:

1. call CreateDestrcutable()
2. Add Death-Event to the Destructable
3. If Destrcutable dies ( GetDyingDestructable()) --> Call RemoveDestrcutable(d) <- Crash!!! because i think the destrcutable instance does not exist anymore and i want to remove it... but its still there ( Model), but you can select it or attack it again... its just there.

 

[chobibo]

Is the destructable pre-placed using world editor or instantiated using a custom script (jass). Anyway I'm testing now, using a pre-placed destructable.

EDIT: can you tell me what destructable are you using? (i.e. Explosive Barrels Barrel of Explosives)

 

[pred1980]

Its a cage and i changed the categorie to "ruins or detritus" so it can be attack. I just gave the cage the model of a gravestone. not more.

 

[WaterKnight]

It's because the TriggerRegisterDeathEvent also reacts to RemoveDestructable and does not reset the values in time, thus forming an infinite loop. You could deactivate the trigger during the removal line for example.

 

[pred1980]

ahh, thats interesting... I'll test that! Before i remove it i'll try to deactivate the event.

 

[chobibo]

Here's my test map:
View attachment TEST_0.w3x

The gravestone model doesn't have a death animation, looks weird when you kill it lol.

If you don't trust maps or is unable to open it, here are the triggers:

Here are the triggers I used:
First, I created the Destructable

• Map Ini
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Destructible - Create a MyDestrucable at (Player 2 (Blue) start location) facing (Random angle) with scale 1.00 and variation 0
    • Set MyDestructable = (Last created destructible)
    • Trigger - Add to On Death <gen> the event (Destructible - MyDestructable dies)

Here is the death event trigger.

• On Death
  • Events
  • Conditions
  • Actions
    • Game - Display to Player Group - Player 1 (Red) for 10.00 seconds the text: Destructable died.
    • Wait 1.00 game-time seconds
    • Game - Display to Player Group - Player 1 (Red) for 10.00 seconds the text: Removing Destructab...
    • Destructible - Remove MyDestructable

These triggers worked properly, upon destructable death, it waited 1 second then removed the destructable, in-game the destructable also vanished(the model).

EDIT: Looks like WaterKnight's answer is better than mine.

 

[pred1980]

can you test it pls if its correct by removing the event? i just want to know if its the solution.