Remove Dying Destructible -> crash

[Deon]

 / [GUI] Remove Dying Destructible -> crash[/b]

Greetings!

I am trying to remove trees on death (to remove a stump) because I place a "sapling" destructible on their place which turns into a tree on season change.

The problem is: whenever I try to remove "event response - dying destructable", the game crashes when I try to chop the tree.

This is my current code:

This is called on map initialization:
[code=jass]    call EnumDestructablesInRectAll( gg_rct_Outdoors, function Trig_RegisterTreeDeath )

The function is:

function Trig_RegisterTreeDeath takes nothing returns nothing
    call TriggerRegisterDeathEvent( gg_trg_Woodcutting, GetEnumDestructable() )
endfunction

The trigger "gg_trg_Woodcutting" which starts when a tree is cut:

function Trig_Woodcutting_Actions takes nothing returns nothing
    local location locTreePosition
    set locTreePosition = GetDestructableLoc(GetDyingDestructable())
    call CreateDestructableLoc( 'B000', GetDestructableLoc(GetDyingDestructable()), 0, 0.2, 0 )
    call RemoveDestructable( GetDyingDestructable() )
endfunction

//===========================================================================
function InitTrig_Woodcutting takes nothing returns nothing
    set gg_trg_Woodcutting = CreateTrigger(  )
    call TriggerAddAction( gg_trg_Woodcutting, function Trig_Woodcutting_Actions )
endfunction

The problem is with the string:

    call RemoveDestructable( GetDyingDestructable() )

which is equal to a GUI "Remove Destructable (Event response - Dying destructable)".

I don't get why does it crash.

 

[Adiktuz]

Greetings!

I am trying to remove trees on death (to remove a stump) because I place a "sapling" destructible on their place which turns into a tree on season change.

The problem is: whenever I try to remove "event response - dying destructable", the game crashes when I try to chop the tree.

This is my current code:

This is called on map initialization:

    call EnumDestructablesInRectAll( gg_rct_Outdoors, function Trig_RegisterTreeDeath )

The function is:

function Trig_RegisterTreeDeath takes nothing returns nothing
    call TriggerRegisterDeathEvent( gg_trg_Woodcutting, GetEnumDestructable() )
endfunction

The trigger "gg_trg_Woodcutting" which starts when a tree is cut:

function Trig_Woodcutting_Actions takes nothing returns nothing
    local location locTreePosition
    set locTreePosition = GetDestructableLoc(GetDyingDestructable())
    call CreateDestructableLoc( 'B000', GetDestructableLoc(GetDyingDestructable()), 0, 0.2, 0 )
    call RemoveDestructable( GetDyingDestructable() )
endfunction

//===========================================================================
function InitTrig_Woodcutting takes nothing returns nothing
    set gg_trg_Woodcutting = CreateTrigger(  )
    call TriggerAddAction( gg_trg_Woodcutting, function Trig_Woodcutting_Actions )
endfunction

The problem is with the string:

    call RemoveDestructable( GetDyingDestructable() )

which is equal to a GUI "Remove Destructable (Event response - Dying destructable)".

I don't get why does it crash.

first, the trigger leaks a location...

hmmm... cannot find a problem with that... try saving the destructable in a variable first...

 

[Mooglefrooglian]

Your trying to remove something that doesnt really exist probably (because it's dead). Try setting it to a variable, and waiting 5 seconds, then removing it. See if it crashes after those 5 seconds and work out a solution from there.

 

[Deon]

Thank you, I've found a different solution: I just hide it, and resurrect and show when needed. It looks even better this way because I can play death/birth animation when needed so the tree "grows" visually.

Can you tell me where is the leak please? *newb newb* *tip tip*

 

[Mooglefrooglian]

local location locTreePosition
    set locTreePosition = GetDestructableLoc(GetDyingDestructable())
    call CreateDestructableLoc( 'B000', GetDestructableLoc(GetDyingDestructable()), 0, 0.2, 0 )
    call RemoveDestructable( GetDyingDestructable() )

Personally, I dislike locations because of this crap. I advise using x and y if at all possible.

But the proper fix is:

local location locTreePosition
    set locTreePosition = GetDestructableLoc(GetDyingDestructable())
    call CreateDestructableLoc( 'B000', GetDestructableLoc(GetDyingDestructable()), 0, 0.2, 0 )
    call RemoveDestructable( GetDyingDestructable() )
    call RemoveLocation(locTreePosition)
    set locTreePosition = null

 

[watermelon_1234]

Since I know that you're trying to code with JASS, this is the code using x and y, courtesy of Mooglefrooglian's fixed code:

local destructable d = GetDyingDestructable() //You will use this multiple times so you might as well as use a variable.
call CreateDestructable( 'B000',GetDestructableX(d),GetDestructableY(d), 0, 0.2, 0 )
call RemoveDestructable(d)
set d = null //Prevent leaks