[JASS] Problem with IsUnitInGroup

[dardas]

Hey.. im working on a system that picks every unit in a group, and is added by public function called add,

everything works fine, and all.. but when the same unit is added twice, it does same effect on same unit, just twice.

for example, making him move a bit to the right, he will do that twice instead of once.

i used the IsUnitInGroup(GroupName, Unit), and for some reason. it still does it twice.. any ideas?

TheCode

public function Add takes unit u, real x returns nothing
    
        call UnitAddAbility(u, 'Amrf')
        call UnitRemoveAbility(u, 'Amrf')
        call MC_Actions(u)
        
            if MC_UIGD == true then
                    
                call SetUnitFlyHeight(u, x + 50, 0)
                set MC_UIGD = false
                    
            elseif MC_UIGU == true then
                    
                call SetUnitFlyHeight(u, x - 50, 0)
                set MC_UIGU = false
                    
            elseif MC_UISS == true then
            
                call SetUnitFlyHeight(u, x, 0)
                set MC_UISS = false
                
            endif
            
                if IsUnitInGroup(u, Group) == false then
                    call GroupAddUnit(Group, u)
                endif
endfunction

thanks in advance.

 

[Anachron]

public function Add takes unit u, real x returns nothing
		if not IsUnitInGroup(u, Group) then
			call GroupAddUnit(Group, u)
		else
			return
		endif

    
        call UnitAddAbility(u, 'Amrf')
        call UnitRemoveAbility(u, 'Amrf')
        call MC_Actions(u)
        
		if MC_UIGD == true then
				
			call SetUnitFlyHeight(u, x + 50, 0)
			set MC_UIGD = false
				
		elseif MC_UIGU == true then
				
			call SetUnitFlyHeight(u, x - 50, 0)
			set MC_UIGU = false
				
		elseif MC_UISS == true then
		
			call SetUnitFlyHeight(u, x, 0)
			set MC_UISS = false
			
		endif
            
endfunction

Try this, it checks before making any action.

 

[dardas]

Thats great.. but it never works after first try now.. AND Yes it does remove him from group, cuz i did DisplayTextToForce when inside group.. and it stops showing after 3-5 seconds...

edit: aha.. my bad, it works perfect, thanks alot =]

 

[Anachron]

Great, glad it works.