OxygenD KnockJump 1.0

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

15:09, 28th Jun 2011
Maker:
CreateMine shouldn't be on all the time.
CreateMine has location leak and remove the Do nothing.
MineDie could be turned off when there are no mines around.
You're not nulling units in KnockBack.
Why are KnockBackUnit_Timer and KnockBackUnit in the map header?

 

[x3GlikE]

Use copy text instead of screenshot it.

 

[88WaRCraFT3]

I Agree with x3glike... and you guys should seriously start making original stuff....

 

[OxygenD]

How can I copy GUI text ?

 

[OxygenD]

I can convert GUI into the jass, but it is not quite true.

 

[x3GlikE]

Left click on the sidebar text, the paper and press copy text than Ctrl - V using Tags.

 

[OxygenD]

x3GlikE sorry, i dont understan -_-

 

[x3GlikE]

Left click on actions than press on copy text than paste it.

 

[OxygenD]

This ability MUI and i think, it working correctly. Click to approved guys

 

[OxygenD]

Left click on actions than press on copy text than paste it.

Click where? In WE?

 

[x3GlikE]

Please do not double post and I will do it for you.
Did you Edit -> Convert to custom text?

 

[OxygenD]

x3GlikE, ok

 

[Manasurge]

>.<*
Click the trigger.
Move your mouse inside the trigger
Scroll up
Right Click the trigger
Select Copy as Text
write [TRIGGER*] [/TRIGGER*] and paste between them without the *

 

[Nightmare Moon]

This PHP code hurts my eyes... Please use JASS tags. List of [self="http://www.hiveworkshop.com/forums/misc.php?do=bbcode"]List of BB codes[/self]. Also it would be nice if i could understand in what language is that... Also i can see that you leak locations and use Do Nothing maybe something more but can't understand anything else.

 

[OxygenD]

I do it!!DD

 

[OxygenD]

I did everything you asked for was change screens to GUI text and changed the code to monochrome.

 

[Nightmare Moon]

For a JASS code use this: [jass=]Paste some jass here[/jаss]

 

[OxygenD]

Finish rate Design! Start rate spell!

 

[Nightmare Moon]

Okay so you wanna review? Here it is

-why Init trigger is in JASS? no need, and if you made it in JASS then make all in JASS,then merge them and use locals instead of variables;
-in second trigger you leak location here> Unit - Create 1 Mine for (Owner of MCaster[MIndex]) at (Position of MCaster[MIndex]) facing Default camera angle of attack degrees, (Position of MCaster[MIndex]) should be stored into variable and then destroyed;
-in same trigger you use Do Nothing action; get rid of it;
-in trigger KnockJump cannot tell much sine i just learn vJASS, expect someone else to review last trigger

And design is important since a lot of us don't even use WE to test spells! All comes from the code in description... Also i can hardly understand the system description...
Don't know what to give it since i don't find this useful...

 

[Marcos DAB]

Simple, maybe useful.

 

[Narogog]

this spell does not support multiple levels, it has cool effects, but looks weird when the units are thrown into water, they just move up and down.

 

[Magtheridon96]

Remove that "Do Nothing" ... Isn't obvious that a Do Nothing action literally does nothing but kill your performance??

Also, don't use integer A.
Use integer Variable (Integer A can cause bugs )

One other thing... you're missing a function:
function Trig_Mass_Flying_Knockback_Filter

And also, you don't HAVE to use 57.295827.
You can simply use bj_RADTODEG
It's fine this way though

I found 2 other missing functions

function Trig_Mass_Flying_Knockback_Timer

and

call KnockBackUnit(..)

Post triggers correctly >.>

 

[baassee]

Where is the knockbackjump system code?