[Crash] Odd Error of ownership

[Tal'Rarity]

Why does changing ownership from neutral to a player cause a d/c to people?

• Events
• Trigger - Add to Untitled Trigger 001 <gen> the event (Unit - (Picked unit) Takes damage)
• Conditions
  • ((Triggering unit) is in if2) Equal to True
  • (Owner of (Triggering unit)) Equal to Player 10 (Light Blue)/neutral passive
• Actions
  • Unit Group - Remove (Triggering unit) from if2
  • Unit - Change ownership of (Triggering unit) to Player 1 (Red) and Change color
  • Wait until (((Triggering unit) has buff In Battle) Not equal to True), checking every 5.00 seconds
  • Unit - Change ownership of (Triggering unit) to Player 10 (Light Blue)/neutral passive and Change color
  • Unit Group - Add (Triggering unit) to if2

 

[deathismyfriend]

It shouldn't. It has to be the way ur doing it. Whenever u ask for help show the triggers. That being said can u show the triggers pls

 

[Tal'Rarity]

Well it actually should happen to everyone, considering its happening to some of my friends too.

 

[deathismyfriend]

I believe it's the wait that is causing the problem. U should use an indexed array and check periodically with a trigger like how u would do a spell.

 

[Tal'Rarity]

Sadly you are wrong.

It is when neutral passive gets changed to a player that seems to cause the desync.
Reason: It works perfectly when neutral passive is player 10 with player 1.

I don't want to do all that work just for something that does not require it. Wait's aren't really that bad if you can work them successfully. Less Variables and triggers the better.

 

[deathismyfriend]

Waits are a bad idea. Also did u try wat I suggested

 

[Tal'Rarity]

Waits are not a bad idea.
No there is no need too. Since nobody can answer my question this thread is answered. I just won't use neutral passive for ownership switching. Thank you for replying myfriend.

 

[deathismyfriend]

to try my idea all u have to do is remove the wait. and yes waits are a bad idea for a few reasons. they are inaccurate, they continue to count down when the dc dialog box shows up. they can screw up MUI triggers. so yes they are a bad idea

 

[Tal'Rarity]

I have tried your idea before a long time ago. sure waits are inaccurate, but they're not too far off for me. If you use the game time wait it is different. They can make triggers/spells MUI. They're only bad if you don't know how to deal with em. Again though thanks. Your the only person to try to help.

You had a really good idea, but the thing is it has been tried as well this system works perfectly when not using neutral passive.

 

[Nichilus]

Offtopic:
If you're going to make that map multiplayer, you should get rid of waits.

 

[Tal'Rarity]

Nope.

 

[deathismyfriend]

Ok then. I've never heard about the bug. Only thing is waits get worse when in multiplayer.

 

[edo494]

I dont know about the crash, but

If you use wait, you will havr to get ready for some nasty things:
inaccuracy in single player - waits are always bit longer
inaccuracy in multiplayer - it is a lot worse, the wait is around quarter seconds longer, because the game must do some syncing and shit
inaccuracy is also increased because the thread that is sleeping must wait for the current running threas to finish execution
unstopabilty - waits will ignore the facts that your game is paused or minimalized(including dialogs), which makes things like cinematics lok shit when you have to minimalize the game and wait for bit
non MUIness - most event responses are killed by wait coomand, which means that everyting except GetTrigger... event functions return null(GetSpellTarget etc)
also if you use wait you have to use quite long code to allcate instances for every spell, while with timers or periodic triggers you need none

 

[Vinz]

Rather simple. create another unit group. Put all units removed from your variable into the new group. Then add an ITE and check if the unit is in the new group and has that buff. By doing so, you won't have to use waits.

Edit: Also put your old conditions and actions into an ITE.

 

[Zeatherann]

Waits are only evil due to the continuing countdown when paused. (This i did not know of)

Using other things besides waits (timers) requires a lot more effort in GUI, a bit more effort in JASS.

I don't know why changing ownership of a unit from Player(15) <neutral passive> to Player(0) <red> fails. Are you 100% sure that it bugs on the line that changes ownership? (remove all other actions after it to check).

 

[Tal'Rarity]

Everyone seems to fail to stay on-topic. Thread should get closed.

edo494, waits do not cause stuff to be non-MUI as well the unstopability is only if you use real seconds and not game time.

 

[Vinz]

Game time should never be used, and real time is not accurate. Try to use 'Skip Remaining Actions' after the line in which you change the ownership. That is, if you still want to solve this. You already wanted it to get closed.

 

[Zeatherann]

Do what Wrathion said, ignore people's stigmata of Waits and other things.

Gotta solve the issue before you worry about efficiency.

 

[deathismyfriend]

It's not anyones stigmata with dealing with waits lol

Waits are inaccurate. Waits do count down when the player desync dialog pops up in game.
It's simple facts. Not opinion. Waits don't make things MUI or non MUI. It's all by the way u handle them. Compared to timers waits have some pros and cons. Waits are easier to use. Timers r a lot more accurate especially when dealing w multiplayer games.
U have to go on those to make a good decision on wat u need. I personally always like accuracy over ease of making triggers. For that reason I will never suggest to use a wait in the trigger.

Look in my tutorial there is a link to the Inaccuracy of waits. U can counter the Inaccuracy a little when using that guide but not entirely.

As for ur original question did it get solved ? If not wat is still the problem ?

 

[Tal'Rarity]

Problem never got solved. It is okay tho.

 

[Zeatherann]

Gotta either post triggers, or do the checks we said.