nulling stuff (summoning deathismyfriend)

[caleman]

helps the map or not? also doesnt the vexorian optimizer do it for us?

 

[GreeN!X]

I'm not used to nulling stuff myself but they are helpful. (I'm lazy so that one extra custom script breaks me)

Vexorian just deletes extra stuff in the WE but I don't think it nulls thing for us.

 

[deathismyfriend]

if u null things null them at the end of the trigger.
nulling helps get rid of the pointer basically so it refreshes the handles faster. i always nul things. its really by choice tho

 

[Arhowk]

You should null anything that

1) Isn't a real, integer, string, or boolean
2) Isn't a global variable (If you use GUI, everything is global so your good)

though you do have to forcefully remove locations and player forces

 

[deathismyfriend]

You should null anything that

1) Isn't a real, integer, string, or boolean
2) Isn't a global variable (If you use GUI, everything is global so your good)

though you do have to forcefully remove locations and player forces

u forgot code. Also nulling globals does help. but its very minor

 

[caleman]

no one can confirm if vexorian auto nulls stuff?

another thing, is there something that would make maps lag that handlecounters dont detect?

 

[deathismyfriend]

sry vexorian does not auto null things.
to high of a poly count on the screen from special effect / units / anything else u can see.
To many units being spawned at once or in one spot.

 

[caleman]

so terrain deformations dont leak? im testing with the handlecounter, triggered deformations dont leak, the skills from mountain king and tauren chief dont either, (i also read that somewhere)

 

[Arhowk]

so terrain deformations dont leak? im testing with the handlecounter, triggered deformations dont leak, the skills from mountain king and tauren chief dont either, (i also read that somewhere)

war stomp, shockwave, and any variable of type terraindeformation leak.

 

[GreeN!X]

It does leak. Well, I have observe that terrain deformations cause a lot of lag especially if used too much.

 

[Nichilus]

I think there was an issue where terrain deformations cause desync (I think it was when host has different OS than user)

 

[caleman]

how hard does it leak? because 1-2 points increase in the handlecounter for everytime its used is nothing

i mean it could be used to add spells more eye candy at a very cheap cost i think the same as creating 1 single unit

Arhowk, the stun of the tauren and the aoe damage from mountain king added 0 to the handlecounter

 

[deathismyfriend]

if u trigger the special effect deformation i dont think it leaks. I may be wrong tho.

 

[Zwiebelchen]

Arhowk, the stun of the tauren and the aoe damage from mountain king added 0 to the handlecounter

Leaks caused outside the JASS level can not be caught by a handlecounter.
Terrain deformations leak in the game itself, not in the script.

 

[edo494]

I think, but am not completly sure, that Terrain Deformation can desync if for instance you start terrain deformation and when its deforming the terrain, you try to take the Z coord of the point and use it.

Thats caused, because Z coordination ignores anything that cant be seen, so it takes the height you can see with fogs on, and so the height may be different for each player

 

[caleman]

Leaks caused outside the JASS level can not be caught by a handlecounter.
Terrain deformations leak in the game itself, not in the script.

no idea what you are talking about but, how hard does 1 terrain deformation leak? should we add this thing to our spells for eye candy?

about the sync thing...ive seen terrain deformation in maps without desyncs so i dont worry about that

 

[Zwiebelchen]

no idea what you are talking about but, how hard does 1 terrain deformation leak? should we add this thing to our spells for eye candy?

You can, but should only do that for spells that are not used frequently.
Boss spells should be fine, for example.

about the sync thing...ive seen terrain deformation in maps without desyncs so i dont worry about that

It depends on wether you use z-coordinates somewhere.

 

[caleman]

alright thx, are there more things that leak and the handlecounter can not detect?

 

[PurgeandFire]

Terrain deformations have a separate handle count. Basically any handle you create will remain in memory until removed or destroyed. Some don't have destroy/remove functions (such as trackables or terrain deformations--they stay in memory for the entire map's length).

A few handles are not tracked on the regular handle stack, and therefore they won't show up on the handle count. This includes text tags, weather effects, lightning, and a few others.

All in all, just make sure you check your triggers. A lot of fps lag is just because of graphic strain (particle-intense effects, many units, etc.). It won't necessarily be because of leaks. The handle count method is a good way to check for leaks, but it won't always show you what you want, especially because of the way the handle stack behaves. Just leak-proof your triggers and you should be fine. 1000 or 2000 leaks won't make significant performance hit on your map (unless perhaps it occurs all at once, but it will be just a quick lag spike), so remember that you have leeway.