[JASS] need help with my Stun struct

[dardas]

hey, i've made a code that stuns a unit for X time,
then un-stuns it, after the amount of time stated.
it all works good, but for some reason it never unstuns.
any help is appreciated =]

library StunTarget initializer OnInit
        
        struct Stun
            private static constant string StunObjectPath = "Abilities\\Spells\\Human\\Thunderclap\\ThunderclapTarget.mdl"
            private static thistype c = 0
            private static thistype c2 = 0
            private static integer c3 = 0
            private unit caster = null
            private unit target = null
            private real duration = 0
            private real dps = 0
            private effect eff = null
                static method create takes unit caster, unit target, real duration, real dps returns Stun
                    if IsUnitPaused(target) then
                        set c = c + 1
                        set c3 = c3 + 1
                        set c.caster = caster
                        set c.target = target
                        set c.duration = duration
                        set c.dps = dps
                        call PauseUnit(c.target, true)
                        call IssueImmediateOrder(c.target, "stop")
                        call ResetUnitAnimation(c.target)
                        set c.eff = AddSpecialEffectTarget(StunObjectPath, c.target, "overhead")
                    else
                        return null
                    endif
                    return c
                endmethod
                
                method setTarget takes unit new, boolean unpauselast returns nothing
                    if unpauselast then
                        call PauseUnit(this.target, false)
                    endif
                    set this.target = new
                endmethod
                
                method setCaster takes unit new returns nothing
                    set this.caster = new
                endmethod
                
                method setDuration takes real time returns nothing
                    set this.duration = time
                endmethod
                
                method setDPS takes real damage returns nothing
                    set this.dps = damage
                endmethod
                
                static method onLoop takes nothing returns nothing
                    if c > 0 then
                        loop
                        set c2 = c2 + 1
                            if c2.duration > 0 then
                                set c2.duration = c2.duration - 0.032
                                if c2.dps != 0 then
                                    // not equal to 0, cuz it can heal aswell, while using -
                                    call UnitDamageTarget(c2.caster, c2.target, c2.dps, false, false, ATTACK_TYPE_NORMAL, DAMAGE_TYPE_NORMAL, WEAPON_TYPE_WHOKNOWS)
                                endif
                            else
                                call PauseUnit(c2.target, false)
                                set c2.dps = 0
                                set c2.duration = 0
                                set c2.caster = null
                                set c2.target = null
                                call DestroyEffect(c2.eff)
                                set c3 = c3 - 1
                                if c3 == 0 then
                                    set c = 0
                                    set c2 = 0
                                endif
                            endif
                        exitwhen c2 >= c
                        endloop
                    endif
                endmethod
        endstruct
            
    private function OnInit takes nothing returns nothing
        call TimerStart(CreateTimer(), 0.032, true, function s__Stun_onLoop)
    endfunction
endlibrary

thanks in advance

 

[baassee]

if your target alrdy is paused you pause again? Reading on my cell so hard to judge but pausing sucks as stun just to point that out

Any ways i guess the it never reach the end. Try to set a new target and see if the current one gets unpaused then that one works and you know that the loop is wrong

 

[Inferior]

All i can say is: Use this

 

[baassee]

All i can say is: Use this

Some just want a stun system and not a bunch of other stuff. Else I would say that this Link is better than UnitStatus

 

[dardas]

well, i prefer if you can fix mine..
since i really dont feel like giving credits to any 1 on this ;p
thats why it doesnt require anything but my own made stuff ^^

 

[Inferior]

Well if you don't want any other systems, first of all get rid of pausing units. Its the worst way you could choose for a stun system. Use the creepthunderbolt as a base ability (since it works on magic immunity aswell) and set its duration to 0. Then just create a timer with any duration. When the timer expired just remove the buff of that unit (normally 'BPSE')

 

[baassee]

Well if you don't want any other systems, first of all get rid of pausing units. Its the worst way you could choose for a stun system. Use the creepthunderbolt as a base ability (since it works on magic immunity aswell) and set its duration to 0. Then just create a timer with any duration. When the timer expired just remove the buff of that unit (normally 'BPSE')

Word.

 

[PurplePoot]

function s__Stun_onLoop

Don't ever do this.

 

[dardas]

hmm, so what should i do? ;/
i couldnt find a better way to do so..

 

[Inferior]

hmm, so what should i do? ;/
i couldnt find a better way to do so..

well static methods actually act like normal functions.
Use them like this: function Struct.function

The example from your code:
call TimerStart(CreateTimer(), 0.032, true, function Stun.onLoop)

As i said befor you should use a dummy spell based on the creepthunderbolt ability. set its duration at both fields (normal/hero) to 0. When you want to stun a unit order a dummy to cast that ability on a unit. Then create a timer that expires after the duration you want the stun stop. When the timer expires remove the Buff with rawcode 'BPSE' from the target. That's the whole deal.

 

[dardas]

well.. isnt there a way to add a buff to a unit? o.o

 

[Inferior]

ofc there is. But pausing is just the worst way, because it removes a units command card.
But its up to you.
well you can add buffs to units. but they won't have any effects, unless you added them with the adequate ability. To create a buff that only shows in status bar you create an ability based on the Tornado Slow Aura, set the target fields to self only, add the Buff to the ability, add the aura to a Unit and your done. The buff is shown but doesn't have any effect. If you want to remove the buff simply remove the aura ability.

 

[baassee]

and if you base it on the slow aura, make sure you make the ability permanent as a morph will remove the buff, just make it not permanent before you remove the ability

 

[Inferior]

and if you base it on the slow aura, make sure you make the ability permanent as a morph will remove the buff, just make it not permanent before you remove the ability

Good you mention it

 

[Ceday]

Why not just stun him?

 

[dardas]

what? o.o

 

[Inferior]

you still haven't got me?

 

[dardas]

well, i got you.. not him..
"Why not just stun him?"
what did you mean by that?..

 

[baassee]

he probably didnt get this ...

 

[Ceday]

Why not just use a dummy unit and cast storm bolt instead of working with pause,effect,damage,lines of code...

 

[baassee]

because then you can't make it fit for all durations, although the solution is to stun with a duration that is infinite and remove it afterwards. So you are part right though not stormbolt.

 

[dardas]

well.. thats what they told me 1 page ago..
1. cast the spell with a dummy
2. make it run a timer as i did now
3. each timer interval damage the unit dealing the damage.
4. when timer ends, remove buff.

 

[baassee]

i know i commented too at the first page

 

[Inferior]

Damned he got us xD