[Trigger] Need help--- Delete Last created units

[AbTSs]

how i can delete last created units?
here triggers :

• first
  • Events
    • Unit - A unit Begins casting an ability
  • Conditions
    • (Ability being cast) Equal to Death Coil
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
      • Then - Actions
        • Set tmn_place = (Target unit of ability being cast)
      • Else - Actions
    • Unit - Create 5 Serpent Ward (Level 1) for (Owner of (Triggering unit)) at (Position of tmn_place) facing Default building facing degrees
    • Wait 5.00 seconds

 

[Bannar]

Your trigger leaks location. If/then/else if not needed. Replace (Owner of (Triggering unit)) with (Triggering player) and 'Begins casting an ability' with 'Starts effect of ability'. tmn_place unit variable is completely useless. Adding expiration timer to last created unit can help you archieve the 5sec delay before killing unit.

Fixed trigger:

• first
  • Events
    • Unit - A unit Starts effect of ability
  • Conditions
    • (Ability being cast) Equal to Death Coil
  • Actions
    • Set point = (Position of (Target unit of ability being cast))
    • Unit - Create 5 Serpent Ward (Level 1) for (Triggering player) at point facing Default building facing degrees
    • Unit - Add 5.00 second exipiration timer to (Last created unit)
    • Custom script: call RemoveLocation(udg_point)

 

[AbTSs]

have problem World editor Gives me an Erorr with this

• first
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Death Coil
  • Actions
    • Set Point = (Position of (Target unit of ability being cast))
    • Unit - Create 5 Serpent Ward (Level 1) for (Triggering player) at Point facing Default building facing degrees
    • Unit - Add a 5.00 second Generic expiration timer to (Last created unit)
    • Custom script: call RemoveLocation(udg_point)

Custom Script has problem?

 

[Bannar]

Your variable is named 'Point' not 'point' and jass is key sensitive. In your example you should write:

• Custom script: call RemoveLocation(udg_Point)

 

[AbTSs]

PRoblem agian
it does not remove all 5 wards it remove 1 of them

 

[claptomanic]

because you create 5 and just the last one has the timer...

loop it and your problem is done.

 

[AbTSs]

can u give me triggers?

 

[Bannar]

You should have told me ealier that such issue occured. I haven't noticed that you are creating 5 units at once.

• first
  • Events
    • Unit - A unit Starts effect of ability
  • Conditions
    • (Ability being cast) Equal to Death Coil
  • Actions
    • Set point = (Position of (Target unit of ability being cast))
    • For each (Integer i) from 1 to 5 do Actions
      • Loop - Actions
        • Unit - Create 1 Serpent Ward (Level 1) for (Triggering player) at point facing Default building facing degrees
        • Unit - Add 5.00 second exipiration timer to (Last created unit)
    • Custom script: call RemoveLocation(udg_point)

Where 'i' is global integer non array variable.

 

[Bribe]

(Position of (Target unit of ability being cast)) -> (Target point of ability being cast)

Keep it simple.

 

[Pharaoh_]

(Position of (Target unit of ability being cast)) -> (Target point of ability being cast)

Keep it simple.

Since when "Target point of ability being cast" equals to "Position of Target unit of ability being cast"?

 

[Bribe]

I don't know since when, but it's always worked for me. I kind of came into the war3 modding scene after the dark ages of the return bug, so I missed out on a lot of weird.

 

[Pharaoh_]

So, GetSpellTargetX() == GetUnitX (GetSpellTargetUnit())?

 

[Bribe]

That's how it's been for me, has it been different for you? Maybe it just works
with some spells then?

 

[Pharaoh_]

Spells that can target both units and points could possible trigger this equality, e.g. Shockwave or Carrion Swarm, but I have never tested it.

 

[Bribe]

I'll test this with a few spells when I'm home but I've never seen it return null for a spell as long as it's a spell effect event and not a "no target" spell.