[JASS] My first vJass spell

[Linaze]

O hai, I just finished my first vJass spell, and I just wanna know if iamdoinitrite.
Yah, it's a simple spell, but it's just for training, obviously.

scope Fire initializer Init
    globals
        private constant integer SPELL_ID = 'A000'
        private constant real DAMAGE = 50
        private constant damagetype D_TYPE = DAMAGE_TYPE_NORMAL
        private constant attacktype A_TYPE = ATTACK_TYPE_MAGIC
    endglobals

    private function Conditions takes nothing returns boolean
        return GetSpellAbilityId() == SPELL_ID
    endfunction

    private function Actions takes nothing returns nothing
        local unit caster = GetTriggerUnit()
        local unit target = GetSpellTargetUnit()
        call UnitDamageTarget(caster,target,DAMAGE,true,false,A_TYPE,D_TYPE,null)
        set caster = null
        set target = null
    endfunction
 
    private function Init takes nothing returns nothing
        local trigger Trg = CreateTrigger()
        call TriggerAddAction(Trg, function Actions)
        call TriggerAddCondition(Trg, Condition(function Conditions))
        call TriggerRegisterAnyUnitEventBJ(Trg,EVENT_PLAYER_UNIT_SPELL_EFFECT)
    endfunction
endscope

Thanks.

 

[Starquizer]

No errors. But for leaks I don't know; I havent learn how to clean them yet.

 

[aznricepuff]

Looks good to me. The only thing is you don't need to save the trigger to a global. You can just use a local variable in the Init function.

 

[Linaze]

private function Init takes nothing returns nothing
        local trigger Trg = CreateTrigger()
        call TriggerAddAction(Trg, function Actions)
        call TriggerAddCondition(Trg, Condition(function Conditions))
        call TriggerRegisterAnyUnitEventBJ(Trg,EVENT_PLAYER_UNIT_SPELL_EFFECT)
endfunction

Like so?

 

[Starquizer]

Looks good to me. The only thing is you don't need to save the trigger to a global. You can just use a local variable in the Init function.

I thought of that as well but not 100 % sure, that why I didn't tell him that.

 

[aznricepuff]

Yea, exactly.

 

[Linaze]

Thanks a lot, then.
Trying to improve this simple code bit by bit.

 

[Cokemonkey11]

Looks good, only part that weirds me out is that you reference the actions before the conditions or the event, but that's just me.

It looks good though.

 

[Ciebron]

private function Init takes nothing returns nothing
        local trigger Trg = CreateTrigger()
        call TriggerAddAction(Trg, function Actions)
        call TriggerAddCondition(Trg, Condition(function Conditions))
        call TriggerRegisterAnyUnitEventBJ(Trg,EVENT_PLAYER_UNIT_SPELL_EFFECT)
        set Trg = null
endfunction

like this

 

[aznricepuff]

nulling does nothing. The trigger will never be destroyed.

 

[Dreadnought[dA]]

or you just leave it's standard global variable that way you can call it in code later if you want to turn it off.

 

[Linaze]

Why would I want to turn off a spell trigger, though?

 

[Cokemonkey11]

You could also add events to it that way (if you're doing some sort of DD)