Movespeed trigger

[tml616]

• Movespeed
  • Events
    • Player - Player 1 (Red) types a chat message containing -ms as An exact match
    • Player - Player 2 (Blue) types a chat message containing -ms as An exact match
    • Player - Player 3 (Teal) types a chat message containing -ms as An exact match
    • Player - Player 4 (Purple) types a chat message containing -ms as An exact match
    • Player - Player 5 (Yellow) types a chat message containing -ms as An exact match
    • Player - Player 6 (Orange) types a chat message containing -ms as An exact match
    • Player - Player 7 (Green) types a chat message containing -ms as An exact match
    • Player - Player 8 (Pink) types a chat message containing -ms as An exact match
    • Player - Player 9 (Gray) types a chat message containing -ms as An exact match
    • Player - Player 10 (Light Blue) types a chat message containing -ms as An exact match
  • Conditions
  • Actions
    • Unit Group - Add all units of (Units currently selected by (Triggering player)) to movespeed_group
    • For each (Integer A) from 1 to (Number of units in movespeed_group), do (Actions)
      • Loop - Actions
        • Set movespeed_unit = (Random unit from movespeed_group)
        • Game - Display to (All players matching ((Matching player) Equal to (Triggering player))) the text: (Current movespeed of + ((Name of movespeed_unit) + (: + (String((Integer((Current movement speed of movespeed_unit))))))))
        • Unit Group - Remove movespeed_unit from movespeed_group
        • Custom script: set udg_movespeed_unit = null
    • Unit Group - Remove all units of movespeed_group from movespeed_group

I got this trigger to do what I want in-game, just need you to tell me if it's clean and will it leak?


Here is a picture of what it does:

 

[TriggerHappy]

I don't have the world editor with me right now but I beleive you need to store (and remove)

Units currently selected by (Triggering player)

Esle you will leak a group. And by the way this won't be able to set a units movements speed past 522.

 

[reason 3]

Can you upload the demo map plz?

 

[tml616]

Attached map.

If you want to comment on the trigger that adds spellpower from INT that would be cool too. I know I should use custom script for spells but I'm still learning it and making it all in GUI first helps me.

Also does anyone know where I can find the code for Phantom Assassin(DotA)'s Stifling Dagger spell, or any projectile spell that doesn't stun but has a travel time?

 

[Marcelo Hossomi]

1. You don't need to null global variables (they'll be set to something anyways)
2. You have to destroy global handles such as groups with DestroyGroup( udg_yourGroup ) after you're done with it.

 

[TriggerHappy]

1. The new patch created a new leak apparently, and globals to need to be nulled. But it's very minor.
2. You do if the value will be different.

 

[tml616]

1. You don't need to null global variables (they'll be set to something anyways)
2. You have to destroy global handles such as groups with DestroyGroup( udg_yourGroup ) after you're done with it.

global handles are just the variables assigned by the game like Triggering Player, Triggering Unit, Units Selected, etc?

 

[Marcelo Hossomi]

1. The new patch created a new leak apparently, and globals to need to be nulled. But it's very minor.

Really? That's new for me...

2. You do if the value will be different.

Oh sorry, that's true x.x
Thanks xD

 

[Diehard@Azeroth]

before doing the selected group thing, do custom script:"set bj_wantDestroyGroup = true" without the quotes though. itll destroy the group after its been created and its actions with it are done.

 

[reason 3]

before doing the selected group thing, do custom script:"set bj_wantDestroyGroup = true" without the quotes though. itll destroy the group after its been created and its actions with it are done.

This is such a small leak...about 4-6 bytes.

 

[Marcelo Hossomi]

The problem comes up when people type -ms a lot of times during the whole game...