Mouse Movement System v1.2a

[Marcos_M]

This would allow you to move your Hero even when you don't have it selected, i never thought of that

 

[MyPad]

A little bit of heads up,

How about the other 12 players?

In unit-move, you can remove the condition that both coordinates must not be zero since you only need the flag variable in order to move them.

 

[Elprede]

• Untitled Trigger 001
  • Events
  • Conditions
  • Actions
    • For each (Integer A) from 1 to 24, do (Actions)
      • Loop - Actions
        • Trigger - Add to (This trigger) the event (Player - (Player((Integer A))) issues Mouse Down event)
        • Trigger - Add to (This trigger) the event (Player - (Player((Integer A))) issues Mouse Up event)
        • Trigger - Add to (This trigger) the event (Player - (Player((Integer A))) issues Mouse Move event)

• Player Group - Pick every player in (All players) and do (Actions)
  • Loop - Actions
    • Trigger - Add to (This trigger) the event (Player - (Picked player) issues Mouse Down event)
    • Trigger - Add to (This trigger) the event (Player - (Picked player) issues Mouse Up event)
    • Trigger - Add to (This trigger) the event (Player - (Picked player) issues Mouse Move event)

 

[MyPad]

I was thinking of something like that, only utilizing the native native GetTriggerEventId takes nothing returns eventid if it has a GUI equivalent.

On the specified triggers (Mouse Click, Detect and Release), remove the already included events and replace them with map initialization. Upon Map Initialization (this is where GetTriggerEventId() comes in, a condition), do a loop from Player 1 to 24, which will include those events anyway.

 

[xorkatoss]

This would allow you to move your Hero even when you don't have it selected, i never thought of that

yeah it can definitely be helpful in hero arenas, you could theoretically move your hero and keep selected a dummy unit with 12 different abilities for example

A little bit of heads up,

How about the other 12 players?

In unit-move, you can remove the condition that both coordinates must not be zero since you only need the flag variable in order to move them.

Adding more players it's not hard actually all you have to do is register the units and increase the loop to 24 players.

I'm not sure I understand what you said about flag variable...although the X & Y mouse detection is essential because if you read the trigger comment in "unit move" I said:
"If MouseX is 0.00 and MouseY is 0.0 then it means the mouse is on the User Interface."
if you order the unit to move while player mouse is on the UI it automatically orders it to move in center of the map so I had to use X & Y detection to avoid that hassle.

Spoiler: Triggers

• Untitled Trigger 001
  • Events
  • Conditions
  • Actions
    • For each (Integer A) from 1 to 24, do (Actions)
      • Loop - Actions
        • Trigger - Add to (This trigger) the event (Player - (Player((Integer A))) issues Mouse Down event)
        • Trigger - Add to (This trigger) the event (Player - (Player((Integer A))) issues Mouse Up event)
        • Trigger - Add to (This trigger) the event (Player - (Player((Integer A))) issues Mouse Move event)

• Player Group - Pick every player in (All players) and do (Actions)
  • Loop - Actions
    • Trigger - Add to (This trigger) the event (Player - (Picked player) issues Mouse Down event)
    • Trigger - Add to (This trigger) the event (Player - (Picked player) issues Mouse Up event)
    • Trigger - Add to (This trigger) the event (Player - (Picked player) issues Mouse Move event)

Yes I know I could have used that but I thought it might bring map lag when you enter game in huge maps with a lot of setup triggers that loop actions.

Perhaps I could include it in a separate trigger and have it disabled.

 

[MyPad]

^^ @xorkatoss

The flag variable is the Mouse Click Boolean variable. Also, if done on map initialization, the worrisome lag wouldn't really matter.

 

[apsyll]

I got also inspired by the new mouse natives and come up with this system after seeing yours I think this could get some inspiration.

Spoiler: Trigger

Spoiler: Input Initialization

• Input Initialization
  • Events
    • Time - Elapsed game time is 0.30 seconds
  • Conditions
  • Actions
    • -------- the maximum amount of time that can pass before it's not counted as double ckilck anymore --------
    • Set Input_DCFrequenceTime = 0.20
    • For each (Integer Input_Index) from 1 to Game_MaxPlayer, do (Actions)
      • Loop - Actions
        • Trigger - Add to Input MouseDown <gen> the event (Player - (Player(Input_Index)) issues Mouse Down event)
        • Trigger - Add to Input MouseUp <gen> the event (Player - (Player(Input_Index)) issues Mouse Up event)
        • Trigger - Add to Input MouseMove <gen> the event (Player - (Player(Input_Index)) issues Mouse Move event)
        • Set Input_IsLeftClicked[Input_Index] = False
        • Set Input_IsMiddleClicked[Input_Index] = False
        • Set Input_IsRightClicked[Input_Index] = False
        • Trigger - Add to Input RestetDoubleClick <gen> the event (Time - Input_DCTimerLeft[Input_Index] expires)
        • Set Input_IsDoubleClickingL[Input_Index] = False
        • Trigger - Add to Input RestetDoubleClick <gen> the event (Time - Input_DCTimerMiddle[Input_Index] expires)
        • Set Input_IsDoubleClickingM[Input_Index] = False
        • Trigger - Add to Input RestetDoubleClick <gen> the event (Time - Input_DCTimerRight[Input_Index] expires)
        • Set Input_IsDoubleClickingR[Input_Index] = False

Spoiler: Input MouseUp

• Input MouseUp
  • Events
  • Conditions
  • Actions
    • Set Input_PlayerID = (Player number of (Triggering player))
    • Set Input_MousePoint[Input_PlayerID] = (Mouse Position for Triggered Mouse Event)
    • Set Input_MouseX[Input_PlayerID] = (Mouse Position X for Triggered Mouse Event)
    • Set Input_MouseY[Input_PlayerID] = (Mouse Position Y for Triggered Mouse Event)
    • -------- Left --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Trigger Mouse Button) Equal to Left Mouse Button
      • Then - Actions
        • -------- Left Up --------
        • Set Input_IsLeftClicked[Input_PlayerID] = False
        • -------- Start timer to check for double click --------
        • Set Input_IsDoubleClickingL[Input_PlayerID] = True
        • Countdown Timer - Start Input_DCTimerLeft[Input_PlayerID] as a One-shot timer that will expire in Input_DCFrequenceTime seconds
      • Else - Actions
    • -------- Right --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Trigger Mouse Button) Equal to Right Mouse Button
      • Then - Actions
        • -------- Right Up --------
        • Set Input_IsRightClicked[Input_PlayerID] = False
        • -------- Start timer to check for double click --------
        • Set Input_IsDoubleClickingR[Input_PlayerID] = True
        • Countdown Timer - Start Input_DCTimerRight[Input_PlayerID] as a One-shot timer that will expire in Input_DCFrequenceTime seconds
      • Else - Actions
    • -------- Middle --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Trigger Mouse Button) Equal to Middle Mouse Button
      • Then - Actions
        • -------- Middle Up --------
        • Set Input_IsMiddleClicked[Input_PlayerID] = False
        • -------- Start timer to check for double click --------
        • Set Input_IsDoubleClickingM[Input_PlayerID] = True
        • Countdown Timer - Start Input_DCTimerMiddle[Input_PlayerID] as a One-shot timer that will expire in Input_DCFrequenceTime seconds
      • Else - Actions

Spoiler: Input MouseDown

• Input MouseDown
  • Events
  • Conditions
  • Actions
    • Set Input_PlayerID = (Player number of (Triggering player))
    • Set Input_MousePoint[Input_PlayerID] = (Mouse Position for Triggered Mouse Event)
    • Set Input_MouseX[Input_PlayerID] = (Mouse Position X for Triggered Mouse Event)
    • Set Input_MouseY[Input_PlayerID] = (Mouse Position Y for Triggered Mouse Event)
    • -------- Left --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Trigger Mouse Button) Equal to Left Mouse Button
        • Input_MouseX[Input_PlayerID] Not equal to 0.00
        • Input_MouseY[Input_PlayerID] Not equal to 0.00
      • Then - Actions
        • -------- Left down --------
        • Set Input_IsLeftClicked[Input_PlayerID] = True
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Input_IsDoubleClickingL[Input_PlayerID] Equal to True
          • Then - Actions
            • -------- Left double click --------
          • Else - Actions
      • Else - Actions
    • -------- Right --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Trigger Mouse Button) Equal to Right Mouse Button
        • Input_MouseX[Input_PlayerID] Not equal to 0.00
        • Input_MouseY[Input_PlayerID] Not equal to 0.00
      • Then - Actions
        • -------- Right down --------
        • Set Input_IsRightClicked[Input_PlayerID] = True
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Input_IsDoubleClickingR[Input_PlayerID] Equal to True
          • Then - Actions
            • -------- Right double click --------
          • Else - Actions
      • Else - Actions
    • -------- Middle --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Trigger Mouse Button) Equal to Middle Mouse Button
        • Input_MouseX[Input_PlayerID] Not equal to 0.00
        • Input_MouseY[Input_PlayerID] Not equal to 0.00
      • Then - Actions
        • -------- Middle down --------
        • Set Input_IsMiddleClicked[Input_PlayerID] = True
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Input_IsDoubleClickingM[Input_PlayerID] Equal to True
          • Then - Actions
            • -------- Middle double click --------
          • Else - Actions
      • Else - Actions

Spoiler: Input MouseMove

• Input MouseMove
  • Events
  • Conditions
  • Actions
    • Set Input_PlayerID = (Player number of (Triggering player))
    • Set Input_MousePoint[Input_PlayerID] = (Mouse Position for Triggered Mouse Event)
    • Set Input_MouseX[Input_PlayerID] = (Mouse Position X for Triggered Mouse Event)
    • Set Input_MouseY[Input_PlayerID] = (Mouse Position Y for Triggered Mouse Event)
    • -------- Left --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Input_IsLeftClicked[Input_PlayerID] Equal to True
      • Then - Actions
        • -------- Left click drag --------
      • Else - Actions
    • -------- Right --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Input_IsRightClicked[Input_PlayerID] Equal to True
      • Then - Actions
        • -------- Right click drag --------
      • Else - Actions
    • -------- Middle --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Input_IsMiddleClicked[Input_PlayerID] Equal to True
      • Then - Actions
        • -------- Middle click drag --------
      • Else - Actions

Spoiler: Input RestetDoubleClick

• Input RestetDoubleClick
  • Events
  • Conditions
  • Actions
    • For each (Integer Input_DCIndex) from 1 to Game_MaxPlayer, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Remaining time for Input_DCTimerLeft[Input_DCIndex]) Less than or equal to 0.00
            • Input_IsDoubleClickingL[Input_DCIndex] Equal to True
          • Then - Actions
            • Set Input_IsDoubleClickingL[Input_DCIndex] = False
          • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Remaining time for Input_DCTimerMiddle[Input_DCIndex]) Less than or equal to 0.00
            • Input_IsDoubleClickingM[Input_DCIndex] Equal to True
          • Then - Actions
            • Set Input_IsDoubleClickingM[Input_DCIndex] = False
          • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Remaining time for Input_DCTimerRight[Input_DCIndex]) Less than or equal to 0.00
            • Input_IsDoubleClickingR[Input_DCIndex] Equal to True
          • Then - Actions
            • Set Input_IsDoubleClickingR[Input_DCIndex] = False
          • Else - Actions

 

[IcemanBo]

As logics is anyways not too much, focus could be on providing easy usage, not caring for checks/loops himself. If you want you can take attached code, it's also jass-user friendly.

Hidden

// Threshold timeout to fire event for one player
constant function MouseMovement_Timeout takes nothing returns real
    return 0.2
endfunction

function MouseMovement_onClick takes nothing returns nothing
    if (BlzGetTriggerPlayerMouseButton() == MOUSE_BUTTON_TYPE_RIGHT) then
        set udg_MMS_IsClicked[GetPlayerId(GetTriggerPlayer())] = true
    endif
endfunction

function MouseMovement_onRelease takes nothing returns nothing
    if (BlzGetTriggerPlayerMouseButton() == MOUSE_BUTTON_TYPE_RIGHT) then
        set udg_MMS_IsClicked[GetPlayerId(GetTriggerPlayer())] = false
    endif
endfunction

function MouseMovement_onMove takes nothing returns nothing
    local integer playerId = GetPlayerId(GetTriggerPlayer())
    if (udg_MMS_IsClicked[playerId] and TimerGetRemaining(udg_MMS_Timer[playerId]) == 0 ) then
        if MouseMovement_Timeout() > 0 then
            call TimerStart(udg_MMS_Timer[playerId], MouseMovement_Timeout(), false, null)
        endif
        set udg_MMS_X = BlzGetTriggerPlayerMouseX()
        set udg_MMS_Y = BlzGetTriggerPlayerMouseY()
        set udg_MMS_Location = Location(udg_MMS_X, udg_MMS_Y)
        set udg_MMS_Player = GetTriggerPlayer()
        set udg_MMS_Event = 1
        set udg_MMS_Event = 0
        call RemoveLocation(udg_MMS_Location)
    endif
endfunction

function MouseMovement_MouseRegister takes trigger t, integer ev returns nothing
    local integer i = 0
    loop
        exitwhen i > 24
        call TriggerRegisterPlayerMouseEventBJ(t, Player(i), ev)
        set i = i + 1
    endloop
endfunction

function InitTrig_MouseMovement takes nothing returns nothing
    local trigger t
    local integer i
 
    set t = CreateTrigger()
    call TriggerAddAction(t, function MouseMovement_onClick)
    call MouseMovement_MouseRegister(t, bj_MOUSEEVENTTYPE_DOWN)
 
    set t = CreateTrigger()
    call TriggerAddAction(t, function MouseMovement_onRelease)
    call MouseMovement_MouseRegister(t, bj_MOUSEEVENTTYPE_UP)
 
    set t = CreateTrigger()
    call TriggerAddAction(t, function MouseMovement_onMove)
    call MouseMovement_MouseRegister(t, bj_MOUSEEVENTTYPE_MOVE)
 
    set i = 0
    loop
        exitwhen i > 24
        set udg_MMS_Timer[i] = CreateTimer()
        set i = i + 1
    endloop
endfunction

edit:

It would be even cooler if the timer callback would fire the event, too, so the last event is never ignored. The X/Y would have to be updated for this each run, not only when threshold allows.

 

[knight26]

I wonder if there's a way to implement this system into the game instead of a single map?
Could it be done? There's a number of maps where this would be very useful indeed.

 

[Tasyen]

I wonder if there's a way to implement this system into the game instead of a single map?
Could it be done? There's a number of maps where this would be very useful indeed.

It is possible to overwrite/overlap "blizzard.j", with a custom "blizzard.j" in which you added aditional code.
"blizzard.j" is used by most maps.

Problem Multiplayer:
Players using a custom "blizzard.j" would desync from players not using the same custom "blizzard.j".
I am also not sure, if "Battle.net" would let you play at all or that would even count as hacking.
Although It works in Single Player.
Edit: I Tested it now in Lan with 2 computers (V1.30.1.10211) , Having different content in "Blizzard.j" as game lobby owner (host) leads to an autokick.

 

[Dr Super Good]

Required for Approval:

There are potentially more than just 12 human players. I suggest running a loop at map initialization which adds the mouse events to the triggers. This loop should pick players from all players for maximum future proofing. The players should be filtered for active human players since creating the events for inactive slots or for computer players is pointless.
​

Comments and Suggestions:

Due to the simplicity it is potentially useful as a starting step for mouse based movement systems similar to those in the Diablo series. Additionally there are a lot of nice comments in the resource thread with alternative implementations, extensions and suggestions that people may find useful.

Why is position (0, 0) not accepted as a valid cursor destination? A comment in the map explaining why might be useful.

The periodic unit movement trigger should only issue a move order if the player has changed the position of their cursor since the last time the trigger ran. This would potentially help reduce animation issues as well as path finder load in some cases.​

 

[Dr Super Good]

Still does not check if the player is active. This is a player slot status comparison test.

 

[xorkatoss]

@Dr Super Good
you mean use this?

• ((Player(Mouse_i)) slot status) Equal to Is playing

instead of the current:

• ((Player(Mouse_i)) controller) Equal to User

??

or should both be used to detect if human and active?

 

[Dr Super Good]

or should both be used to detect if human and active?

Both should be used. That way it will not create events for players who drop during the load screen.

 

[xorkatoss]

@Dr Super Good alright thanks! changed made.

 

[Dr Super Good]

Comments and Suggestions:

Due to the simplicity it is potentially useful as a starting step for mouse based movement systems similar to those in the Diablo series. Additionally there are a lot of nice comments in the resource thread with alternative implementations, extensions and suggestions that people may find useful.

Why is position (0, 0) not accepted as a valid cursor destination? A comment in the map explaining why might be useful.

The periodic unit movement trigger should only issue a move order if the player has changed the position of their cursor since the last time the trigger ran. This would potentially help reduce animation issues as well as path finder load in some cases.​

 

[Pyrogasm]

Why is position (0, 0) not accepted as a valid cursor destination? A comment in the map explaining why might be useful.

This is what's returned when querying mouse position while the mouse is over the UI.

 

[xorkatoss]

@Dr Super Good @Pyrogasm
But I already mentioned that in the Trigger Comment of the trigger "Mouse UnitMove"
That comment was already there from the first time I uploaded the system.

Spoiler: Image

Reviewers don't open maps to properly test them?

 

[Dr Super Good]

Comments and Suggestions:

Due to the simplicity it is potentially useful as a starting step for mouse based movement systems similar to those in the Diablo series. Additionally there are a lot of nice comments in the resource thread with alternative implementations, extensions and suggestions that people may find useful.

The periodic unit movement trigger should only issue a move order if the player has changed the position of their cursor since the last time the trigger ran. This would potentially help reduce animation issues as well as path finder load in some cases.​

 

[Dr Super Good]

That comment was already there from the first time I uploaded the system.

Ops did not notice the GUI comment. Too used to script style comments where the comments are part of the script rather than in a separate panel. I must have forgotten to look up.

Do note that the multi posts are a result of how moderation works. The moderator comment can only be updated by making a new post.

 

[JC Helas]

Missing file,, can't open wew

 

[Dr Super Good]

Download seems to work for me.

 

[Schmiki]

awesome, just what I was looking for. Thank you