Monkey King Spell Pack

[Pyrogasm]

NOTE: This ability can be buggy and i would advise only using it for not user controlled units

Could you be more specific? Perhaps there is a solution.

 

[Oliphant]

Could you be more specific? Perhaps there is a solution.

I done this ability by creating two abilities based on chaos and created one unit that is exactly same as Monkey King. And then add one chaos ability that changes unit into they morphed or unmorphed version and remove second ability. Only bug that i found is that unit will have day vision during night. But since it is pretty hacky way to do that, i suspect there are some others bugs that could occure in some weird scenario, I left this ability in pack just because it shouldn't cause problems if used for boss unit for example. Also there is probably no other way around to change model of unit via trigger.

 

[Pyrogasm]

Instead of chaos, this has no downsides: Hero passive transformation

 

[Bribe]

Instead of chaos, this has no downsides: Hero passive transformation

I think Hero Passive Transformation is somewhat-dated, since now you can set a unit's skin/attack point/damage point.

 

[Lambdadelta]

Nit: Spell names. His first ability from the source material is "Boundless Strike", rather than "Boundle Strike". His "Misschief" has a typo, should be "Mischief".

 

[Oliphant]

I think Hero Passive Transformation is somewhat-dated, since now you can set a unit's skin/attack point/damage point.

Using skin/s solved problem, I thought that skins in warcraft are the same as in other games, where you buy hats and then you have cowboy hat on paladin model, but they replace unit with diffrent unit, while keeping stats and abilities. And luckily have gui method for changing skin when you just have to input "string" integer, but you cant, making it pretty much worthless in a sense(since you can save "string" integer using Jass and then pass is it).

 

[Pyrogasm]

added new bugs

Lmao.

 

[MyPad]

Neat. If I recall, Monkey King was the first Dota 2 exclusive Hero to be introduced. It would be poetic justice to see that it is one of the first Dota 2 exclusive Heroes to be properly (re)introduced back into Warcraft 3. Anyway, here's the code/trigger review:

Spoiler: Code Review

• In the trigger BoundleStrike (Boundle):
  • BoundleAngle appears to be causing a memory leak by referring to an unstored generated location handle in (Position of BoundleStrikeUnit). You could fix that by making it refer to BoundleStartingPosition, moving the initialization of BoundleStartingPosition before it.
    
    
  • In the same vein, BoundleEndingPoint should refer to BoundleStartingPosition.
    
    
  • • For each (Integer A) from 1 to 3 , do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (X of BoundleCorners[(Integer A)]) Greater than BoundleMaxX
          • Then - Actions
            • Set Variable Set BoundleMaxX = (X of BoundleCorners[(Integer A)])
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (X of BoundleCorners[(Integer A)]) Less than BoundleMinX
              • Then - Actions
                • Set Variable Set BoundleMinX = (X of BoundleCorners[(Integer A)])
              • Else - Actions
    From the looks of things, there's no need to nest the conditions within the else block. Just move the inner if-then block out of the outer if-then-else block.
    
    
  • • -------- Picking Unit Affecte by Boundle --------
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in (Region(BoundleMinX, BoundleMinY, BoundleMaxX, BoundleMaxY)) matching ((((Matching unit) belongs to an enemy of (Owner of BoundleStrikeUnit).) Equal to True) and ((((Matching unit) is A flying unit) Equal to False) and ((((Matching unit) is Magic Immune) Equal to False) and (((Matching unit) is Mechanical) Equal to False))))) and do (Actions)
      • Loop - Actions
        • -------- Finding point of center of unit in rotated env --------
        • Set Variable Set RotatedPositionOfUnit = ((Point(BoundleCenterX, BoundleCenterY)) offset by (Distance between (Position of (Picked unit)) and (Point(BoundleCenterX, BoundleCenterY))) towards ((Angle from (Position of (Picked unit)) to (Point(BoundleCenterX, BoundleCenterY))) - (BoundleAngle - 90.00)) degrees.)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • And - All (Conditions) are true
              • Conditions
                • (X of RotatedPositionOfUnit) Less than or equal to (X of BotRightCornerInRotatedBoundle)
                • (X of RotatedPositionOfUnit) Greater than or equal to (X of BotLeftCornerInRotatedBoundle)
                • (Y of RotatedPositionOfUnit) Greater than or equal to (Y of BotLeftCornerInRotatedBoundle)
                • (Y of RotatedPositionOfUnit) Less than or equal to (Y of TopLeftCornerInRotatedBoundle)
          • Then - Actions
            • Unit Group - Add (Picked unit) to UnitsAffectedByBoundle
            • -------- Continue would be nice there istead of else if to have less indentation --------
          • Else - Actions
            • -------- Finding closest Y to rotated position of unit --------
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Y of RotatedPositionOfUnit) Greater than (Y of TopLeftCornerInRotatedBoundle)
              • Then - Actions
                • Set Variable Set ClosestYToRotatedPoint = (Y of TopLeftCornerInRotatedBoundle)
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Y of RotatedPositionOfUnit) Less than (Y of BotLeftCornerInRotatedBoundle)
                  • Then - Actions
                    • Set Variable Set ClosestXToRotatedPoint = (X of BotRightCornerInRotatedBoundle)
                    • Set Variable Set ClosestYToRotatedPoint = (Y of BotLeftCornerInRotatedBoundle)
                  • Else - Actions
                    • Set Variable Set ClosestYToRotatedPoint = (Y of RotatedPositionOfUnit)
            • -------- Finding closest X to rotated position of unit --------
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (X of RotatedPositionOfUnit) Less than (X of BotLeftCornerInRotatedBoundle)
              • Then - Actions
                • Set Variable Set ClosestXToRotatedPoint = (X of BotLeftCornerInRotatedBoundle)
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (X of RotatedPositionOfUnit) Greater than (X of BotRightCornerInRotatedBoundle)
                  • Then - Actions
                    • Set Variable Set ClosestXToRotatedPoint = (X of BotRightCornerInRotatedBoundle)
                  • Else - Actions
                    • Set Variable Set ClosestXToRotatedPoint = (X of RotatedPositionOfUnit)
            • Set Variable Set BoundleDistanceToEdge = (Square root(((Power((Abs(((X of RotatedPositionOfUnit) - ClosestXToRotatedPoint))), 2.00)) + (Power((Abs(((Y of RotatedPositionOfUnit) - ClosestYToRotatedPoint))), 2.00)))))
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Collision Size of (Picked unit)) Greater than or equal to BoundleDistanceToEdge
              • Then - Actions
                • Unit Group - Add (Picked unit) to UnitsAffectedByBoundle
              • Else - Actions
    1.) It looks like a JASS rect (GUI region) handle is being created without being referenced and subsequently cleaned up. You can clean this up using the following function: native RemoveRect takes rect whichRect returns nothing.
    
    2.) The inner filter function in the nested matching condition statement can look quite ugly really fast with a lot of conditions. Try filtering them out within the Actions block instead. Check out this tutorial for more info: Convenient Unit Group Filtering in GUI
    
    3.) The liberal use of (Position of (Picked unit)) translates to more memory leaks.
    
    4.) You can use Skip Remaining Actions in the Then - Actions block on the first If-then-else block as a quasi-continue statement, since the function (Pick all units in n group) generates a new thread for each picked unit. (Memory leaks that have been created before that point will have to be cleaned up, though).
    
    5.) (Picked unit) is called an awful lot within this block. Perhaps you might want to store that in a temp variable?
    
    
  • The floating text should only show the integer value of the amount of damage dealt, not the real value. (250 instead of 250.16, for example).
    
    
• In the trigger Jingu Lifesteal:
  • You can directly call FlushChildHashtable instead of the wrapper.
    • API difference between the two functions:
      

      native FlushChildHashtable takes hashtable whichHashtable, integer parentKey
      function FlushChildHashtableBJ takes integer parentKey, hashtable whichHashtable

      
      
• In the trigger Jingu Check for Buff:
  • Don't be shy with the interval period. Even when not enabled and disabled properly, this trigger should not be too costly. I'd recommend a 0.50 second interval.
    
    
• In the trigger ArenaCreate:
  • The (A unit starts the effect of an ability) event would be more suitable here.
    
    
• In the trigger Arena Damage (may also apply in ArenaSoldiersV2):
  • (Position of MonkeyArena) and (Position of MonkeyArenaCreator) is not stored.
    
    
  • • Set Variable Set MonkeyArenaToDamageLeft = ((Load 2 of (Key (Picked unit).) from MonkeyArenaHastable.) - 0.04)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • MonkeyArenaToDamageLeft Less than or equal to 0.00
      • Then - Actions
        • Set Variable Set MonkeyArenaToDamageLeft = MonkeyArenaDamageInterval
        • Custom script: set bj_wantDestroyGroup = true
        • Unit Group - Pick every unit in (Units within MonkeyArenaSize of (Position of MonkeyArena) matching (((Matching unit) belongs to an ally of (Owner of MonkeyArenaCreator).) Equal to False).) and do (Actions)
          • Loop - Actions
            • Unit - Cause MonkeyArenaCreator to damage (Picked unit) , dealing ((Real((Base Damage of MonkeyArenaCreator for weapon index 1))) x MonkeyArenaDamageMult) damage of attack type Hero and damage type Normal
      • Else - Actions
    Readability of the filter function can be improved. Also, another location handle (Position of MonkeyArena) has been generated and not cleaned up.
    
    
  • • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((MonkeyArenaDuration - MonkeyArenaDurationLeft) mod 12.00) Equal to 0.00
      • Then - Actions
        • -------- Model of arena will disapear around12 seconds, so we swap arena for new, it is looks a little weird since dragon will change positiom, but it is better than nothing --------
        • Unit - Replace MonkeyArena with a Monkey Arena using The old unit's relative life and mana
        • Animation - Change (Last replaced unit) 's size to ( (100.00 x MonkeyArenaScale) %, (100.00 x MonkeyArenaScale) %, 100.00 %) of its original size
        • Set Variable Set MonkeyArena = (Last replaced unit)
        • Hashtable - Save Handle Of MonkeyArena as 0 of (Key (Picked unit).) in MonkeyArenaHastable .
      • Else - Actions
    I suggest resetting the MonkeyArena unit's animation instead of replacing the MonkeyArena unit (model) every 12 seconds.
    
    
• In the triggers Statue Cast and Mischief:
  • (A unit finishes casting an ability) -> (A unit starts the effect of an ability).
    
    
• In the Tree Dance Folder:
  • In trigger IncreaseLvl:
    • In the if-then conditional block, (Picked unit) is used over (Learning Hero). Given the event, (Picked unit) will always return null, leading to the condition never evaluating as true (Level Equal to 1?).
  • There may be a lot more things I'd like to point out here, but I will leave it for another day.

Phew, that was a lot to write. Interesting and functional as it currently is, there are a too many instances of memory leaks that need to be removed for me to approve of this right now, so I'll have to put it in Awaiting Update.

Version Reviewed:

• v.1.0.1 (?) - Released 22nd of June, 2022.

Status:

• Awaiting Update

 

[Oliphant]

Neat. If I recall, Monkey King was the first Dota 2 exclusive Hero to be introduced. It would be poetic justice to see that it is one of the first Dota 2 exclusive Heroes to be properly (re)introduced back into Warcraft 3. Anyway, here's the code/trigger review:

Spoiler: Code Review

• In the trigger BoundleStrike (Boundle):
  • BoundleAngle appears to be causing a memory leak by referring to an unstored generated location handle in (Position of BoundleStrikeUnit). You could fix that by making it refer to BoundleStartingPosition, moving the initialization of BoundleStartingPosition before it.
    
    
  • In the same vein, BoundleEndingPoint should refer to BoundleStartingPosition.
    
    
  • • For each (Integer A) from 1 to 3 , do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (X of BoundleCorners[(Integer A)]) Greater than BoundleMaxX
          • Then - Actions
            • Set Variable Set BoundleMaxX = (X of BoundleCorners[(Integer A)])
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (X of BoundleCorners[(Integer A)]) Less than BoundleMinX
              • Then - Actions
                • Set Variable Set BoundleMinX = (X of BoundleCorners[(Integer A)])
              • Else - Actions
    From the looks of things, there's no need to nest the conditions within the else block. Just move the inner if-then block out of the outer if-then-else block.
    
    
  • • -------- Picking Unit Affecte by Boundle --------
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in (Region(BoundleMinX, BoundleMinY, BoundleMaxX, BoundleMaxY)) matching ((((Matching unit) belongs to an enemy of (Owner of BoundleStrikeUnit).) Equal to True) and ((((Matching unit) is A flying unit) Equal to False) and ((((Matching unit) is Magic Immune) Equal to False) and (((Matching unit) is Mechanical) Equal to False))))) and do (Actions)
      • Loop - Actions
        • -------- Finding point of center of unit in rotated env --------
        • Set Variable Set RotatedPositionOfUnit = ((Point(BoundleCenterX, BoundleCenterY)) offset by (Distance between (Position of (Picked unit)) and (Point(BoundleCenterX, BoundleCenterY))) towards ((Angle from (Position of (Picked unit)) to (Point(BoundleCenterX, BoundleCenterY))) - (BoundleAngle - 90.00)) degrees.)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • And - All (Conditions) are true
              • Conditions
                • (X of RotatedPositionOfUnit) Less than or equal to (X of BotRightCornerInRotatedBoundle)
                • (X of RotatedPositionOfUnit) Greater than or equal to (X of BotLeftCornerInRotatedBoundle)
                • (Y of RotatedPositionOfUnit) Greater than or equal to (Y of BotLeftCornerInRotatedBoundle)
                • (Y of RotatedPositionOfUnit) Less than or equal to (Y of TopLeftCornerInRotatedBoundle)
          • Then - Actions
            • Unit Group - Add (Picked unit) to UnitsAffectedByBoundle
            • -------- Continue would be nice there istead of else if to have less indentation --------
          • Else - Actions
            • -------- Finding closest Y to rotated position of unit --------
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Y of RotatedPositionOfUnit) Greater than (Y of TopLeftCornerInRotatedBoundle)
              • Then - Actions
                • Set Variable Set ClosestYToRotatedPoint = (Y of TopLeftCornerInRotatedBoundle)
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Y of RotatedPositionOfUnit) Less than (Y of BotLeftCornerInRotatedBoundle)
                  • Then - Actions
                    • Set Variable Set ClosestXToRotatedPoint = (X of BotRightCornerInRotatedBoundle)
                    • Set Variable Set ClosestYToRotatedPoint = (Y of BotLeftCornerInRotatedBoundle)
                  • Else - Actions
                    • Set Variable Set ClosestYToRotatedPoint = (Y of RotatedPositionOfUnit)
            • -------- Finding closest X to rotated position of unit --------
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (X of RotatedPositionOfUnit) Less than (X of BotLeftCornerInRotatedBoundle)
              • Then - Actions
                • Set Variable Set ClosestXToRotatedPoint = (X of BotLeftCornerInRotatedBoundle)
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (X of RotatedPositionOfUnit) Greater than (X of BotRightCornerInRotatedBoundle)
                  • Then - Actions
                    • Set Variable Set ClosestXToRotatedPoint = (X of BotRightCornerInRotatedBoundle)
                  • Else - Actions
                    • Set Variable Set ClosestXToRotatedPoint = (X of RotatedPositionOfUnit)
            • Set Variable Set BoundleDistanceToEdge = (Square root(((Power((Abs(((X of RotatedPositionOfUnit) - ClosestXToRotatedPoint))), 2.00)) + (Power((Abs(((Y of RotatedPositionOfUnit) - ClosestYToRotatedPoint))), 2.00)))))
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Collision Size of (Picked unit)) Greater than or equal to BoundleDistanceToEdge
              • Then - Actions
                • Unit Group - Add (Picked unit) to UnitsAffectedByBoundle
              • Else - Actions
    1.) It looks like a JASS rect (GUI region) handle is being created without being referenced and subsequently cleaned up. You can clean this up using the following function: native RemoveRect takes rect whichRect returns nothing.
    
    2.) The inner filter function in the nested matching condition statement can look quite ugly really fast with a lot of conditions. Try filtering them out within the Actions block instead. Check out this tutorial for more info: Convenient Unit Group Filtering in GUI
    
    3.) The liberal use of (Position of (Picked unit)) translates to more memory leaks.
    
    4.) You can use Skip Remaining Actions in the Then - Actions block on the first If-then-else block as a quasi-continue statement, since the function (Pick all units in n group) generates a new thread for each picked unit. (Memory leaks that have been created before that point will have to be cleaned up, though).
    
    5.) (Picked unit) is called an awful lot within this block. Perhaps you might want to store that in a temp variable?
    
    
  • The floating text should only show the integer value of the amount of damage dealt, not the real value. (250 instead of 250.16, for example).
    
• In the trigger Jingu Lifesteal:
  • You can directly call FlushChildHashtable instead of the wrapper.
    • API difference between the two functions:
      

      native FlushChildHashtable takes hashtable whichHashtable, integer parentKey
      function FlushChildHashtableBJ takes integer parentKey, hashtable whichHashtable

• In the trigger Jingu Check for Buff:
  • Don't be shy with the interval period. Even when not enabled and disabled properly, this trigger should not be too costly. I'd recommend a 0.50 second interval.
    
• In the trigger ArenaCreate:
  • The (A unit starts the effect of an ability) event would be more suitable here.
    
• In the trigger Arena Damage (may also apply in ArenaSoldiersV2):
  • (Position of MonkeyArena) and (Position of MonkeyArenaCreator) is not stored.
    
    
  • • Set Variable Set MonkeyArenaToDamageLeft = ((Load 2 of (Key (Picked unit).) from MonkeyArenaHastable.) - 0.04)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • MonkeyArenaToDamageLeft Less than or equal to 0.00
      • Then - Actions
        • Set Variable Set MonkeyArenaToDamageLeft = MonkeyArenaDamageInterval
        • Custom script: set bj_wantDestroyGroup = true
        • Unit Group - Pick every unit in (Units within MonkeyArenaSize of (Position of MonkeyArena) matching (((Matching unit) belongs to an ally of (Owner of MonkeyArenaCreator).) Equal to False).) and do (Actions)
          • Loop - Actions
            • Unit - Cause MonkeyArenaCreator to damage (Picked unit) , dealing ((Real((Base Damage of MonkeyArenaCreator for weapon index 1))) x MonkeyArenaDamageMult) damage of attack type Hero and damage type Normal
      • Else - Actions
    Readability of the filter function can be improved. Also, another location handle (Position of MonkeyArena) has been generated and not cleaned up.
    
    
  • • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((MonkeyArenaDuration - MonkeyArenaDurationLeft) mod 12.00) Equal to 0.00
      • Then - Actions
        • -------- Model of arena will disapear around12 seconds, so we swap arena for new, it is looks a little weird since dragon will change positiom, but it is better than nothing --------
        • Unit - Replace MonkeyArena with a Monkey Arena using The old unit's relative life and mana
        • Animation - Change (Last replaced unit) 's size to ( (100.00 x MonkeyArenaScale) %, (100.00 x MonkeyArenaScale) %, 100.00 %) of its original size
        • Set Variable Set MonkeyArena = (Last replaced unit)
        • Hashtable - Save Handle Of MonkeyArena as 0 of (Key (Picked unit).) in MonkeyArenaHastable .
      • Else - Actions
    I suggest resetting the MonkeyArena unit's animation instead of replacing the MonkeyArena unit (model) every 12 seconds.
    
• In the triggers Statue Cast and Mischief:
  • (A unit finishes casting an ability) -> (A unit starts the effect of an ability).
    
• In the Tree Dance Folder:
  • In trigger IncreaseLvl:
    • In the if-then conditional block, (Picked unit) is used over (Learning Hero). Given the event, (Picked unit) will always return null, leading to the condition never evaluating as true (Level Equal to 1?).
  • There may be a lot more things I'd like to point out here, but I will leave it for another day.

Phew, that was a lot to write. Interesting and functional as it currently is, there are a too many instances of memory leaks that need to be removed for me to approve of this right now, so I'll have to put it in Awaiting Update.

Version Reviewed:

• v.1.0.1 (?) - Released 22nd of June, 2022.

Status:

• Awaiting Update

Thanks for feedback, may I ask Why do you suggest using "A unit starts the effect of an ability" instead of "unit finishes casting an ability", is it because of perfomence or some gameplay diffrence in fringe scenarios.
You said that position of picked/casting unit leaks in every time? I thought it's only leaks when you order unit some action(moving) to that point or creating unit at that point.
Also i wonder how did Increase Lvl trigger worked correctly when i tested it, even though there is no way it should work with this check, maybe i changed it accidentally.
Nice suggestion with resetting arena animation.
Are there any other memory leaks that you didn't mention here?

 

[MyPad]

Spells usually implement their effects at the event (A unit starts the effect of an ability), the moment when the manacost and cooldown has been applied. It's the norm for most spells here to use this event instead of (A unit finishes casting an ability).

Whenever (Position of unit) is called, a new location handle pointing to the current coordinates of the unit is generated.

As for Increase Level trigger working despite the logical error, I found that the Hero learning the ability already has the Spring Tree (or Spring Dance?) sub-ability at the moment when the event runs.

I'm not fully certain yet about the presence of more memory leaks (specifically within the Tree Dance folder). I will have to check that out in more detail and update my review accordingly.

For now, memory leaks can be spotted when functions that return a new handle (enclosed in opening-closing parentheses) are not stored in variables for subsequent clean-up. Such handle types to look out for are points (locations), Unit Groups, Special Effects (not used here), which are most commonly generated.

I did not bring this up in the review, but you can also use (Trigger unit) for all of these unit events, in place of their event-appropriate counterparts.