Magnetic Saw Trap v1.063

[Moderator]

18:54, 12th May 2010
The_Reborn_Devil:

The triggering looks good and the effects are neat.


Status: Approved
Rating: Recommended

 

[The World Is Flat]

Worked 50% of the time. i say OK!

 

[Pharaoh_]

Notes

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Load 1 of (Key (Picked unit)) from Magnetic_Saw_Hash) Less than 150
  • Then - Actions
    • Lightning - Destroy (Load 14 of (Key (Picked unit)) in Magnetic_Saw_Hash)
    • Unit - Cause (Load 10 of (Key (Picked unit)) in Magnetic_Saw_Hash) to damage (Picked unit), dealing (Real((Load 13 of (Key (Load 10 of (Key (Picked unit)) in Magnetic_Saw_Hash)) from (Last created hashtable)))) damage of attack type Spells and damage type Normal
    • Set Temp_Point[1] = (Position of (Picked unit))
    • Set Temp_Point[2] = (Position of (Load 10 of (Key (Picked unit)) in Magnetic_Saw_Hash))
    • Hashtable - Save (Integer((Distance between Temp_Point[1] and Temp_Point[2]))) as 1 of (Key (Picked unit)) in Magnetic_Saw_Hash
    • Lightning - Create a Drain Life lightning effect from source Temp_Point[1] to target Temp_Point[2]
    • Hashtable - Save Handle Of(Last created lightning effect) as 14 of (Key (Picked unit)) in Magnetic_Saw_Hash
    • Special Effect - Create a special effect at Temp_Point[1] using Abilities\Spells\Other\Stampede\StampedeMissileDeath.mdl
    • Special Effect - Destroy (Last created special effect)
    • Custom script: call RemoveLocation (udg_Temp_Point[1])
    • Custom script: call RemoveLocation (udg_Temp_Point[2])
  • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
      • (Load 1 of (Key (Picked unit)) from Magnetic_Saw_Hash) Greater than or equal to 150
    • Then - Actions
      • Lightning - Destroy (Load 14 of (Key (Picked unit)) in Magnetic_Saw_Hash)
      • Set Temp_Point[1] = (Position of (Picked unit))
      • Set Temp_Point[2] = (Position of (Load 10 of (Key (Picked unit)) in Magnetic_Saw_Hash))
      • Hashtable - Save (Integer((Distance between Temp_Point[1] and Temp_Point[2]))) as 1 of (Key (Picked unit)) in Magnetic_Saw_Hash
      • Hashtable - Save (Angle from Temp_Point[1] to Temp_Point[2]) as 2 of (Key (Picked unit)) in Magnetic_Saw_Hash
      • Set Temp_Point[3] = (Temp_Point[1] offset by (Real((Load 11 of (Key (Load 10 of (Key (Picked unit)) in Magnetic_Saw_Hash)) from Magnetic_Saw_Hash))) towards (Load 2 of (Key (Picked unit)) from Magnetic_Saw_Hash) degrees)
      • Lightning - Create a Drain Life lightning effect from source Temp_Point[1] to target Temp_Point[2]
      • Hashtable - Save Handle Of(Last created lightning effect) as 14 of (Key (Picked unit)) in Magnetic_Saw_Hash
      • Custom script: call RemoveLocation (udg_Temp_Point[1])
      • Unit - Move (Picked unit) instantly to Temp_Point[3]
      • Set Temp_Point[1] = (Position of (Picked unit))
      • Hashtable - Save (Integer((Distance between Temp_Point[1] and Temp_Point[2]))) as 1 of (Key (Picked unit)) in Magnetic_Saw_Hash
      • Custom script: call RemoveLocation (udg_Temp_Point[1])
      • Custom script: call RemoveLocation (udg_Temp_Point[2])
      • Custom script: call RemoveLocation (udg_Temp_Point[3])
    • Else - Actions

That could be

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Load 1 of (Key (Picked unit)) from Magnetic_Saw_Hash) Less than 150
  • Then - Actions
    • Lightning - Destroy (Load 14 of (Key (Picked unit)) in Magnetic_Saw_Hash)
    • Unit - Cause (Load 10 of (Key (Picked unit)) in Magnetic_Saw_Hash) to damage (Picked unit), dealing (Real((Load 13 of (Key (Load 10 of (Key (Picked unit)) in Magnetic_Saw_Hash)) from (Last created hashtable)))) damage of attack type Spells and damage type Normal
    • Set Temp_Point[1] = (Position of (Picked unit))
    • Set Temp_Point[2] = (Position of (Load 10 of (Key (Picked unit)) in Magnetic_Saw_Hash))
    • Hashtable - Save (Integer((Distance between Temp_Point[1] and Temp_Point[2]))) as 1 of (Key (Picked unit)) in Magnetic_Saw_Hash
    • Lightning - Create a Drain Life lightning effect from source Temp_Point[1] to target Temp_Point[2]
    • Hashtable - Save Handle Of(Last created lightning effect) as 14 of (Key (Picked unit)) in Magnetic_Saw_Hash
    • Special Effect - Create a special effect at Temp_Point[1] using Abilities\Spells\Other\Stampede\StampedeMissileDeath.mdl
    • Special Effect - Destroy (Last created special effect)
    • Custom script: call RemoveLocation (udg_Temp_Point[1])
    • Custom script: call RemoveLocation (udg_Temp_Point[2])
  • Else - Actions
    • Lightning - Destroy (Load 14 of (Key (Picked unit)) in Magnetic_Saw_Hash)
    • Set Temp_Point[1] = (Position of (Picked unit))
    • Set Temp_Point[2] = (Position of (Load 10 of (Key (Picked unit)) in Magnetic_Saw_Hash))
    • Hashtable - Save (Integer((Distance between Temp_Point[1] and Temp_Point[2]))) as 1 of (Key (Picked unit)) in Magnetic_Saw_Hash
    • Hashtable - Save (Angle from Temp_Point[1] to Temp_Point[2]) as 2 of (Key (Picked unit)) in Magnetic_Saw_Hash
    • Set Temp_Point[3] = (Temp_Point[1] offset by (Real((Load 11 of (Key (Load 10 of (Key (Picked unit)) in Magnetic_Saw_Hash)) from Magnetic_Saw_Hash))) towards (Load 2 of (Key (Picked unit)) from Magnetic_Saw_Hash) degrees)
    • Lightning - Create a Drain Life lightning effect from source Temp_Point[1] to target Temp_Point[2]
    • Hashtable - Save Handle Of(Last created lightning effect) as 14 of (Key (Picked unit)) in Magnetic_Saw_Hash
    • Custom script: call RemoveLocation (udg_Temp_Point[1])
    • Unit - Move (Picked unit) instantly to Temp_Point[3]
    • Set Temp_Point[1] = (Position of (Picked unit))
    • Hashtable - Save (Integer((Distance between Temp_Point[1] and Temp_Point[2]))) as 1 of (Key (Picked unit)) in Magnetic_Saw_Hash
    • Custom script: call RemoveLocation (udg_Temp_Point[1])
    • Custom script: call RemoveLocation (udg_Temp_Point[2])
    • Custom script: call RemoveLocation (udg_Temp_Point[3])

You also need a Unit Group to add your dummy and turn on a trigger manually, than have a trigger running eternally every 0.03 seconds:

• Casting
• Events
  • Unit - A unit Starts the effect of an ability
• Conditions
  • (Ability being cast) Equal to Magnetic saw trap
• Actions
  • Set Temp_Point[1] = (Target point of ability being cast)
  • Special Effect - Create a special effect at Temp_Point[1] using Abilities\Spells\Items\TomeOfRetraining\TomeOfRetrainingCaster.mdl
  • Special Effect - Destroy (Last created special effect)
  • Unit - Create 1 Magnetic Saw Trap for (Owner of (Triggering unit)) at Temp_Point[1] facing Default building facing degrees
  • Unit - Add a ((Real(Config[4])) x (Real((Level of Magnetic saw trap for (Triggering unit))))) second Generic expiration timer to (Last created unit)
  • Unit Group - Add (Last created unit) to SawTrapGroup //This line is new
  • Custom script: call RemoveLocation (udg_Temp_Point[1])
  • //Rest actions here
  • Trigger - Turn on Magnetism and saw damage <gen> //This line is new

• Magnetism and saw damage
• Events
  • Time - Every 0.03 seconds of game time
• Conditions
• Actions
  • If (All conditions are true) then do (Actions) else do (Actions)
    • If - Conditions
      • (SawTrapGroup is empty) Equal to True
    • Then - Actions
      • Trigger - Turn off (This trigger)
    • Else - Actions
      • Unit Group - Pick every unit in (SawTrapGroup) and do (Actions)
        • Loop - Actions
          • //Actions here

What is more, do not use Point indexes on different triggers. For example, you used Point[1] in the first trigger. Don't use [1] again in another trigger. Go on with [2], [3], ..., and so on.

• Skip remaining actions

Not necessary, if you use do it the way I told you with Turn on/off Trigger.

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • ((Picked unit) is dead) Equal to True
  • Then - Actions
    • Lightning - Destroy (Load 14 of (Key (Picked unit)) in Magnetic_Saw_Hash)
    • Unit Group - Remove (Picked unit) from Magnetised_Group
    • Set Temp_Point[1] = (Position of (Picked unit))
    • Special Effect - Create a special effect at Temp_Point[1] using Abilities\Spells\Other\Stampede\StampedeMissileDeath.mdl
    • Special Effect - Destroy (Last created special effect)
    • Hashtable - Save Handle OfNo unit as 10 of (Key (Picked unit)) in Magnetic_Saw_Hash
    • Custom script: call RemoveLocation (udg_Temp_Point[1])
  • Else - Actions

Could be:

• Death
• Events
  • Unit - A unit dies
• Conditions
  • ((Triggering unit) is in SawTrapGroup) Equal to True
• Actions
  • Unit Group - Remove (Triggering unit) from SawTrapGroup
  • Lightning - Destroy (Load 14 of (Key (Picked unit)) in Magnetic_Saw_Hash)
  • Unit Group - Remove (Picked unit) from Magnetised_Group
  • Set Temp_Point[1] = (Position of (Picked unit))
  • Special Effect - Create a special effect at Temp_Point[1] using Abilities\Spells\Other\Stampede\StampedeMissileDeath.mdl
  • Special Effect - Destroy (Last created special effect)
  • Hashtable - Save Handle OfNo unit as 10 of (Key (Picked unit)) in Magnetic_Saw_Hash
  • Custom script: call RemoveLocation (udg_Temp_Point[1])

 

[Tank-Commander]

Lol, forgot about turning it off when uneeded xP I'll get that done right away.

Well, as a general no major problems/errors?

 

[The World Is Flat]

Updated.

 

[Tank-Commander]

Spell updated, Read the changelog. Basically all I did was add the documentation, a few changes here and there etc.

 

[Klingo]

I casted at an unpathable place and it bugged , you'll see whit my picture

 

[Cihparg]

The spell is dull as shit.
The unit's have no opportunity of running away, but that is because you are using

• Unit - Move (unit) instantly to point

when you COULD be using coordinates

• Custom script: set udg_X = GetUnitX(udg_unit)
• Custom script: set udg_Y = GetUnitY(udg_unit)
• Custom script: call SetUnitX(udg_unit,udg_X + udg_speed * cos(udg_AngleBtwPoints * bj_DEGTORAD))
• Custom script: call SetUnitY(udg_unit,udg_Y + udg_speed * sin(udg_AngleBtwPoints * bj_DEGTORAD))

It may be longer, but it hell is better.

 

[Tank-Commander]

@Klingo hmm, I'll look into it right away.

Edit:Fixed and ready upon next update

@Offgraphic Units aren't SUPPOSED to be able to get away, it's meant to be like the magnetic saw in RA3 inwhich you cannot escape the saw, also you don't have to be rude about it.

Edit: If it's oh so neccercary then I may consider it, but I would prefer to keep it to as similar as to the RA3 game were I got the idea from.

 

[Cihparg]

You know, waiting like 10 seconds first for the units to get to the saws, and then they just stand there doing nothing, except taking damage of imaginary saws.

This isn't really a good thing.

A possibility for the units to run away WOULD be a cool idea.

Last comment: This spell is at this moment, Dull as shit.

PS: Red alert 3 was a fail anyways... So was the fourth one also.

 

[The World Is Flat]

its friggen awesome imo.

 

[Tank-Commander]

You know, waiting like 10 seconds first for the units to get to the saws, and then they just stand there doing nothing, except taking damage of imaginary saws.

This isn't really a good thing.

A possibility for the units to run away WOULD be a cool idea.

Last comment: This spell is at this moment, Dull as shit.

PS: Red alert 3 was a fail anyways... So was the fourth one also.

A. You can change how magnetic the saws are, changing how long it takes to pull units in and 10 seconds is a huge exagguration.

B. Units can destroy the saws to break themselves free, I just made it so they didn't in the test map cos you had no units to really distract them with.
Also, They don't 'just stand there' as such, they would attempt to destroy the saw and if range would continue to fire at their target

C. You do not need to swear at everything, a much more polite manner would be much prefered by most.

D. You say it's a fail, but no need to publicise your opinion, you make it sound as if theres no debate about it, so keep it to yourself.

E. Now, before you go onto 'ranged unit should be able to attack while they are being pulled' and what not that I would expect from one such as you, this is a recreation of a RA3 spell, just modified to be an AOE trap, units grab by the saw cannot move, attack or do anything of the sort.

Edit: Just uploaded the version were the bug was fixed, not really big enough to be considered a new 'version' as such.

 

[Cihparg]

To be correct, I've not sweared at everything. If you mean shit, that's not actually swearing, because Shit is just another way to say Crap.

I'm testing now the new test map, if there is any changes made.

Well, not quite better.
I still dislike that units are not free to move anywhere.

How could you improve it:
Well, fasten the testmap's magnetic power or whatever is the drag power.
And also, if you could, give the units a possibility to run away normally ([rainbow][confirm="Examble code:
Custom script: set X = GetUnitX(trap)
Custom script: set Y = GetUnitY(trap)
Custom script: set XY = Location(X,Y)
Custom script: set X2 = GetUnitX(target)
Custom script: set Y2 = GetUnitX(target)
Custom script: set X2Y2 = Location(X2,Y2)
Custom script: set AngleBtwPoints = AngleBetweenPoints(XY,X2Y2)
Custom script: set Power = GetUnitMoveSpeed(trap) / 75
Custom script: SetUnitX(trap,X + Power * Cos ( AngleBtwPoints * bj_DEGTORAD ) )
Custom script: SetUnitY(trap,Y + Power * Sin ( AngleBtwPoints * bj_DEGTORAD ) )
Custom script: call RemoveLocation(XY)
Custom script: call RemoveLocation(X2Y2)

ENDLINE
"]Examble Code Here, Press[/confirm][/rainbow])

Current Rating: 2½/5 ( 3/5 )

 

[redscores]

Don't you get it? OffGraphics? he doesn't want that stuff with moveable while drawn towards the trap because he wants it like in the game, now rest your case and stop forcing your opinion.

 

[Septimus]

PS: Red alert 3 was a fail anyways... So was the fourth one also.

Sorry for being offtopic, but this is really qft.

 

[Bribe]

How do GUI spells even get approved?

 

[Catch_ya]

How do GUI spells even get approved?

A moderator clicks the "approved" button. It is not a good moment to start the discussion about GUI and Jass/vJass, self even I agree with you.

 

[NFWar]

Until blizzard will not delete GUI from WE you are helpless JASSERS!
Nice spell btw, effects are rly neat ^^

 

[Vengeancekael]

Looks good +rep

 

[tjordell]

Instead of Integer A. Use a Integer Variable. That's what i've learned from Pharaoh_ i think Otherwise, if someone uses 2 spells with integer A and the spells will be casted at the same time, the Integer A variable will raise 200% faster than normal.

 

[Bribe]

As long as there is no Wait action, there is no problem using bj_forLoopAIndex

 

[tjordell]

Is it =O
I've heard from some ppls that it can jump over one integer because another trigger uses the same Integer A.

 

[Catch_ya]

Just fix it Bribe. It can be a problem self even there is no wait action. Blizzard did it again you know, just replace it with another integer.

 

[Tank-Commander]

Lol, you made it sound as if Bribe made it, anyway fixed that 'integer A' thing, tbh I cba to change the version number, there no real point for such a tiny thing.

 

[Catch_ya]

Lol, you made it sound as if Bribe made it.

Whoops, I'm sorry. I wasn't paying attention to who made it.

 

[Dr. Boom]

Moin moin =)

== My personal vote: NO! approval [3/5] ==
(Read the full review to understand this ration)

> Hive Workshop uploading:
1) Name of the spell is ok with name and version [5/5]
2) Name of the spell-map is ok, but doesn't include the version [4/5]
3) Most key words are ok, but there are some, that are no needed like "Unorthodox", "Aggrovating" [3,5/5]
4) You have a good description, with the triggers and a changelog [5/5]

> The Spell " Magnetic Saw Trap":
1) As far I can see it, the spell is MPI + MUI [5/5]
2) Under certain conditions, the enemies can be dragged over not path able terrain like cliffs [2/5]

The target starts on the right side of the cliff

3) The targets can be dragged through trees and destructible and can bug then. You should add, that trees and destructible are destroyed around the trap and around the dragged targets. [0/5]

Again the test target was on the right side

4) If I create spell out of the map, the "wisp" is ported to the map, but the missiles stay out of the map, you should think about it. [3,5/5]

Screen for this:

5) The idea of the spell is very good, can be used in map, can be used as normal traps and as a cast able spell [5/5]

> Optional - The test map:
1) I like the idea with the test map. Here you can see, what the spell can do. [5/5]
2) Terrain + Doodads: Very simple, but very good for testing the spell in many situations [4,5/5]
3) You map requires a lot of triggers, but they have leaks and you can reduce the number of triggers with combination [2,5/5] like:

Click

• Trig
  • Events
    • Player - Player 1 (Red) types a chat message containing - as A substring
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Entered chat string) Equal to -revive
      • Then - Actions
        • -------- actions --------
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Entered chat string) Equal to -level up
          • Then - Actions
            • -------- actions --------
          • Else - Actions

== Ok what we got at the end ==
Necessary points:
Hive upload: 5 + 4 + 3.5 + 3.5 + 5 = [21/25]
Spell: 5 + 2 + 0 + 5 = [12/20]
At all [33/45] ~73.33% of 100%.

Optional points:
5 + 4.5 + 2.5 = [12/15] ~ 80.00% of 100%

Within calculate the bugs of the doodads, trees and cliffs + the optional leaks and improvements I would give 1/5, but the map stuff is optional and the spell idea is good and can be very useful I think for now 3/5 is ok. When you fix those necessary bugs I will give 4/5 and then it's approval.

NOTE: My review is NOTHING against the creator of the spell and NOTHING against the spell at all. But it needs some fixes, else you can bug it and in this case, I don't know why this get an approval, if this isn't tested under more conditions and still has some mistakes in it!!

Greetings and Peace
Dr. Boom

 

[Tank-Commander]

huh how ironic, the bugs are only caused because of using co-ordinates (as offgraphic so heavily demanded, whom gave the same rating, give me a few seconds and I'll fix that, not hard to do at all.

Edit: Small triggering oversite, fixed now, units won't be pulled out of the map, trapped in objects, etc.

Edit2: As far as I was aware, there was some debate on wether or not regions leak, so I'll search for some solid confirmation.

Edit3: I don't see the relavance of triggers which are not included with the spell, or as it were, why they matter.

 

[Dr. Boom]

Moin moin =)

I'm very sorry that I don't have time only for you and I also changed my rating to 4/5, but anyway to the spell:

- I'm still able to drag the enemy units through trees, so the unit stands in the trees.
- I'm still able to drag the unit out of the map. Only a little, but it is out of the map, so it can't be dragged in again.
- Also it seems to be that you make a wrong check if the terrain is pathable around the dragged unit, because I can't drag this unit:

Click Clack

- I notice also, that there must be some bug with the damage, sometimes the unit gets much damage, sometimes low damage and sometimes no damage as you can see here:

Click Clack

All in all it's ok then, but there are still some bugs you need to fix.

Greetings and Peace
Dr. Boom

 

[Tank-Commander]

Well from what I can say I tried to re-create the bugs:

- I cannot pull a unit out of the map to the extent of being stuck outside, it just walks back in afterward (I used a sheep to test this)
- There is only 1 possible collision test, if it didn't work, it's cos you placed the archmage into a normally inaccessible area (again I couldn't re-create this bug)
-The units can be dragged through trees, but not to the extend of being stuck within (I tested this with sheep, walked right back out again)
- as far as damage, thats cos the unit is running away from the saw and is 'just' out of range of it, so some of the damage isn't applied since on every so often on the 0.03's it is out of range.

I'll look into it, but I dunno how you're finding these things.

 

[Kam]

You need to add a variable for maximum units pulled.

Edit: Also this line:

• Unit - Cause (Load 10 of (Key (Picked unit)) in Magnetic_Saw_Hash) to damage (Picked unit), dealing (Real((Load 13 of (Key (Load 10 of (Key (Picked unit)) in Magnetic_Saw_Hash)) from (Last created hashtable)))) damage of attack type Spells and damage type Normal

should read:

• Unit - Cause (Load 10 of (Key (Picked unit)) in Magnetic_Saw_Hash) to damage (Picked unit), dealing (Real((Load 13 of (Key (Load 10 of (Key (Picked unit)) in Magnetic_Saw_Hash)) from Magnetic_Saw_Hash))) damage of attack type Spells and damage type Normal

 

[Tank-Commander]

Never really wanted to add a limit to the amount of units pulled, but yeah I'll change that line.

 

[maddeem]

How do GUI spells even get approved?

Honestly no one should be using GUI, the mere amount of useless BJs calls GUI has is astonishing. Most spells processing time can be cut down to 1/2 or even more. I remember when I thought GUI was even slightly efficient.

 

[Kam]

GUI gets approved because it's fine. More people understand it than do JASS or other languages. TC makes some damn useful spells with GUI.