[Lua] [Lua] [Jass] Correcting attack/armor icon placement

[Mayday]

Hello! I noticed a while ago that the Reforged icons were being cut off, or overlapping, in game. This is a script to correct that behavior.

In the image, you can see how both the (un-upgraded) and (upgradable) icons no longer overlap and cut each other off, versus the original, which removes a pixel line of the icon border, or covers the upgrade value box.

This also aligns the Damage text with Strength, on heroes.

scope DamageAlignment initializer Init
    function UISetup takes nothing returns nothing
        local framehandle fh = BlzGetFrameByName("InfoPanelIconBackdrop", 0)
        call BlzFrameClearAllPoints(fh)
        call BlzFrameSetAbsPoint(fh, FRAMEPOINT_TOPRIGHT, 0.3455, 0.083)
        set fh = null
    endfunction
 
    private function Init takes nothing returns nothing
        call UISetup()
    endfunction
endscope

do
    local timer = CreateTimer()
    TimerStart( timer, 0, false, function()
        local framehandle
        fh = BlzGetFrameByName("InfoPanelIconBackdrop", 0)
        BlzFrameClearAllPoints(fh)
        BlzFrameSetAbsPoint(fh, FRAMEPOINT_TOPRIGHT, 0.3455, 0.083)
        DestroyTimer(timer)
    end)
end

 

[maddeem]

Undefined handles are already null, so no need to do that during local declaration.

However, you do need to null that handle at the end of the script.

Also you might as well define the local immediately:

function UISetup takes nothing returns nothing
    local framehandle fh = BlzGetFrameByName("InfoPanelIconBackdrop", 0)
    // Fix Damage and Armor overlap
    call BlzFrameClearAllPoints(fh)
    call BlzFrameSetAbsPoint(fh, FRAMEPOINT_TOPRIGHT, 0.3455, 0.083)
     set fh = null
endfunction

 

[Jampion]

You should add proper vJASS initialization. There is no need for a pure JASS version, because this resource is only for newer versions.

 

[Mayday]

You should add proper vJASS initialization. There is no need for a pure JASS version, because this resource is only for newer versions.

Thank you, they should both now be automatically initialized for easy copy paste.

 

[Bribe]

Your Lua script will crash during initialization. This should just use Global Initialization and use the "onGameStart" function.

 

[Mayday]

Your Lua script will crash during initialization. This should just use Global Initialization and use the "onGameStart" function.

Hi Bribe,

Is this a multiplayer issue? I use this script in a map, I have not had any crash issues related.

 

[Bribe]

Hi Bribe,

Is this a multiplayer issue? I use this script in a map, I have not had any crash issues related.
View attachment 398048

For me in 2019, a single TimerStart call would crash the entire initialization thread. Maybe this was fixed in a later patch? I’ll need to run some tests.

 

[Mayday]

For me in 2019, a single TimerStart call would crash the entire initialization thread. Maybe this was fixed in a later patch? I’ll need to run some tests.

being that it is very simple I did not feel the need to test it in multiple ways; please let me know if there is an issue!

 

[Bribe]

Even something simple like:

do
    local timer = CreateTimer()
    TimerStart( timer, 0, false, function()
        local framehandle
        fh = BlzGetFrameByName("InfoPanelIconBackdrop", 0)
        BlzFrameClearAllPoints(fh)
        BlzFrameSetAbsPoint(fh, FRAMEPOINT_TOPRIGHT, 0.3455, 0.083)
        DestroyTimer(timer)
    end)
    print(“Timer Started”) -- won’t run. Or at least, didn’t run back in 2019.
end

 

[Bribe]

I've tested it, and it does indeed work now. They must've patched it at some point after 2019.

Approved.