LocalPlayer() fog of war does desync

[ToldYouSo]

GetLocalPlayer() faq
7) point
It's not the correct way I guess, but the vjass version solution on page 5 isnt clear for me as vanilla jass.

 

[JsonDalao]

GetLocalPlayer is an asynchronous operation that can easily cause a drop

 

[Pyrogasm]

The issue in that instance is locally creating the fogmodifier handle. As stated in the post on page 5, creating the modifier globally and enabling/disabling it locally is the safe way to do it.

 

[ToldYouSo]

So, this should be valid, then?

local fogmodifier fr = CreateFogModifierRect(Player(0), FOG_OF_WAR_VISIBLE, bj_mapInitialPlayableArea, false, false)
        call FogModifierStop(fr)
    if GetLocalPlayer() == Player(0) then //+++++ REMOVING FOG MASK TO ALLOW PLAYER LOOK FOR MISSLE
call FogModifierStart(fr)
endif
set fr = null

 

[JsonDalao]

So, this should be valid, then?

local fogmodifier fr = CreateFogModifierRect(Player(0), FOG_OF_WAR_VISIBLE, bj_mapInitialPlayableArea, false, false)
        call FogModifierStop(fr)
    if GetLocalPlayer() == Player(0) then //+++++ REMOVING FOG MASK TO ALLOW PLAYER LOOK FOR MISSLE
call FogModifierStart(fr)
endif
set fr = null

Yes,but...Is the fogmodifier created by "fr" no longer used

 

[Dr Super Good]

Also it will still cause a desync if it allows a unit to do something they could not do in the other state.

For example placing a range unit at the base of a cliff with a melee enemy unit above. By default the range unit cannot see the melee unit above so cannot attack it. A modifier is then created and kept disabled for everyone and the ranged unit still cannot see and attack the melee unit. The modifier is then enabled locally for a single player resulting in the ranged unit being able to attack the melee unit but just on that player's client. The player is now out of sync with every other client because on his client the ranged unit attacked the melee unit while on all other clients the range unit still has not attacked the melee unit.