LITHUFFIN's dark spells 3.00

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

00:38, 17th Feb 2015
IcemanBo: http://www.hiveworkshop.com/forums/...-spells-3-00-a-256348/index2.html#post2654133

old

13:31, 5th Jan 2015
IcemanBo:
http://www.hiveworkshop.com/forums/...-spells-2-00-a-256348/index2.html#post2636166

 

[Tal'Rarity]

Taking first post, original thread is http://www.hiveworkshop.com/forums/spells-569/shadow-move-1-00-a-256330/

Will update this spell later when I have the time, still missing some configurable options and some other stuff such as improved timer event and movement functions.

Edit: Fixed variable naming and added more configurable options, just missing timer event and movement.

 

[GywGod133]

Can you explain to me why you put Wait 0.00 seconds?

Since the model used takes 5 seconds to destroy, you should minus whatever the duration is by five seconds in this wait here

You can do that in your loop
or can you try it remove Wait Action

 

[Tal'Rarity]

Can you explain to me why you put Wait 0.00 seconds?



You can do that in your loop
or can you try it remove Wait Action

The model used takes 5 seconds to destroy.

Do what in what loop? Sure I can remove the wait however what happens if someone wants a 8 second spell?

 

[Gismo359]

What he meant is create a trigger that runs every X seconds (prefferably 0.03125), and for every instance of the spell have a real getting increased by that X, and gets checked if the duration is reached.
Something about my sentence sounds really wrong but I'm not sure what

 

[Tal'Rarity]

That'd be more accurate, but that wasn't how the spell was made, and besides it only requires one trigger and uses less variables anyways.

 

[Gismo359]

But its not MUI when its like this, if 2 units cast the spell only one if the special effects will get destroyed and only one of the units will get nulled.

 

[Tal'Rarity]

Wrong, it is MUI as well everything is cleaned/nulled/destroyed.

Check the top of the trigger.

 

[Gismo359]

Wrong, it is MUI as well everything is cleaned/nulled/destroyed.

Check the top of the trigger.

Whoops, missed that.
Still using a loop would be best because waits are inaccurate. Wait 0.00 isnt actually 0 seconds but rather ~0.27 if I remember right.

 

[Tal'Rarity]

Whoops, missed that.
Still using a loop would be best because waits are inaccurate. Wait 0.00 isnt actually 0 seconds but rather ~0.27 if I remember right.

Yup agreed, I don't think it has an exact accurate number like 0.27 though.

 

[Gismo359]

Yup agreed, I don't think it has an exact accurate number like 0.27 though.

I remember reading something and that number has been in my head for weeks. It's ~0.20 for sure.
Either way, the wait gets even more inaccurate depending on the players ping, on the other hand PolledWait can bug out, although extremely rarely, and contunues countnig even when a player is lagging out I think.

 

[Wrda]

No one will cry because of an additional +0.05~0.27s. The wait here doesn't do any harm.
Both PooledWait and normal Wait continue counting when a player is lagging or when the game is paused. I don't think the wait gets more inaccurate depending on the players ping, but yes on the game delay.

 

[Meatmuffin]

No problem, I only started practicing with World Editor only like a ~month ago, and these were the only spells that I spent some time on. Since it wasn't MUI and it was buggy and stuff, I decided to remove it, and keep working on stuff. Anyways, thanks for updating B-)

 

[IcemanBo]

Some notes:

Dark Helper:

Create a config trigger, which should include:

-	Variable for DummyUnit
-	Variable for the spell's duration
-	Variable for the Special Effect

• Set TempUnit = (Triggering unit)
• Set TempPlayer = (Owner of TempUnit)
• Set TempPoint2 = (Position of TempUnit)

-->

• Set TempPlayer = (Triggering Player)
• Set TempPoint2 = (Position of (Triggering unit))

• Unit - Add a 5.00 second Generic expiration timer to (Last created unit)
• Unit - Order (Last created unit) to Move To TempPoint

^Use the temp unit variable to gain performance.

Why do you nulling "TempUnit"? In next cast it gets a new value again.
There is never a need to null players, doesn't matter they are global or local. They are constant and never get destroyed/removed.
Null the local effect in and of trigger.

Change the variable and object data names for an easy identification towards the spell: prefix_Name

Shadow Move:

• Set TS_Shadow_Move_TPL[TS_shadowindex] = (Owner of TS_Shadow_Move_TUOABC[TS_shadowindex])

-->
Set TS_Shadow_Move_TPL[TS_shadowindex] = (Triggering Player))

The ITE where you check to turn off the loop trigger should be moved into the deindex part.

"Invulnerable (Neutral)" should be binded to the spell custom spells, as it can cause bugs since the user also might add this ability to any unit without using this system.

• (Random integer number between 1 and 2) Equal to 1

^You can replace this by a boolean[index] which you always change between true/false to gain performance.
If true you create a special effect and set it "false". Else you just set it "true".

AttackType and DamageType should be configurable.

Other units may block the caster, so it will never reach the targeted unit. Fix this, please.

So variable names should be improved. A name should say something about the intention of the variable.
For example, I would never know what following variables should represent, if I would not see the input:

• Set TS_Shadow_Move_CU
• Set TS_Shadow_Move_TUOABC
• Set TS_Shadow_Move_TPL

There might be some more points, but this should be enough for next update.

 

[Tal'Rarity]

Replied to you in the quote.

Some notes:

Dark Helper:

Create a config trigger, which should include:

-	Variable for DummyUnit
- Nope. -	Variable for the spell's duration
- Easy enough to change so nope. -	Variable for the Special Effect
- Yet again there is no point.

• Set TempUnit = (Triggering unit)
• Set TempPlayer = (Owner of TempUnit)
• Set TempPoint2 = (Position of TempUnit)

-->

• Set TempPlayer = (Triggering Player)
• Set TempPoint2 = (Position of (Triggering unit))

• Unit - Add a 5.00 second Generic expiration timer to (Last created unit)
• Unit - Order (Last created unit) to Move To TempPoint

^Use the temp unit variable to gain performance.

Why do you nulling "TempUnit"? In next cast it gets a new value again.
There is never a need to null players, doesn't matter they are global or local. They are constant and never get destroyed/removed.
Null the local effect in and of trigger.

I feel better nulling players and it feels more proper.

Change the variable and object data names for an easy identification towards the spell: prefix_Name

Shadow Move:

• Set TS_Shadow_Move_TPL[TS_shadowindex] = (Owner of TS_Shadow_Move_TUOABC[TS_shadowindex])

-->
Set TS_Shadow_Move_TPL[TS_shadowindex] = (Triggering Player))

The ITE where you check to turn off the loop trigger should be moved into the deindex part.

Kay.

"Invulnerable (Neutral)" should be binded to the spell custom spells, as it can cause bugs since the user also might add this ability to any unit without using this system.

I don't get what you meant by this and it should never bug.

• (Random integer number between 1 and 2) Equal to 1

^You can replace this by a boolean[index] which you always change between true/false to gain performance.
If true you create a special effect and set it "false". Else you just set it "true".

Nope, that would be rather useless creating an extra variable....

AttackType and DamageType should be configurable.

Probably...

Other units may block the caster, so it will never reach the targeted unit. Fix this, please.

Just did, have to upload new version though still.

So variable names should be improved. A name should say something about the intention of the variable.
For example, I would never know what following variables should represent, if I would not see the input:

• Set TS_Shadow_Move_CU
• Set TS_Shadow_Move_TUOABC
• Set TS_Shadow_Move_TPL

There might be some more points, but this should be enough for next update.

Yeah... you can thank LITHUFFIN for the lovely naming.

I'll see what I can do about most of your points otherwise what I said nope to won't change.

 

[IcemanBo]

DarkHelper:

• Import instructions are missing.
• Make a short config trigger.
• No need of locals.
• I don't like the duration is hardcoded to 5 seconds. You are not independant from user's settings in gameplay constants. (duration of removing effects)
  You could make the "aim" visuals a unit for better controling, or just completly remove the effect.
• Your nullings are not needed.

The DarkHelper spell is too simple in my eyes. The most work is done in ObjectEditor. You only create a pre-edited unit and order it to move to a point with offset.
I don't know if it's worth to update it without enhancing the concept, as it's very simple at the moment. :/

ShadowMove:

• When units are between caster and target the spell fails. Fix this.
• In deindex part only remove the invulnerability ability if the unit did not have it before casting.
• Seperate the effect for caster and damage effect. User might want to differ them.
• Your If/Then/Else block where you check for target's invulnerability doesn't make sense.
  1. Collision of units does have nothing todo with invulnerability.
  2. Why do you remove invulnerability from target? The user obvisouly want the unit to be invulnerabile.
  3. You never add invulnerability to target again, even it was removed. -> Affecs gameplay in a negative way.
• Check for turning off the loop should be in deindex part.
• Damage- and attack type should be configurable.
• Add import instructions.

With these updates it's on a good way.

 

[IcemanBo]

Dark Helper

• You can see the peon icon, when dummy is not moving. Remove it.
• Make it support multiple levels.
• The dummy should be set in config part.
• Duration should be set in config part. (with support of level instanceability)
  Duration "5" is not 5 seconds as people might think but actually 5*interval. (0.031200)
  It should be duration in seconds. Also you might have wanted "0.0312500" as interval instead.
• No need to null player variables. If you want you can completly remove the player variable, as you only use it once.
  No performance is won with that.
• In loop you only remove units/effects and deindex them dynamicly.
  With a trick I believe you completly can remove the loop trigger.
  Instead of attaching effects to your dummy units, you can change the dummy model path to the effect.
  So yes, you would need an other dummy unit, as you currently use two different effects.
  But then when spell is casted, you only have to use the "Start expiration timer" for the dummy units with a certain duration,
  and it will kill the dummy (effects) automatically, without any kind of indexing/deindexing.
  Though you have to change the dummies' death type to "can't raise, won't decay",
  so they will be automatically removed from game after death.

ShadowMove

• Make it support multiple levels.
• Needs more configuration. All like damage/duration should be in config part.

• Set DatOriginallyInvulCheck[TS_shadowloop] = False

  ^This is not needed onDeindex.
• Still... What's about this invul add/remove to target thing? It seems strange to me. Why you damage invul units? How is it related to collison and to ownership?

The file's name is "Dat Shadow Move". Shadow Move is only one of two spells right now.
Also a version number would be helpful.

"JESP" is not correct under the field "category" in spell description.