Limit Number of Units per Building

[Spellbound]

Is there a way (or a system) to limit the number of units a building can train? I don't just mean raise the limit for every X number if the building, but each building can train a fixed amount of units.

Eg: Barracks being limited to 5 Footmen. If I have 3 Barracks, I will be able to have a total of 15 Footmen, but one Barracks can ONLY train 5 of them.

One way I tried doing it is to use Charge Gold and Lumber and enable unit --> order train --> disable unit, but I couldn't queue them up because a building can't cast abilities while it's training a unit.

Another way I tried doing it was to just order the unit to cancel the unit if it counts beyond 5, but that doesn't work:

function onTrainStart_Event takes nothing returns boolean
    
    local unit Source = GetTriggerUnit()
    local integer UnitType = GetTrainedUnitType()
    local integer id = 0
    
    if UnitType == 'vsd2' then
        set id = GetUnitUserData(Source)
        set MOD_AetherTendril_Count[id] = MOD_AetherTendril_Count[id] + 1
        if MOD_AetherTendril_Count[id] > 5 then
            call IssueImmediateOrderById(Source, 851976)
        endif
    endif
    
    return false
endfunction

//===========================================================================
function InitTrig_onTrainStart_Event takes nothing returns nothing
    set gg_trg_onTrainStart_Event = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ( gg_trg_onTrainStart_Event, EVENT_PLAYER_UNIT_TRAIN_START )
    call TriggerAddCondition( gg_trg_onTrainStart_Event, function onTrainStart_Event )
endfunction

Any thoughts?

 

[Ardenian]

Idea 1: Create a dummy unit for the unit train, add it to all buildings that can train the
unittype and set the charges to remaining to the amount available.
Items without/with zero charges being added to a building are removed automaticallly.

Idea 2: Create a dummy ability spawning the unittype, checking upon cast if the
maximum train available is reached.

Idea 3: Create a dummy unit as requirement to train the unit. If no more unit should be trained, remove it.
This way, you would already have a tooltip message why a unit cannot be trained.

As for your solution, orders cannot be interrupted this way.
The event fires before the order is actually issued, or something.
In this thread is a general solution: http://www.hiveworkshop.com/forums/.../re-add-amov-ability-stop-point-order-279199/

 

[Spellbound]

I'm not actually interrupting an order, I'm telling the building to do a cancel order, but it doesn't seem to work. I suppose it doesn't work because the order is being given before the unit is added to the queue? If so, that should be removing already queued up units :/

 

[Chaosy]

A simple solution (if I understand your request correctly) is to simply order the barrack to "cancel" when training more than 5 units. This will cancel the latest one.

 

[Spellbound]

That's what the code above is supposed to do, but nothing's being cancelled. I get my order ids here.

 public constant integer cancel=851976

 

[Chaosy]

In lack of better ideas, are you sure triggering unit works here?
Because the code seems pretty legit to me, except it should reduce the count by 1 when canceled.

 

[Spellbound]

Yeah GetTriggerUnit() should refer to the training building.
Also you pointing out triggering unit made me realise I forgot to null Source, so ty for that

EDIT: ok for some reason it's working now, but now the problem happens because EVENT_PLAYER_UNIT_TRAIN_START only fires when a unit is at the front of the queue, so queuing up units doesn't count up the integer variable that's supposed to order a cancel when the limit goes beyond 5. I tried with EVENT_PLAYER_UNIT_ISSUED_ORDER but I just hit the same problem as before with the queued up units refusing to get cancelled.