[General] Lightning doesn't move

[Aeroblyctos]

Hey,

So I got a little problem: boss' lightnings aren't moving. I think I've run to this problem before years ago but here I am once again. Help me!

Triggers:

Hidden

• Untitled Trigger 001
  • Events
    • Player - Player 1 (Red) types a chat message containing 1 as An exact match
  • Conditions
  • Actions
    • Trigger - Turn off (This trigger)
    • Set Boss_Event = True
    • Unit - Pause EPIC_BOSS
    • Animation - Play EPIC_BOSS's stand channel animation, using only Common animations
    • Wait 1.40 seconds
    • Set TempInteger = 0
    • Set EPIC_DrainC = 0
    • Set TempLoc = (Position of EPIC_BOSS)
    • Set TempGroup = (Units within 600.00 of TempLoc matching ((((Matching unit) is alive) Equal to True) and (((Owner of (Matching unit)) Equal to Player 1 (Red)) and ((Level of Invulnerable (Neutral) for (Matching unit)) Equal to 0))))
    • Unit Group - Pick every unit in TempGroup and do (Actions)
      • Loop - Actions
        • Set EPIC_DrainB[(Integer A)] = True
        • Set TempInteger = (TempInteger + 1)
        • Set EPIC_DrainC = (EPIC_DrainC + 1)
        • Set TempLoc2 = (Position of (Picked unit))
        • Set EPIC_DrainU[TempInteger] = (Picked unit)
        • Lightning - Create a Drain Life lightning effect from source TempLoc to target TempLoc2
        • Set EPIC_DrainL[TempInteger] = (Last created lightning effect)
        • Custom script: call RemoveLocation(udg_TempLoc2)
    • Custom script: call RemoveLocation(udg_TempLoc)
    • Trigger - Turn on Epic Demon SPELLS Drain MOVE <gen>
    • Trigger - Turn on Epic Demon SPELLS Drain DAMAGE <gen>
    • Wait 10.00 seconds
    • For each (Integer A) from 1 to EPIC_DrainC, do (Actions)
      • Loop - Actions
        • Lightning - Destroy EPIC_DrainL[(Integer A)]
    • Trigger - Turn off Epic Demon SPELLS Drain DAMAGE <gen>
    • Trigger - Turn off Epic Demon SPELLS Drain MOVE <gen>
    • Animation - Reset EPIC_BOSS's animation
    • Unit - Unpause EPIC_BOSS
    • Set Boss_Event = False
    • Wait 10.00 seconds
    • Trigger - Turn on (This trigger)

Hidden

• Epic Demon SPELLS Drain DAMAGE
  • Events
    • Time - Every 0.50 seconds of game time
  • Conditions
  • Actions
    • Set TempLoc = (Position of EPIC_BOSS)
    • For each (Integer A) from 1 to EPIC_DrainC, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • EPIC_DrainB[(Integer A)] Equal to True
          • Then - Actions
            • Set TempLoc2 = (Position of EPIC_DrainU[(Integer A)])
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Distance between TempLoc and TempLoc2) Greater than 800.00
              • Then - Actions
                • Set EPIC_DrainB[(Integer A)] = False
              • Else - Actions
                • Set TempReal = 25.00
                • Unit - Set life of EPIC_BOSS to ((Life of EPIC_BOSS) + TempReal)
                • Unit - Set life of EPIC_DrainU[(Integer A)] to ((Life of EPIC_DrainU[(Integer A)]) - TempReal)
            • Custom script: call RemoveLocation(udg_TempLoc2)
          • Else - Actions
    • Custom script: call RemoveLocation(udg_TempLoc)

Hidden

• Epic Demon SPELLS Drain MOVE
  • Events
    • Time - Every 0.05 seconds of game time
  • Conditions
  • Actions
    • Set TempLoc = (Position of EPIC_BOSS)
    • For each (Integer A) from 1 to EPIC_DrainC, do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • EPIC_DrainB[(Integer A)] Equal to True
          • Then - Actions
            • Set TempLoc2 = (Position of EPIC_DrainU[(Integer A)])
            • Lightning - Move EPIC_DrainL[(Integer A)] to source TempLoc and target TempLoc2
            • Custom script: call RemoveLocation(udg_TempLoc2)
          • Else - Actions
    • Custom script: call RemoveLocation(udg_TempLoc)

Test map attached. Rep for the helpers!

 

[deathismyfriend]

This is in the wrong forum. Should be in triggers and scripts.

Never use integer A / B. They are slower and less efficient than making a custom integer and using that for your looping.

In your unit group loop this is bad to have as integer A can be at any number. I believe that should be TempInteger not Integer A.

• Set EPIC_DrainB[(Integer A)] = True
• Set TempInteger = (TempInteger + 1)
• Set EPIC_DrainC = (EPIC_DrainC + 1)
• Set TempLoc2 = (Position of (Picked unit))
• Set EPIC_DrainU[TempInteger] = (Picked unit)
• Lightning - Create a Drain Life lightning effect from source TempLoc to target TempLoc2
• Set EPIC_DrainL[TempInteger] = (Last created lightning effect)
• Custom script: call RemoveLocation(udg_TempLoc2)

Waits are bad to use. You should use timers for better more accurate less buggy timing.

Put some debug messages in your trigger for moving the lightning to see if it is actually running.

You should also make sure that your units in this array are moving. EPIC_DrainU
If they aren't moving your lightning will never move.

 

[Aeroblyctos]

I didn't ask what is the most effective way to create code. I asked how to make this thing work / what's the actual problem.

If I remember right it's something about groups and loops... They don't work well together or something.

 

[Nichilus]

• Set EPIC_DrainB[(Integer A)] = True
• Set TempInteger = (TempInteger + 1)
• Set EPIC_DrainC = (EPIC_DrainC + 1)

should be:

• Set TempInteger = (TempInteger + 1)
• Set EPIC_DrainB[TempInteger] = True
• Set EPIC_DrainC = (EPIC_DrainC + 1)

Then it will work.

Also, I don't understand why you use both EPIC_DrainC and TempInteger instead of only using EPIC_DrainC.

 

[Aeroblyctos]

The thing works now.

Thanks a lot for your help guys.