[Trigger] Leakless?

[Nugamentum]

I just read the basic memory leak tutorial and tried to fix a spell of mine.

• Rotation
  • Ereignisse
    • Zeit - Every 0.01 seconds of game time
  • Bedingungen
  • Aktionen
    • Einheitengruppe - Pick every unit in (Units of type Chargeball [dummy]) and do (Actions)
      • Schleifen - Aktionen
        • Set Temp_Group = (Last created unit group)
        • Einheit - Set the custom value of (Picked unit) to ((Custom value of (Picked unit)) - 3)
        • Einheit - Move (Picked unit) instantly to ((Position of caster[(Player number of (Owner of (Picked unit)))]) offset by (Leben of (Picked unit)) towards (Real((Custom value of (Picked unit)))) degrees)
        • Custom script: call DestroyGroup( udg_Temp_Group )

Will it work as it should?

Thanks in advance
Nugamentum

 

[Marcelo Hossomi]

It still leaks a location when you use Position of caster[...].
Try setting this position to a variable, using the variable instead of that and then removing the location with RemoveLocation( udg_yourlocation )

Also, I don't know if that Temp_Group removes the leak. I'd suggest you to use set bj_wantDestroyGroup = true right before the "einheitengruppe" action xD

This will destroy the generated unit group.

 

[Vulcano]

• Untitled Trigger 001
  • Events
    • Time - Every 0.01 seconds of game time
  • Conditions
  • Actions
    • Set tempGroup = (Units of type Blood Mage)
    • Unit Group - Pick every unit in tempGroup and do (Actions)
      • Loop - Actions
        • Unit - Set the custom value of (Picked unit) to ((Custom value of (Picked unit)) - 3)
        • Set tempPoint = (Position of (Triggering unit))
        • Unit - Move (Picked unit) instantly to tempPoint, facing (Real((Custom value of (Picked unit))) degrees
        • Custom script: call RemoveLocation(udg_tempPoint)
    • Custom script: call DestroyGroup( udg_tempGroup )

i think this has less leaks then your trigger

 

[Nugamentum]

right before the "einheitengruppe" action xD

Sorry for that It's the german version of the game

Thanks for the suggestions

My final Trigger now looks like this:

• Rotation
  • Ereignisse
    • Zeit - Every 0.01 seconds of game time
  • Bedingungen
  • Aktionen
    • Set Temp_Group = (Units of type Chargeball [dummy])
    • Einheitengruppe - Pick every unit in Temp_Group and do (Actions)
      • Schleifen - Aktionen
        • Einheit - Set the custom value of (Picked unit) to ((Custom value of (Picked unit)) - 3)
        • Set Temp_Point = (Position of caster[(Player number of (Owner of (Picked unit)))])
        • Einheit - Move (Picked unit) instantly to (Temp_Point offset by (Leben of (Picked unit)) towards (Real((Custom value of (Picked unit)))) degrees)
        • Custom script: call RemoveLocation(udg_Temp_Point)
    • Custom script: call DestroyGroup( udg_Temp_Group)

 

[Vulcano]

Did your first trigger actually work? since you destroy your group while still looping actions over picked units.

 

[Nugamentum]

I am sorry but I don't know. I changed the Trigger so often that i do not remember if this constellation worked out.

 

[Element of Water]

For god's sake, last created unit group only works when you create a unit group. It doesn't work with pick every unit in group...

 

[Nugamentum]

But everything works fine

 

[Marcelo Hossomi]

It's a complex way to do something so simple.
The "pick every unit" action destroys the group it creates inside it's code if set bj_wantDestroyGroup = true is used right before it. So, why bother creating a new unit group if it will be destroyed after being used?

 

[wyrmlord]

You're still leaking a location. (Temp_Point offset by (Leben of (Picked unit)) towards (Real((Custom value of (Picked unit)))) degrees) is the location that you are not removing in your trigger. In your case, you will need 2 location variables total to handle all the location leaks in the trigger.

 

[Nugamentum]

It's a complex way to do something so simple.
The "pick every unit" action destroys the group it creates inside it's code if set bj_wantDestroyGroup = true is used right before it. So, why bother creating a new unit group if it will be destroyed after being used?

I tryed it but it did not worked the chargeball dummy did not rotated around the caster, i dont know why

You're still leaking a location. (Temp_Point offset by (Leben of (Picked unit)) towards (Real((Custom value of (Picked unit)))) degrees) is the location that you are not removing in your trigger. In your case, you will need 2 location variables total to handle all the location leaks in the trigger.

Yes your're gonna change this