[Trigger] leak

Just_Spectating · Dec 20, 2007

i know theres a leak but how do i fix it?

Gyrocopter atk1
- Events
  - Time - Every 0.05 seconds of game time
- Conditions
- Actions
  - For each (Integer A) from 0 to 15, do (Actions)
    - Loop - Actions
      - Unit - Move Attack[(Integer A)] instantly to ((Position of Attack[(Integer A)]) offset by 20.00 towards (Facing of Attack[(Integer A)]) degrees)

GhostWolf · Dec 20, 2007

Put this instead in the loop

Set Point[0] = position of Attack[Integer[A]]
Set Point[1] = Point[1] offset by 20 towards facing of Attack[Integer[A]]
Move Attack[Integer[A]] instantly to Point[2]
Custom Script: call RemoveLocation(udg_Point[0])
Custom Script: call RemoveLocation(udg_Point[1])

Just_Spectating · Dec 20, 2007

heres the thing, there is more than one attack. since i dont know Jass, this is my form of MUI

it is a bullet system. it all works, just need to fix the leak.

and i still think ur trigger leaks.

GhostWolf · Dec 20, 2007

Why would it leak ?
There are 2 points here, the point of the bullet, and the point the bullet is going to be in.
I set them both into variables and then removed.

By the way, there is exacly this example in the "Things That Leak" sticky thread.

Just_Spectating · Dec 20, 2007

it leaks because "Attack[array]" Wont always be in the map. and i cant turn on the trigger everytime you use it because you are able to use it multiple times at once.

GhostWolf · Dec 20, 2007

Then its not my triggers problem, its yours.

And you mentioned the unit can be outside the map.
If you move instantly a unit outside of the game playable area warcraft will automaticly crush (trust me, I did it by mistake

).

Just_Spectating · Dec 20, 2007

no, it will be in the map if you activate it. but if ther is no unit "attack" then it leaks.

GhostWolf · Dec 20, 2007

First of all it won't leak, it will just make locations and remove them.

And second thing, you can make a condition checking that there are more then 0 units of that type in the playable area.

Just_Spectating · Dec 20, 2007

it doesnt leak? it seems like it does. ok thanks for the info

GhostWolf · Dec 20, 2007

If you create a location and then immidietly remove it there is no reason it will leak.

Jacek · Dec 20, 2007

stop trusting Leak Checker... this tool doesn't catch all leaks anyway

WildField · Dec 20, 2007

Try to use this function
Put This in the beggining of the map.

JASS:

function moveunit takes unit u, real facing returns nothing
    local real X = GetUnitX(u)+Cos(facing*0.0174)*20
    local real Y = GetUnitY(u)+Sin(facing*0.0174)*20
    call SetUnitPosition(u, X, Y)
    call SetUnitFacing(u, facing)
endfunction

Then put in your trigger this action

Custom Script: call moveunit(udg_Attack[GetForLoopIndexA()],GetUnitFacing(udg_Attack[GetForLoopIndexA()])

Just_Spectating · Dec 20, 2007

guys, i made it all ok, its MUI and GUI and idk about leaks but when i test it doesnt lag.

GhostWolf · Dec 20, 2007

So, how you made it at the end ?

Just_Spectating · Dec 20, 2007

well i would have to post 3 triggers, I KNOW it leaks, i bet. but it doesnt lag. at least i think. It is a lame MUI technique i know...

Gyrocopter
- Events
  - Unit - A unit Starts the effect of an ability
- Conditions
  - (Ability being cast) Equal to Attack Gyrocopter
- Actions
  - Unit - Create 1 Gyrocopter attack1 for (Owner of (Triggering unit)) at ((Position of (Triggering unit)) offset by 100.00 towards (Facing of (Triggering unit)) degrees) facing ((Facing of (Triggering unit)) + (Random real number between -15.00 and 15.00)) degrees
  - Unit Group - Add (Last created unit) to Attack1
  - Set NumberG = (NumberG + 1)
  - Set AttackG[NumberG] = (Last created unit)
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - NumberG Greater than or equal to 15
    - Then - Actions
      - Set NumberG = 0
    - Else - Actions

Gyrocopter atk1
- Events
  - Time - Every 0.05 seconds of game time
- Conditions
- Actions
  - Unit Group - Pick every unit in Attack1 and do (Actions)
    - Loop - Actions
      - Unit - Move (Picked unit) instantly to ((Position of (Picked unit)) offset by 25.00 towards (Facing of (Picked unit)) degrees)
  - For each (Integer A) from 0 to 15, do (Actions)
    - Loop - Actions
      - Custom script: set bj_wantDestroyGroup = true
      - Unit Group - Pick every unit in (Units in (Playable map area) matching (((Distance between (Position of AttackG[(Integer A)]) and (Position of (Matching unit))) Less than or equal to 50.00) and ((Owner of (Matching unit)) Not equal to (Owner of AttackG[(Integer A)])))) and do (Actions)
        
        Loop - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (Distance between (Position of AttackG[(Integer A)]) and (Position of (Picked unit))) Less than or equal to 50.00
        
        Then - Actions
        
        Unit - Kill AttackG[(Integer A)]
        
        Else - Actions

Remove group
- Events
  - Unit - A unit Dies
- Conditions
- Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Unit-type of (Triggering unit)) Equal to Gyrocopter attack1
    - Then - Actions
      - Unit Group - Remove (Triggering unit) from Attack1
    - Else - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (Unit-type of (Triggering unit)) Equal to BatRider attack1
        
        Then - Actions
        
        Unit Group - Remove (Triggering unit) from Attack2
        
        Else - Actions

GhostWolf · Dec 20, 2007

You still have point leaks there (at the "create unit at..." for example)

Just_Spectating · Dec 21, 2007

ok thanks, i redid some things and now it doesnt lag!

before it actually did.. alot!

Gyrocopter
- Events
  - Unit - A unit Starts the effect of an ability
- Conditions
  - (Ability being cast) Equal to Attack Gyrocopter
- Actions
  - Set Attackpos1 = (Position of (Triggering unit))
  - Unit - Create 1 Gyrocopter attack1 for (Owner of (Triggering unit)) at (Attackpos1 offset by 100.00 towards (Facing of (Triggering unit)) degrees) facing ((Facing of (Triggering unit)) + (Random real number between -15.00 and 15.00)) degrees
  - Custom script: call RemoveLocation(udg_Attackpos1)
  - Unit Group - Add (Last created unit) to Attack1
  - Set NumberG = (NumberG + 1)
  - Set AttackG[NumberG] = (Last created unit)
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - NumberG Greater than or equal to 15
    - Then - Actions
      - Set NumberG = 0
    - Else - Actions

Gyrocopter atk1
- Events
  - Time - Every 0.05 seconds of game time
- Conditions
  - (Number of units in Attack1) Greater than or equal to 1
- Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Number of units in Attack1) Greater than or equal to 1
    - Then - Actions
      - Unit Group - Pick every unit in Attack1 and do (Actions)
        
        Loop - Actions
        
        Unit - Move (Picked unit) instantly to ((Position of (Picked unit)) offset by 25.00 towards (Facing of (Picked unit)) degrees)
      - For each (Integer A) from 0 to 15, do (Actions)
        
        Loop - Actions
        
        Custom script: set bj_wantDestroyGroup = true
        
        Unit Group - Pick every unit in (Units in (Playable map area) matching (((Distance between (Position of AttackG[(Integer A)]) and (Position of (Matching unit))) Less than or equal to 50.00) and ((Owner of (Matching unit)) Not equal to (Owner of AttackG[(Integer A)])))) and do (Actions)
        
        Loop - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (Distance between (Position of AttackG[(Integer A)]) and (Position of (Picked unit))) Less than or equal to 50.00
        
        Then - Actions
        
        Unit - Kill AttackG[(Integer A)]
        
        Else - Actions
    - Else - Actions

Remove group
- Events
  - Unit - A unit Dies
- Conditions
- Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Unit-type of (Triggering unit)) Equal to Gyrocopter attack1
    - Then - Actions
      - Unit Group - Remove (Triggering unit) from Attack1
    - Else - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (Unit-type of (Triggering unit)) Equal to BatRider attack1
        
        Then - Actions
        
        Unit Group - Remove (Triggering unit) from Attack2
        
        Else - Actions

GhostWolf · Dec 21, 2007

Sorry, but it still leaks ^^
You would need to create a point offset by 100 from Attackpos1 and then move the unit there.

Just_Spectating · Dec 22, 2007

ok so make another variable that equals 100 offset from Attackpos1?

GhostWolf · Dec 22, 2007

Yes.
Whenever you use a point you should set it to a point variable and then remove it.
Whenever you make a point that is based on another point you should set BOTH points to a variable.
Its as simple as that

Just_Spectating · Dec 23, 2007

i tried it and it didnt work MUI...

if i shoot 2 bullets then it screws up and goes crazy...

also, that isnt the part that lags.. its the second part. the "integer A 0-15" part.

GhostWolf · Dec 23, 2007

I guess thats because again you use a "position of ...".
And by the way you don't need that condition there because you already pick the units that are only 50 from the bullet.

Just_Spectating · Dec 24, 2007

it still wont work MUI without redoing the whole trigger...

TKF · Dec 25, 2007

Ironically, I have about the same issue. The point stores only 1 point, not for all bullets at same time...

[Trigger] leak

Similar threads