lag issues

n00b · Sep 16, 2009

yeah so, i've been having this problem with my map:
playing it for about 30 minutes, my fps gradually drops to 0.1
then eventually, the game crashes saying something along the lines of
"not enough memory process this command"

also, please dont start spamming Things That Leak-type threads, ive read most of them all and they did help me deleak a lot of crap... but the problem still persists. so yeah, i really can't find a way to fix this, maybe it would help me (somewhat) if you would just list random crap that lags maps (getting pretty desperate here)

random triggers (some slightly edited lol):
also my bad if these triggers are tl;dr and/or bad examples, im just throwing out random things i suspect to be the things lagging the game

cinematic thing
- Events
  - Unit - A unit enters cutscene4 <gen>
- Conditions
  - (Unit-type of (Triggering unit)) Equal to Footman
- Actions
  - Trigger - Turn off (This trigger)
  - Trigger - Turn off trap3 <gen>
  - Trigger - Turn on stomp knockback <gen>
  - Cinematic - Turn cinematic mode On for (All players)
  - Cinematic - Fade out and back in over 4.00 seconds using texture White Mask and color (0.00%, 0.00%, 0.00%) with 0.00% transparency
  - Wait 1.85 seconds
  - Set temp_loc[1] = (Center of misc11 <gen>)
  - Set temp_loc[2] = (Center of misc11a <gen>)
  - Set temp_loc[3] = (Center of misc11b <gen>)
  - Set temp_loc[4] = (Center of misc11c <gen>)
  - Set temp_loc[5] = (Center of misc11d <gen>)
  - Set temp_loc[6] = (Center of misc11e <gen>)
  - Set temp_loc[7] = (Center of misc11f <gen>)
  - Set temp_loc[8] = (Center of misc11g <gen>)
  - For each (Integer A) from 1 to 8, do (Actions)
    - Loop - Actions
      - Hero - Instantly revive player_hero[(Integer A)] at temp_loc[(Integer A)], Hide revival graphics
      - Unit - Move player_hero[(Integer A)] instantly to temp_loc[(Integer A)]
      - Unit - Make player_hero[(Integer A)] face The Fucking Captain 0078 <gen> over 0.00 seconds
      - Custom script: call RemoveLocation(udg_temp_loc[GetForLoopIndexA()])
  - Player Group - Pick every player in (All players) and do (Actions)
    - Loop - Actions
      - Camera - Apply Camera 023 <gen> for (Picked player) over 0.00 seconds
      - Camera - Apply Camera 024 <gen> for (Picked player) over 2.00 seconds
  - Wait 2.00 seconds
  - Game - Display to (All players) the text: (player_color_string[4] + ((Name of Player 4 (Purple)) + (:|r + blah)))
  - Wait 0.60 seconds
  - Game - Display to (All players) the text: (player_color_string[4] + ((Name of Player 4 (Purple)) + (:|r + you dont need to read)))
  - Wait 1.20 seconds
  - Player Group - Pick every player in (All players) and do (Actions)
    - Loop - Actions
      - Camera - Apply Camera 025 <gen> for (Picked player) over 0.00 seconds
  - Game - Display to (All players) the text: |cff106246A person...
  - Wait 0.70 seconds
  - Game - Display to (All players) the text: (player_color_string[4] + ((Name of Player 4 (Purple)) + (:|r + blah blah blah)))
  - Wait 2.00 seconds
  - Game - Display to (All players) the text: |cff106246A person...
  - Wait 1.20 seconds
  - Game - Display to (All players) the text: |cff106246A person...
  - Wait 1.20 seconds
  - Player Group - Pick every player in (All players) and do (Actions)
    - Loop - Actions
      - Camera - Apply Camera 024 <gen> for (Picked player) over 0.00 seconds
  - Game - Display to (All players) the text: (player_color_string[1] + ((Name of Player 1 (Red)) + (:|r + blah blah)))
  - Wait 2.00 seconds
  - Game - Display to (All players) the text: (player_color_string[5] + ((Name of Player 5 (Yellow)) + (:|r + ((Name of Player 4 (Purple)) + ....... wtf.))))
  - Wait 0.30 seconds
  - Game - Display to (All players) the text: (|cff106246A Person:|r + uhh ok)
  - Wait 2.00 seconds
  - Trigger - Turn on stomp <gen>
  - Trigger - Turn on summon <gen>
  - Destructible - Close Iron Gate (Vertical) 0840 <gen>
  - Cinematic - Turn cinematic mode Off for (All players)
  - Player Group - Pick every player in (All players) and do (Actions)
    - Loop - Actions
      - Camera - Reset camera for (Picked player) to standard game-view over 0.00 seconds
  - Trigger - Turn on fallout1 <gen>
  - Custom script: call DestroyTrigger(GetTriggeringTrigger())

trigger for moving arrow projectiles
- Events
  - Time - Every 0.02 seconds of game time
- Conditions
- Actions
  - For each (Integer firearrow_int) from 1 to 8, do (Actions)
    - Loop - Actions
      - Set firearrow_temploc[firearrow_int] = (Position of firearrow_unit[firearrow_int])
      - Set firearrow_temploc2[firearrow_int] = (firearrow_temploc[firearrow_int] offset by 30.00 towards (Facing of firearrow_unit[firearrow_int]) degrees)
      - Unit - Move firearrow_unit[firearrow_int] instantly to firearrow_temploc2[firearrow_int]
      - Custom script: set bj_wantDestroyGroup = true
      - Unit Group - Pick every unit in (Units within 100.00 of firearrow_temploc2[firearrow_int]) and do (Actions)
        
        Loop - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        pvp_boolean Equal to True
        
        Then - Actions
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        ((Picked unit) is alive) Equal to True
        
        (Picked unit) Not equal to player_hero[firearrow_int]
        
        (Picked unit) Not equal to firearrow_unit[firearrow_int]
        
        Then - Actions
        
        Set faunit_temploc2[1] = (Position of (Picked unit))
        
        Set temp_loc[1] = (Position of (Picked unit))
        
        Unit - Cause player_hero[firearrow_int] to damage circular area after 0.00 seconds of radius 110.00 at temp_loc[1], dealing ((Distance between faunit_temploc[firearrow_int] and faunit_temploc2[1]) / 30.00) damage of attack type Normal and damage type Normal
        
        Unit - Kill firearrow_unit[firearrow_int]
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        flamearrow_boolean[firearrow_int] Equal to True
        
        Then - Actions
        
        Unit - Cause player_hero[firearrow_int] to damage circular area after 0.00 seconds of radius 110.00 at temp_loc[1], dealing 10.00 damage of attack type Normal and damage type Normal
        
        Else - Actions
        
        Unit - Cause player_hero[firearrow_int] to damage circular area after 0.00 seconds of radius 110.00 at temp_loc[1], dealing 1.00 damage of attack type Normal and damage type Normal
        
        Custom script: set udg_firearrow_unit[udg_firearrow_int] = null
        
        Custom script: set udg_firearrow_csunit[udg_firearrow_int] = null
        
        Custom script: call RemoveLocation(udg_temp_loc[GetConvertedPlayerId(GetOwningPlayer(GetTriggerUnit()))])
        
        Custom script: call RemoveLocation(udg_faunit_temploc[GetConvertedPlayerId(GetOwningPlayer(GetTriggerUnit()))])
        
        Custom script: call RemoveLocation(udg_faunit_temploc2[1])
        
        Custom script: call RemoveLocation(udg_temp_loc[1])
        
        Else - Actions
      - Custom script: call RemoveLocation(udg_firearrow_temploc[udg_firearrow_int])
      - Custom script: call RemoveLocation(udg_firearrow_temploc2[udg_firearrow_int])

trigger that knocks back units
- Events
  - Time - Every 0.07 seconds of game time
- Conditions
- Actions
  - For each (Integer tfc_kb_loopint) from 1 to 8, do (Actions)
    - Loop - Actions
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        tfc_kb_boolean[tfc_kb_loopint] Equal to True
        
        Then - Actions
        
        Unit - Set the custom value of player_hero[tfc_kb_loopint] to ((Custom value of player_hero[tfc_kb_loopint]) - 1)
        
        Set tfc_kb_temploc2[tfc_kb_loopint] = (Position of player_hero[tfc_kb_loopint])
        
        Set tfc_kb_temploc[(Player number of (Owner of player_hero[tfc_kb_loopint]))] = (tfc_kb_temploc2[tfc_kb_loopint] offset by ((Real((Custom value of player_hero[tfc_kb_loopint]))) x 15.00) towards ((Facing of player_hero[tfc_kb_loopint]) - 180.00) degrees)
        
        Unit - Move player_hero[tfc_kb_loopint] instantly to tfc_kb_temploc[(Player number of (Owner of player_hero[tfc_kb_loopint]))]
        
        Special Effect - Create a special effect attached to the origin of player_hero[tfc_kb_loopint] using Objects\Spawnmodels\Undead\ImpaleTargetDust\ImpaleTargetDust.mdl
        
        Special Effect - Destroy (Last created special effect)
        
        Custom script: call RemoveLocation(udg_tfc_kb_temploc[udg_tfc_kb_loopint])
        
        Custom script: call RemoveLocation(udg_tfc_kb_temploc2[udg_tfc_kb_loopint])
        
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        (Custom value of player_hero[tfc_kb_loopint]) Less than or equal to 0
        
        Then - Actions
        
        Set tfc_kb_boolean[tfc_kb_loopint] = False
        
        Else - Actions
        
        Else - Actions

kills stuff in a line
- Events
  - Time - Every 10.00 seconds of game time
- Conditions
- Actions
  - For each (Integer trap_int) from 1 to 19, do (Actions)
    - Loop - Actions
      - Set temp_loc[99] = (Position of Guard Tower 0073 <gen>)
      - Set temp_loc[100] = (temp_loc[99] offset by (150.00 x (Real(trap3_int))) towards 360.00 degrees)
      - Special Effect - Create a special effect at temp_loc[100] using Abilities\Spells\Orc\WarStomp\WarStompCaster.mdl
      - Special Effect - Destroy (Last created special effect)
      - Unit - Cause Guard Tower 0073 <gen> to damage circular area after 0.00 seconds of radius 200.00 at temp_loc[100], dealing 9999999.00 damage of attack type Normal and damage type Normal
      - Custom script: call RemoveLocation(udg_temp_loc[100])
      - Custom script: call RemoveLocation(udg_temp_loc[99])
      - Wait 0.01 seconds

trigger for equipping weapons (also dont mind the "unit[1] = trigger unit" thing)
- Events
  - Unit - A unit Uses an item
- Conditions
  - (Item-class of (Item being manipulated)) Equal to Permanent
- Actions
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - equipprimary_boolean[(Player number of (Owner of (Triggering unit)))] Equal to True
    - Then - Actions
      - Wait 0.01 seconds
      - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
        
        If - Conditions
        
        equipprimary_boolean[(Player number of (Owner of (Triggering unit)))] Equal to False
        
        Then - Actions
        
        Else - Actions
        
        Game - Display to (Player group((Owner of (Triggering unit)))) the text: (|cff808080You are already wielding a|r |cffffcc00 + ((Name of equippedprimary_item[(Player number of (Owner of unit[1]))]) + |r))
      - Skip remaining actions
    - Else - Actions
  - For each (Integer A) from 1 to 999, do (Actions)
    - Loop - Actions
      - Set unit[1] = (Triggering unit)
      - Unit - Remove itemprimary_ability[(Integer A)] from unit[1]
      - Custom script: set udg_unit[1] = null
  - If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    - If - Conditions
      - (Item-type of (Item being manipulated)) Equal to Sword
    - Then - Actions
      - Set unit[1] = (Triggering unit)
      - Special Effect - Create a special effect attached to the hand left of unit[1] using Abilities\Spells\Orc\Disenchant\DisenchantSpecialArt.mdl
      - Special Effect - Destroy (Last created special effect)
      - Set equippedprimary_item[(Player number of (Owner of (Triggering unit)))] = (Item being manipulated)
      - Unit - Add Item Damage Bonus (+11) (Sword) to unit[1]
      - Unit - Add Lacerate (Sword) to unit[1]
      - Item - Make (Item being manipulated) Undroppable
      - Game - Set ally color filtering to 2
      - Game - Set ally color filtering to 0
      - Custom script: set udg_unit[1] = null
      - Wait 0.01 seconds
      - Set equipprimary_boolean[(Player number of (Owner of (Triggering unit)))] = True
    - Else - Actions

Baintastic · Sep 16, 2009

Triggering unit does NOT leak. It is a global variable. Leaking occurs when you allocate memory that is never reallocated when it ceases to be used. Local variables need to be cleaned up properly.

You may have to be more specific about what is in your map before people can help you.

If i had to guess, i would say that you are making units that aren't being removed from the game. Every time you map a dummy unit, make sure you add and expiration timer to it so it cleans up properly.

Hope this helps. I can offer more help if you can give more information.

n00b · Sep 16, 2009

yeah sorry for the lack of info, probably going to add some triggers in my map later

Baintastic · Sep 16, 2009

do you use any JASS in your map or is it all through the Graphical User Interface?

reason 3 · Sep 16, 2009

Both GUI and Jass can create lag issues if you use them wrong.I actually imported once a trigger in GUI that made my map ...Unplayable due to lag :/.Maybe you have imported any pre-made triggers?You should check them!

n00b · Sep 16, 2009

Baintastic said:
do you use any JASS in your map or is it all through the Graphical User Interface?

only GUI, JASS for destroying points and crap

reason 3 said:
Maybe you have imported any pre-made triggers?You should check them!

nope

also, going to add some triggers soon, i guess

reason 3 · Sep 16, 2009

A simple way to find out which triggers make your map lag,is deleting them one by one and test the map.I mean make a copy of your map,test it -> result lag,delete 1 trigger,test map -> result lag?keep doing this until you find out which triggers cause the problem...you will notice it since your map will be normal again i guess.

n00b · Sep 16, 2009

reason 3 said:
A simple way to find out which triggers make your map lag,is deleting them one by one and test the map.I mean make a copy of your map,test it -> result lag,delete 1 trigger,test map -> result lag?keep doing this until you find out which triggers cause the problem...you will notice it since your map will be normal again i guess.

kind of a hard thing to do, ive got a ton of triggers in this map...

reason 3 · Sep 16, 2009

Hmmm...Can't think of something else,except if you want to post the map/or triggers here and we can check them.

wolfman · Sep 16, 2009

Try removing all dummy units from the game.

Unit dies
Or any conditions are true
. Unit type of triggering unit is Dummy1
. Unit type of triggering unit is Dummy2
wait .8 seconds
Remove triggering unit from game

Do the wait so you still see its death animation

sadvisor · Sep 17, 2009

maybe youțre missing somethig.

Try "Leak Check"

lag issues

n00b

n00b

Resources

Baintastic

Baintastic

Resources

n00b

n00b

Resources

Baintastic

Baintastic

Resources

reason 3

reason 3

Resources

n00b

n00b

Resources

reason 3

reason 3

Resources

n00b

n00b

Resources

reason 3

reason 3

Resources

wolfman

wolfman

Resources

sadvisor

sadvisor

Similar threads