Kinetic Orb [v1.2c]

[Moderator]

Approved

Suggested changes

• Add some follow through time
• Rename Map Initialisation trigger to something like Kinetic Orb init
• Remove visibility modifying actions from Map Initialisation trigger
• There's an unneeded Custom script: call RemoveLocation (udg_tempPoint)
  in the THEN in Kinetic Orb trigger
• Use the ability variable in Set tempReal = (Real((Level of Kinetic Orb for KO_caster[KO_index2])))
  and in Set tempInteger = (Level of Kinetic Orb for tempUnit)
• Add "destroys trees" boolean tree destroy range real variable

 

[Magtheridon96]

First of all, congratulations for being one of the very few people who actually cache data into temp variables :3
The triggers are almost perfect (For GUI)
There are still a few speedfreak improvements, but those don't matter at all
Good job.
The eye-candy is great too.
5/5

 

[Jay the Editor]

Thanks a lot, Magtheridon96
For some weird reason, the dummy automatically set its height if I put a model for it at certain location. So, I triggered it but it still looks good

 

[Pod]

Approved !

 

[Cokemonkey11]

Hey there! The spell looks quite nice in game. I've made a video of it in action for you for users who are curious but don't want to spend the time downloading it themselves.

http://www.xfire.com/video/55ae5e/

Sorry for the music, I didn't realize xfire would record external sound.


In Review -

You should either make a better test map, or use a test map template. Both are good options. I dislike your test map because:

* Your 3 pre-placed heroes always fight with creeps
* There is no fast way to level up your hero
* There is no way to reset your hero's health/mana
* There is no way to reset creeps
* The Fog Mask is enabled

Here are examples of templates -
http://www.thehelper.net/forums/showthread.php/65846-Spell-Test-Map-Templates
http://www.hiveworkshop.com/forums/spells-569/redscores-spell-template-v1-02-a-110386/

Your Object Data:
* You did something that looks quite nice with 1 dummy unit! Very nice. Ideally however, you should attach the correct effects and stats to a standard dummy (dummy.mdx by Vexorian - see xe http://www.wc3c.net/showthread.php?t=101150)
* You should make a note that you've also imported a custom BTN

Triggering:
* You programmed a linear stack in GUI! I'm impressed, but also disappointed because it's GUI.
* It's very concise and, from what I can tell, doesn't leak.


Overall: You should learn vJass so you can make this without locations or public globals. But other than that your spell is simply too good to not give you at least 4/5.

 

[Jay the Editor]

Hey there! The spell looks quite nice in game. I've made a video of it in action for you for users who are curious but don't want to spend the time downloading it themselves.

http://www.xfire.com/video/55ae5e/

Sorry for the music, I didn't realize xfire would record external sound.

Thanks for that I'll update my description later on. I never thought of till such extent because it's just a spell anyway. And, I'm don't know how to make it. haha.. )

You should either make a better test map, or use a test map template. Both are good options. I dislike your test map because:

* Your 3 pre-placed heroes always fight with creeps
* There is no fast way to level up your hero
* There is no way to reset your hero's health/mana
* There is no way to reset creeps
* The Fog Mask is enabled

I'll fix that up for the 1st and 2nd comment and the 5th comment too.
The hero's health and mana is reaching a values that I don't think it will reach 0 by just receiving damage from the creeps unless you're going to test it for an hour or more.
I don't know how to reset creeps

Your Object Data:
* You did something that looks quite nice with 1 dummy unit! Very nice. Ideally however, you should attach the correct effects and stats to a standard dummy (dummy.mdx by Vexorian - see xe http://www.wc3c.net/showthread.php?t=101150)
* You should make a note that you've also imported a custom BTN

I'll take a look on it later on how's the stats of a standard dummy.
Yes, thank you. I'll make a note later on. Thanks for reminding that.

Triggering:
* You programmed a linear stack in GUI! I'm impressed, but also disappointed because it's GUI.
* It's very concise and, from what I can tell, doesn't leak.

I use triggering because I don't know anything about Jass/vJass scripts and I afraid spending my time in learning the scripts might consumes a lot of time. I now just got my result of public examination and preparing to further my studies. I always take these kind of editing as a pastime and never intend to master it.

 

[Cokemonkey11]

Thanks for that I'll update my description later on. I never thought of till such extent because it's just a spell anyway. And, I'm don't know how to make it. haha.. )

I also don't know how to make a good one Try xfire video recorder though, it's literally that easy.

By the way it's not necessary to make a video of your spell if you don't want to. I just did it to be helpful.

I'll fix that up for the 1st and 2nd comment and the 5th comment too.
The hero's health and mana is reaching a values that I don't think it will reach 0 by just receiving damage from the creeps unless you're going to test it for an hour or more.
I don't know how to reset creeps

The 1st 2nd and 5th should be the most important ones anyway ^^

I use triggering because I don't know anything about Jass/vJass scripts and I afraid spending my time in learning the scripts might consumes a lot of time. I now just got my result of public examination and preparing to further my studies. I always take these kind of editing as a pastime and never intend to master it.

I'm in the same boat as you. I used to be adamant about sticking to GUI forever but after nearly 7 years of doing this as a past time, I finally decided to try out JASS and see what all the fuss is about, and I regret having waited so long. I'd be more than happy to teach you if you're interested to learn.

Otherwise, congrats again on the spell.

 

[Jay the Editor]

I'm in the same boat as you. I used to be adamant about sticking to GUI forever but after nearly 7 years of doing this as a past time, I finally decided to try out JASS and see what all the fuss is about, and I regret having waited so long. I'd be more than happy to teach you if you're interested to learn.

But what's the difference between GUI and Jass? It's only about efficiency, isn't it?

 

[Cokemonkey11]

But what's the difference between GUI and Jass? It's only about efficiency, isn't it?

Efficient in many ways, yes. More efficient at the script end, more efficient for the programmer, more efficient for the reader, and more efficient when one wants to modify code.

There are additionally plenty of things that GUI simply can't do.

vJass let's you keep things modular and aesthetically pleasing - that's the important bit.

 

[Alain.Mark]

I spammed the spell by casting one after the other, and after that the kinetic orb would still move but its effects won't activate. :O

 

[Jay the Editor]

Efficient in many ways, yes. More efficient at the script end, more efficient for the programmer, more efficient for the reader, and more efficient when one wants to modify code.

There are additionally plenty of things that GUI simply can't do.

vJass let's you keep things modular and aesthetically pleasing - that's the important bit.

I see. I'll try to dig up some time to learn about it bit by bit. My ideas currently still can be created through GUI and it will be boring if I would to search one-by-one of the Jass scripts on how to write it instead of using GUI. haha..

I spammed the spell by casting one after the other, and after that the kinetic orb would still move but its effects won't activate. :O

Probably because there are no any nearby heroes that are not being pulled. It detects only hero that is NOT being pulled within a range. The range can be adjust through KO_pulledAoE in "Kinetic Orb" trigger, under "Configurable" section.

 

[Alain.Mark]

I already tried that, it doesn't work and it doesn't even deal damage. :O

edit: I thought this should deal damage to non-hero units. sorry for that. :|

 

[Jay the Editor]

I already tried that, it doesn't work and it doesn't even deal damage. :O

edit: I thought this should deal damage to non-hero units. sorry for that. :|

No prob If you wanna make it to detect units too. You can try edit the condition in the loop trigger under "Functional triggers" section. This line:

• Unit Group - Pick every unit in (Units within KO_pullAoE[KO_index2] of tempPoint matching (((((Matching unit) is Magic Immune) Equal to False) and (((Matching unit) is in KO_pullGroup) Equal to False)) and ((((Matching unit) is A Hero) Equal to True) and ((((Matching unit) is alive) Equal t and do (Actions)

 

[Cokemonkey11]

I see. I'll try to dig up some time to learn about it bit by bit. My ideas currently still can be created through GUI and it will be boring if I would to search one-by-one of the Jass scripts on how to write it instead of using GUI. haha..

Jass Newgen Pack has a really nice function list that looks like this -

And anyway if you can't figure out what function does what you need you can simply convert a gui trigger (edit -> convert to custom text)

 

[FUJI]

Kinetic Orb [ v1.2c ] This spell had been reviewed by jakeZinchttp://www.hiveworkshop.com/forums/members/jakezinc/#visitor_messaging Set tempPlayerGroup = (Player group((Owner of tempUnit))) You can just use TriggeringPlayer instead of this. Unit - Create 1 Kinetic Orb (dummy) for (Owner of KO_caster[KO_index2]) at tempPoint2 facing Default building facing degrees you can use also TriggeringPlayer.You misplaced setting the variable here: Animation - Change KO_dummy[KO_index2] flying height to KO_height at 0.00 Set KO_dummy[KO_index2] = (Last created unit) . You can just filter the units inside the group block instead of matching unit...()... in here: Unit Group - Pick every unit in (Units within KO_pullAoE[KO_index2] of tempPoint matching (((((Matching unit) is Magic Immune) Equal to False) and (((Matching unit) is in KO_pullGroup) Equal to False)) and ((((Matching unit) is A Hero) Equal to True) and ((((Matching unit) is alive) Equal t and do (Actions) and here Unit Group - Pick every unit in (Units within KO_landDamageAoE[KO_index2] of tempPoint matching (((((Matching unit) is A structure) Equal to False) and ((((Matching unit) is Mechanical) Equal to False) and (((Matching unit) is Magic Immune) Equal to False))) and ((((Matching unit) is alive) and do (Actions) . Other than that none. The documentation is well good. The configuration of values must be in initialization not in execution because may the user harm the code:. -------- ======================================================== -------- -------- --------------------------------------------- Configurable --------------------------------------------- -------- Set tempReal = (Real((Level of KO_ability for KO_caster[KO_index2]))) -------- The duration (in seconds) for the dummy to reach the target point -------- Set KO_duration[KO_index2] = (1.75 - (0.25 x tempReal)) -------- The duration (in seconds) for the target to pull over to reach the dummy's position -------- Set KO_pullDuration[KO_index2] = (0.75 + (0.25 x tempReal)) -------- The damage dealt when the dummy reach the target point -------- Set KO_landDamage[KO_index2] = (125.00 + (75.00 x tempReal)) -------- The amount of mana burned (in second) when the nearest target is being pulled -------- Set KO_burnedMana[KO_index2] = (30.00 + (30.00 x tempReal)) -------- The area of effect for the damage dealt when the dummy reach the target point -------- Set KO_landDamageAoE[KO_index2] = (250.00 + (25.00 x tempReal)) -------- The area of effect that detects the nearest hero. If no hero is within this range, then the spell will immediately end. -------- Set KO_pullAoE[KO_index2] = (600.00 + (100.00 x tempReal)) -------- ----------------------------------------- Configurable End ----------------------------------------- -------- -------- ======================================================== -------- The lightning model can be configurable: AddLightningEx("CLPB", true, GetLocationX(udg_tempPoint2), GetLocationY(udg_tempPoint2), udg_tempZReal, GetLocationX(udg_tempPoint3), GetLocationY(udg_tempPoint3), udg_tempZReal2) The special effect can be configurable: Special Effect - Create a special effect at tempPoint using war3mapImported\OrbLightningX.mdx Special Effect - Destroy (Last created special effect) and this: Special Effect - Create a special effect at tempPoint using Abilities\Spells\Human\ThunderClap\ThunderClapCaster.mdl Special Effect - Destroy (Last created special effect) The spell is completely MUI and leakless. The enemy units can get instantly killed which looks like odd, other than that none. There's importing instruction tho. The special effects are well executed and the movement of the lightning orb with the lightning effects is spiced up the spell which looks good =)). Useful from Hero Arenas, it does pull units. This can be merged into 3 line: Set tempPoint = (Center of (Playable map area)) Unit - Create 1 Peasant for Neutral Passive at tempPoint facing Default building facing degrees Set TreeDestroyer = (Last created unit) Unit - Hide TreeDestroyer Unit - Make TreeDestroyer Invulnerable Custom script: call RemoveLocation (udg_tempPoint) add a locust and harvest ability to the peasant because what if the user remove the harvest ability to the peasant so safety first ^^. I like the style of the tooltip that makes the spell alive ! and it does support every levels, castrange and spell type. Rejected: 1-10 Unacceptable : 11-30 Lacking : 31-49 Useful : 50-69 Recommended : 70-90 Highly Recommended : 91-100 Director Cut : 101-105 1) Triggering - 15/20 2) Documentation - 8/10 3) Importing Instruction - 7/10 4) Special Effects - 12/15 5) Usefulness - 16/20 6) Tooltip - 10/10 7) Configuration - 5/10 Total Score - 73/105 jakeZinc Rating - 3.5/5 Status - Recommended