KB3D - Knock back 3D

[chobibo]

How's the lag? is there still heavy lag?

 

[T. D. W.]

I pushed tests to their limits, results:

and i finally had 5000 counter before the loop triggered the clear (no more instances)
The lag occurred ed exactly when instances reached 200
note that they were all on the screen, and not spread on the map
So, i thought of what could be the solution, in indexing, or whatever it's name is, when you replace an inactive instance with another could be THE solution
of a reducement for the huge lag
I think the system can lag less if it wasn't Hashtable based, i will see what will come up with both of us, chobibo

Till now, i will change all required stuff, and will see what happens

I hope and think that tomorrow will be the release date

 

[Rheiko]

so you will use indexing? but in Jass?
if it's in GUI maybe i can help you

 

[T. D. W.]

@Rheiko, maybe yes, indexing in JASS
the triggers are now more hardcoded than before in JASS
this is how you can help:
Download the test map and TEST TEST and TEST, the configuration trigger is in GUI as i always do

 

[Malhorne]

JASS use the same indexing as GUI dude
It is in vJASS there is struct and now you can be the god of instanciate xD
I'm back but only for pointing little bugs or something since i'll work a bit

 

[T. D. W.]

I know
Any way, i'll upload the latest version along with it's triggers

 

[chobibo]

Yo Jad, lemme see the new code, I won't use the GUI indexing, I'm going to use a linked list.

 

[Malhorne]

Oh yeah linked list for the win
Anyway tell me when it's upload to the last.

 

[T. D. W.]

Uploaded right now!

 

[Malhorne]

Use TriggerAddCondition instead of TriggerAddAction
Replace TRUE by true.
An array is already filled up with values AFAIK

 

[chobibo]

God, I'm having trouble with linked list, it's been so long since I've used one that I forgot how to, LAWL, I'm going back to arrays lol.

 

[Rheiko]

lol..
could someone show me an example about linked list?
i'm curious about them

 

[T. D. W.]

--" i thought i fixed those ....

An array is already filled up with values AFAIK

what does this mean?

God, I'm having trouble with linked list, it's been so long since I've used one that I forgot how to, LAWL, I'm going back to arrays lol.

any how the goal is to reduce the lag

Added Screenshots and the main Pic of the System

 

[Rheiko]

An array is already filled up with values AFAIK

really? i don't think so.. if you mean values at variable editor, i don't think so

 

[chobibo]

globals
    integer ListLast = 8190
    integer array List
    
    integer InstanceCount = 0
endglobals


function List_add takes integer index returns boolean
    set List[index]=ListLast
    set ListLast=index
    set InstanceCount=InstanceCount+1
    return (InstanceCount<8190)
endfunction

function List_delete takes integer index returns nothing
    set ListLast = List[index]
    set InstanceCount=InstanceCount-1
endfunction

function List_iterate takes nothing returns nothing
    local integer i
    local integer last = ListLast
    loop
        set i = last
        exitwhen i==8190
        call BJDebugMsg(I2S(i))
        set last=List[i]
    endloop
endfunction

function InitTrig_List takes nothing returns nothing
    call List_add(9)
    call List_add(8)
    call List_add(7)
    call List_add(6)
    call List_add(5)
    call List_add(4)
    call List_add(3)
    call List_add(2)
    call List_add(1)
    call List_add(0)
    call TimerStart(CreateTimer(),1.00,false,function List_iterate)
endfunction

Oh sorry wrong edit!
This implementation lacks proper removal. lol.
EDIT: INFO: You don't need the mathematical operation to loop through the elements on the list.
EDIT 2: This is called a singly linked list.

 

[T. D. W.]

yh, and so?
what should i do?
PS: in the system, JNGP Only stuff shouldn't be used (like globals) System MUST stay normal JASS for users

 

[chobibo]

Oh sorry Jad, I was just showing chief Rheiko what linked lists looked like, you don't need that lol.

 

[T. D. W.]

oh, ok

 

[Rheiko]

lol, i'm a chief now eh? xD

 

[Malhorne]

Ahah xD
Anyway when you create a global variable it starts automatically to null for handle type as far as i know

 

[chobibo]

Jass doesn't do that for locals, only global variables are properly initialized to null without user intervention. The declaration local unit caster will not initialize caster with a null value. It's undefined.

 

[T. D. W.]

i never knew physics from last year of school will help me in this system

 

[Malhorne]

Yes
Oups i forgot the word global in the precedent message sry xD

 

[Rheiko]

Jad, remember to give credits to both Malhorne and chobibo
they helped you a lot xD
9 pages, lol

 

[T. D. W.]

i did already

///////////////////////////////////////////////////////////////////////////////////
//                                                                               //
//                 Credits:                                                      //
//                                                                               //
//      *Chobibo for helping in Script Fixes                                     //
//      *Malhorne for helping in Script Fixes                                    //
//                                                                               //

 

[Rheiko]

haha, lol

 

[Malhorne]

I though it was a group project xD!
Anyway did you correct in the main post ?

 

[chobibo]

YAHAHAHAHA! I managed to remember how to remove links properly dafuq!

function List_iterate takes nothing returns nothing
    local integer i
    local integer last = ListLast
    local integer p = (-1)
    loop
        set i = last
        exitwhen i==8190
        if (i==5) then
            set List=List[i] @<-- This one removes the current link@
        endif
        call BJDebugMsg(I2S(i))
        set p=last
        set last=List[i]
    endloop
    call TimerStart(GetExpiredTimer(),1.00,false, function List_iterate)
endfunction

 

[Rheiko]

I though it was a group project xD!
Anyway did you correct in the main post ?

it is?
Jad, give credits to all members in this group xD

 

[T. D. W.]

@malhorne
not 100% grp project.... i needed help for fixing the triggers xD
and the first post's Script is updated, but the map isn't
thought you can just CnP the new scripts into the old map

@rheiko, ^

@chobibo, oh well, congrats XD

 

[Malhorne]

    set udg_CP_HiddenItemsIndex = 0
    set udg_CP_HiddenItems[0] = null
    set udg_CP_Point = GetSpellTargetLoc()
    set udg_CP_PointIsWalkable = false

Why do you not do this in the variable editor

 

[T. D. W.]

removed

 

[Malhorne]

Fix the second triggeraddaction

 

[T. D. W.]

Akhhhhhhhhhhhh
Look at the function, it returns boolean, i did half of the work !!!! loL

 

[Malhorne]

Ahah xD !
What are the last known bugs from now ?

 

[chobibo]

Somethings wrong with the z ordinate manipulation, sometimes the unit doesn't go down, add a hashtable entry, a boolean to check if the unit already has a knockback, and if it does, to ignore it. You can also make an additive knockback but you'll need to overhaul those computations. I can't help you there, we need a mathematician here fast LOL!

EDIT: Wait, maybe Jad could do it, he studied physics after all lol!

 

[T. D. W.]

I AM working on it
14 of the hashtable is for something called Ztot, total height gained during the spell/instance giving us the possibility to know the amount of Z that should be automatically be removed after the spell, note that it is in BETA stage in your current version of the system and on the thread

 

[Malhorne]

What do you need in terms of maths ?
Since i'm kinda good in maths

 

[Rheiko]

lol
i'm bad at math, but i'm good at english (at school of course)..
at here, damn.. i was an eight years old kid who is plain bad at english as

Spoiler

Radicool

said

 

[T. D. W.]

For me, i don't need help in math (i am the #1 of my school in math so...)
Physics have the same story for me

 

[Malhorne]

So you need nothing except the code correction
Anyway if you need something ask

 

[T. D. W.]

Yh, that's it

 

[Malhorne]

Is this working as supposed to work now ?

 

[chobibo]

Hm, I think you could submit this already, I mean if you used arrays (as I was suggesting) for this then importing it would be messier, since you'll be needing 15 arrays. What do you guys think Malhorne-sama? Rheiko-sama?

 

[T. D. W.]

@malhorne, bath - pause, back now
@chobibo
As soon as i finish my calculations, i will submit it, i will just remove a couple of thousand units in the test map, and i do not think users will have more than 200 knockback/instance
(The number of instances for the lag to start)

 

[chobibo]

I guess that concludes the project for us, lez grab some booze!

 

[FUJI]

Oh finally you use Natives in loading and saving datas in hashtable DD!

 

[T. D. W.]

ok, found the formula for the Time taken for the knockback if Accel > 0

Time = ( Accel * Range ) / ( BaseSpeed + FinalSpeed )

Problem, FinalSpeed does not have a formula to be found yet :/

 

[T. D. W.]

@Jake, yes, i updated my JNGP

@chobibo, hell no, formulas are still unknown xD (your work hasn't finished yet, you still have to check for mistakes in the final product)

 

[Malhorne]

Okay i'm gonna lurk some codes mistakes or boolean expression mistakes