Jass tag syntax highlighting (more like an update than a bug, but meh)

[PurplePoot]

The following should be highlighted with the style ideally the same as that of the word after the dash.

"hi//"
       - "hi" //comments shouldn't occur in strings
5 - 'h000' //numbers
0x5 - 'h000' //hex numbers
$5 - 'h000' //hex numbers
0.5 - 'h000' //decimal numbers
this - true
super - true
thistype - unit
$a$ - method //textmacro variables
module - method
endmodule - method
optional - method
implement - method
delegate - method
stub - method
onDestroy - method
onInit - method
type - method
array - method
$ - [

Regexes

Textmacro variables:

\$[a-zA-Z_]\w*\$

Numbers (all types):

\-?((0x|\$)[\da-fA-F]+|\d+\.?\d*|\.\d+|'([^']|[^']{4})')

--

Also, could we get a maximum height on Jass tags (fairly short) after which they scroll?

 

[Eleandor]

Shouldn't "super" be highlighted too?

 

[PurplePoot]

Sure, why not. Added to the list (or do you think it would look better as a type?).

 

[Deaod]

imo, highlight super like true or unit

 

[TriggerHappy]

I don't like the jass tags here, theres no scroll.

 

[Ralle]

Poot, just tell me when the list is complete

 

[Samuraid]

Those are not part of the standard Jass grammar. I'm sure they must be part of some extension (vJass?) though, otherwise you wouldn't be bringing them up.

 

[TriggerHappy]

Those are not part of the standard Jass grammar. I'm sure they must be part of some extension (vJass?) though, otherwise you wouldn't be bringing them up.

Yes, but anyone who uses standard jass is insane.

Most people use vJASS, so why not have the syntax highlighted as well?

 

[Eleandor]

method

isn't jass either, but it's being highlighted too.

super should be bold too IMO.

 

[Samuraid]

Yes, but anyone who uses standard jass is insane.

Call me insane, then.

 

[Deaod]

Key Words:

constant
native
function
takes
returns
endfunction
if
then
else
elseif
endif
loop
endloop
exitwhen
struct
endstruct
method
endmethod
interface
endinterface
globals
endglobals
library
endlibrary
scope
endscope
private
public
requires
initializer
uses
needs
static
call
set
local
return
and
or
not
debug
type
extends
keyword
delegate
readonly
stub
defaults
onDestroy
onInit
module
endmodule
implement
optional
array

Types:

ability
aidifficulty
alliancetype
attacktype
blendmode
boolean
boolexpr
buff
button
camerafield
camerasetup
code
conditionfunc
damagetype
defeatcondition
destructable
dialog
dialogevent
effect
effecttype
event
eventid
fgamestate
filterfunc
fogmodifier
fogstate
force
gamecache
gamedifficulty
gameevent
gamespeed
gamestate
gametype
group
handle
igamestate
image
integer
item
itempool
itemtype
leaderboard
lightning
limitop
location
mapcontrol
mapdensity
mapflag
mapsetting
mapvisibility
multiboard
multiboarditem
nothing
pathingtype
placement
player
playercolor
playerevent
playergameresult
playerscore
playerslotstate
playerstate
playerunitevent
quest
questitem
race
racepreference
raritycontrol
real
rect
region
sound
soundtype
startlocprio
string
terraindeformation
texmapflags
texttag
thistype
timer
timerdialog
trackable
trigger
triggeraction
triggercondition
ubersplat
unit
unitevent
unitpool
unitstate
unittype
version
volumegroup
weapontype
weathereffect
widget
widgetevent

Values:

false
null
super
this
true

dont forget support for $

oh yeah, could you put Jass code into a frame of variable width (based on the parents width) and fixed height with {overflow: scroll;}? Would make browsing Jass code much more convenient.

 

[PurplePoot]

Added $, numbers, and array as well as changed this and super. Thoughts (directed to Deaod mostly)?

 

[Deaod]

type - method

tbh, i dont really care for recolouring array. Some add it to the types list, though it doesnt really belong there, imo. I extracted that list from my vJass highlighting for UltraEdit.

 

[PurplePoot]

Yeah, I'd agree that it fits more along the lines of the identifier keywords than the type keywords.

Also, nice catch.

--

What are your thoughts on $x$? method (as suggested above) or otherwise?

 

[Deaod]

Dont use a specific colouring for $x$, i think colouring like a number is okay.

 

[PurplePoot]

Not sure what you're saying. You want it to be $x$, $x$, or just $x$?

 

[Deaod]

if you dont treat it like anything special, it will just be highlighted the way you highlight $ numbers.

 

[PurplePoot]

Not quite, since it wouldn't colour the last $. However, I could just list them to be coloured like numbers.

Anyhow, does this look good to go?

 

[Deaod]

highlighting wise, yes.

other than that:

oh yeah, could you put Jass code into a frame of variable width (based on the parents width) and fixed height with {overflow: scroll;}? Would make browsing Jass code much more convenient.

I'd like to highlight that one again, as i think that would make sharing Jass code a whole lot easier.

 

[PurplePoot]

Alright, done.

 

[TriggerHappy]

oh yeah, could you put Jass code into a frame of variable width (based on the parents width) and fixed height with {overflow: scroll;}? Would make browsing Jass code much more convenient.

Add that please

 

[PurplePoot]

The new highlighting is great, but it introduced one bug: An unpaired $ sign that is also not followed by a number will break hidden tags below it.

For example:

$

hi

a

 

[Ralle]

I have worked a bit on that.

 

[PurplePoot]

Thanks, it's fixed now.

 

[Eleandor]

set var[3] = 55
set var[var[3]] = 2

For some reason, it always bolds 1 less "]"

 

[Ralle]

Works?