[JASS] JASS Simplify (NEWB Question)

[KaiserG]

ok im a really newb at JASS (was a bit lazy to learn it, until i got realized of its powers) and i need to know if there is a more efficient way the next script can be done: (i think there is, by using a loop or more like a function. I think its too long and can be shorter by using another method)

• WindowShow
  • Events
    • Time - Elapsed game time is 1.50 seconds
  • Conditions
  • Actions
    • Custom script: if GetLocalPlayer() == Player(0) then
    • Custom script: call MultiboardDisplay(udg_Multiboard[1],true)
    • Custom script: endif
    • Custom script: if GetLocalPlayer() == Player(1) then
    • Custom script: call MultiboardDisplay(udg_Multiboard[2],true)
    • Custom script: endif
    • Custom script: if GetLocalPlayer() == Player(2) then
    • Custom script: call MultiboardDisplay(udg_Multiboard[3],true)
    • Custom script: endif
    • Custom script: if GetLocalPlayer() == Player(3) then
    • Custom script: call MultiboardDisplay(udg_Multiboard[4],true)
    • Custom script: endif
    • Custom script: if GetLocalPlayer() == Player(4) then
    • Custom script: call MultiboardDisplay(udg_Multiboard[5],true)
    • Custom script: endif
    • Custom script: if GetLocalPlayer() == Player(5) then
    • Custom script: call MultiboardDisplay(udg_Multiboard[6],true)
    • Custom script: endif
    • Custom script: if GetLocalPlayer() == Player(6) then
    • Custom script: call MultiboardDisplay(udg_Multiboard[7],true)
    • Custom script: endif
    • Custom script: if GetLocalPlayer() == Player(7) then
    • Custom script: call MultiboardDisplay(udg_Multiboard[8],true)
    • Custom script: endif
    • Custom script: if GetLocalPlayer() == Player(8) then
    • Custom script: call MultiboardDisplay(udg_Multiboard[9],true)
    • Custom script: endif
    • Custom script: if GetLocalPlayer() == Player(9) then
    • Custom script: call MultiboardDisplay(udg_Multiboard[10],true)
    • Custom script: endif

thanks in advance

 

[GhostWolf]

local integer i = 0
local integer players = someNumber // this is how much players play currently
loop
     exitwhen i = players
     if GetLocalPlayer() == Player(i) then
           call MultiboardDisplay(udg_Multiboard[i],true)
     endif
     set i = i + 1
endloop

And why don't you type in jass instead of custom scripts ?

 

[KaiserG]

rofl, just to show you that i'm real nw to JASS

 

[Earth-Fury]

call MultiboardDisplay(udg_Multiboard[GetPlayerId(GetLocalPlayer()) + 1],true)

one line of code should do it...

 

[Blue_Jeans]

GhostWolf, notice that the multiboard index is one higher than the player index...
The entire trigger should look something like this:

function Trig_WindowShow_Actions takes nothing returns nothing
    local integer i=0
    loop
        exitwhen i>9
        if GetLocalPlayer() == Player(i)
            call MultiboardDisplay(udg_Multiboard[i+1],true)
        endif
        set i = i +1
    endloop
endfunction

//===========================================================================
function InitTrig_WindowShow takes nothing returns nothing
    set gg_trg_WindowShow = CreateTrigger(  )
    call TriggerRegisterTimerEventSingle( gg_trg_WindowShow, 1.50 )
    call TriggerAddAction( gg_trg_WindowShow, function Trig_WindowShow_Actions )
endfunction

 

[PurplePoot]

Blue_Jeans, EF still takes this one home.

 

[KaiserG]

thanks Earth-Fury! thats the mos simple way to do it ^^

 

[Silvenon]

[offtopic]Kaiser, if you're looking for a memory leak checker, I'm your man [/offtopic]

 

[Blue_Jeans]

@Poot
I just copied GhostWolf's code and changed some numbers to be what they were supposed to and added the InitTrig. I remember when I was starting out, it bugged me that when people helped me, they automatically assumed that I knew which events/conditions to use. Also, my page was cached locally and I didn't see EF's post, or I would have taken his code and added an InitTrig...

 

[Herman]

What does the GetLocalPlayer() function do???

 

[Blue_Jeans]

Gets the player behind the keyboard of the machine it is running on.

 

[Rheias]

> Gets the player behind the keyboard of the machine it is running on.

In other words...

Each function called runs on each player's computer seperatly. In order to refer to the player that the function his executed at is computer use GetLocalPlayer().

 

[Herman]

Uh

So it will return the player that the function is currently executing for???

 

[Blue_Jeans]

You betcha, Herman.

 

[Need_O2]

So it will return the player that the function is currently executing for???

LoL Very High IQ (understood in first... /me casts brain transfer on Herman)

 

[Herman]

IQ's got nuthin to do with it

I just don't know JASS ><

I don't really have such good knowledge of multiplayer online programming, sorry bout the newb questions

 

[Need_O2]

Wait ...
I wasnt kidding
on someone it took 100 minutes for me to make him understand what does GetLocalPlayer do...

 

[Herman]

Oh heh

Yeah it is a bit of an odd concept, considering in GUI you need to specify the player that each event would be working on if you did something generic (Unit - Dies)

But the code is different in JASS and you can use GetLocalPlayer() for such things (I think?)

 

[Need_O2]

I dont think registering an event for GetLocalPlayer for registering all would be ok ... (it may crash or cause big bugs)

 

[Blue_Jeans]

uh... there are a few things you could do with GetLocalPlayer... but only a very few. DisplayTextToPlayer, for one. The problem is that if you test whether the triggering player is equal to the GetLocalPlayer, it will trigger on one computer. So, if there is any data in the trigger which gets sent over the network... bad idea.

 

[Herman]

Ew

That's not good, so I suppose GetLocalPlayer() would be a function to be used sparingly, and I should probably do alot more work in JASS before trying it

Thnx for the info +rep

 

[KaiserG]

hehe well guys, try to stay in topic, if you want, you can discuss that GetLocalPlayer() function in a new thread, or as well on this thread

 

[Herman]

Whoops sorry bout that

Thnx for the explanation link (will help me later)