[JASS] Life Break v1.0m

[Moderator]

Life Break v1.0m | Reviewed by Maker | 18th Apr 2013

APPROVED

The spell is MUI and leakless You could remove saved handles before flushing child hashtable

[tr]

Old reviews Life Break v1.0e - Reviewed by Maker - 12.02.2013 Approved TRIGGERING call LB_DummyCasterID in LB_Preload instead of using the raw code directly. The raw code will be most likely different when importing the spell into another map Position exitwhen after SetAbilityAvailable in the preload to make it affect neutral passive (P15) also GENERAL It is another charge spell, so not too original. But it works well, it feels smooth and the effects and sounds are ok. The pathing check works too. You could improve the importing instructions, you need to copy the abilities. The tooltip could be better also. Life Break v1.0d - Reviewed by Maker - 11.02.2013 Required changes are coloured red TRIGGERING In LB_TimerLoop you are setting variables that you might not need, only set them if you need them. For example, calculate x4 and y4 only if you are going to set the casters x and y. Use dummy caster id in LB_Preload OBJECT EDITOR Locust makes the dummy invulnerable, remove inlvunerability ability from it GENERAL Add importing intructions into the map file You could separate the test trigger from the spell folder

 

[super_nova]

Nice work!
It would be very nice if u want to work on my requests too...

 

[Doomlord]

Your ravage request is currently being worked on by Mr.Bean. We plans to use Adiktuz' vJASS Impale system to make it to achieve a perfect result

 

[super_nova]

Your ravage request is currently being worked on by Mr.Bean. We plans to use Adiktuz' vJASS Impale system to make it to achieve a perfect result

I see then..
Nice work you got here btw
Can u make huskar's other abilities? like burning spear perhaps..
EDIT: It looks like this one need to be fixed anyway

 

[Doomlord]

Pathing check added as requested.

@supernova: I cannot say for sure. It depends on my schedule and motivation

 

[defskull]

I just want to know few stuffs;
1. Is the caster magic-immune while charging ?
2. If #1 is correct, when do you damage the unit ? Right after you remove the immune, or before you remove the immune ?
3. If you damage it right after the removal of immune, then you're doing the right way since in DotA, Blademail returns the damage if the target activates it, and you know that Blademail does not work when the unit is magic-immune, right ?

 

[super_nova]

I just want to know few stuffs;
1. Is the caster magic-immune while charging ?
2. If #1 is correct, when do you damage the unit ? Right after you remove the immune, or before you remove the immune ?
3. If you damage it right after the removal of immune, then you're doing the right way since in DotA, Blademail returns the damage if the target activates it, and you know that Blademail does not work when the unit is magic-immune, right ?

Yea, in DotA the caster didn't even get magic-immune while charging too

 

[Doomlord]

I just want to know few stuffs;
1. Is the caster magic-immune while charging ?
2. If #1 is correct, when do you damage the unit ? Right after you remove the immune, or before you remove the immune ?
3. If you damage it right after the removal of immune, then you're doing the right way since in DotA, Blademail returns the damage if the target activates it, and you know that Blademail does not work when the unit is magic-immune, right ?

1. Yes.
2. Magic immunity is removed right when the caster reached the target and before dealing damage.
3. Indeed my friend.

Yea, in DotA the caster didn't even get magic-immune while charging too

The tooltip from DotA said he is magic immune when charging, never get the chance to test though

 

[defskull]

Yea, in DotA the caster didn't even get magic-immune while charging too

The caster is magic-immune, I triple-checked.

It is the Barathrum that his charge is not magic-immune.

 

[super_nova]

The tooltip from DotA said he is magic immune when charging, never get the chance to test though

My bad
But i doubt in DotA the damage to the caster is direct hp removal, because the damage is reduced by hood of defiance pretty much..

 

[defskull]

But i doubt in DotA the damage to the caster is direct hp removal, because the damage is reduced by hood of defiance pretty much..

You are correct.
It is damaged by trigger, Doomlord.

Also if I'm not mistaken, you can prevent the self-damage if you on BKB.

That means, the magic-immune from BKB and magic-immune from Life Break is 2 different magic-immune base spells.

 

[Doomlord]

My bad
But i doubt in DotA the damage to the caster is direct hp removal, because the damage is reduced by hood of defiance pretty much..

It is magical damage. I changed it because I consider that an annoyance.

 

[defskull]

It is magical damage. I changed it because I consider that an annoyance.

You don't have to think of that since you are copying others' spell.
You must follow exactly.

 

[super_nova]

If the target and the caster is magic immune, the target wont take damage but the caster will then?

 

[Doomlord]

You don't have to think of that since you are copying others' spell.
You must follow exactly.

Sorry but my style is improving what can be improved, thus there is always a difference that ranges from minor, subtle changes to heavy modifications bordering on complete remake.

All my other spells also have this trait.

 

[defskull]

If the target and the caster is magic immune, the target wont take damage but the caster will then?

You said caster and target is magic immune, and both of them doesn't take any damage.

 

[super_nova]

You said caster and target is magic immune, and both of them doesn't take any damage.

No, if they were both magic immune, then the caster will taking the hp removal while the target won't take any damage is it?

 

[Doomlord]

No, if they were both magic immune, then the caster will taking the hp removal while the target won't take any damage is it?

Actually, the damage type here is pure so yeap, magic immunity won't work.

 

[super_nova]

I see..
Let's just wait it to be approved then

@defskull: any progress?

EDIT: Congrats for the approval!

 

[CheckeredFlag]

hey doomlord can i import it now

 

[Doomlord]

hey doomlord can i import it now

Oh sorry I forgot about your request. Yes ofc you can, just remember to modify it a bit to fit your demand.

 

[UndeadImmortal]

Bug found! If you cast it another time while you're charging into an enemy unit, you won't be able to move.

 

[Doomlord]

Bug found! If you cast it another time while you're charging into an enemy unit, you won't be able to move.

Thanks for telling me that. Updating it in a few more hours.

EDIT: Unable to recreate your bug. Please send me a video or a picture

 

[BunnyAng]

I'd prefer the caster to be able to go through obstacles, otherwise it'd be a difficult spell to land.

 

[Doomlord]

I'd prefer the caster to be able to go through obstacles, otherwise it'd be a difficult spell to land.

Sorry but the risk it poses is too high to ignore. I would never want my hero to get stuck while charging.

I do have a work-around in the form of Smart Charge If you are interested then go ahead

 

[Hazop / Sarven]

How do I decrease Damage?!

 

[Daffa]

Find and modify these lines

// Main target damage
function LB_DamageEnemy takes integer level returns real
    return 45. + level*5.
endfunction

// Self damage
function LB_DamageSelf takes integer level returns real
    return 40. - level*5.
endfunction

 

[Hazop / Sarven]

Find and modify these lines

// Main target damage
function LB_DamageEnemy takes integer level returns real
    return 45. + level*5.
endfunction

// Self damage
function LB_DamageSelf takes integer level returns real
    return 40. - level*5.
endfunction

yeah but does 45 damage mean it takes away 45% hp? Because I tested it in my map and it did different damage based on unit

 

[Elprede]

Have you accounted for a unit's armor?

 

[Hazop / Sarven]

Have you accounted for a unit's armor?

Defence Type? then yeah

 

[KILLCIDE]

yeah but does 45 damage mean it takes away 45% hp? Because I tested it in my map and it did different damage based on unit

No it doesn't. Look at the attack type and damage type and find some credible resource that shows how damage calculations work.

// Attack type
function LB_AttackType takes nothing returns attacktype
    return ATTACK_TYPE_HERO
endfunction

// Damage type
function LB_DamageType takes nothing returns damagetype
    return DAMAGE_TYPE_MAGIC
endfunction