JALQ(just another leak question)

[HammerFist]

Does this leaks: Create paathing blockers at point ofset x= for excample 2421 and y=5542 so nothing like x of unit and y of unit.

 

[-Kobas-]

• Unit - Create 1 Footman for Player 1 (Red) at ((Center of (Playable map area)) offset by (0.00, 0.00)) facing Default building facing degrees

function OffsetLocation takes location loc, real dx, real dy returns location
    return Location(GetLocationX(loc) + dx, GetLocationY(loc) + dy)
endfunction

As you can see this function will return location so it will leak if you don't remove it later.

I suggest this:

• Custom script: call CreateDestructable(objectid, x, y, facing, scale, variation)

scale by default = 1.00
variation by default = 0

 

[HammerFist]

Will try it when come at home. I have started this custom scripts few days ago xD.

 

[-Kobas-]

It's not hard really, especially if you use Jass New Gen or some external jass scripting tool.

 

[HammerFist]

Don't know. I use jngp only when I need some additional things like bigger maps, countless doodats amny tiles and such things. Custom scripts I mostly learn by hart xD.

 

[mckill2009]

creating something will always leak but not the position itself using Xy coordinates...

 

[Troll-Brain]

creating something will always leak but not the position itself using Xy coordinates...

Sorry but what you are saying doesn't make sense.

Technically a leak it's when there is some memory hold, when it's no more necessary.
But it's not because you create something that it will create a leak, ofc it will take some memory but it's intended.
Now when the object is not destroyed when it's no more used, or if there is still some memory hold by it when it has been destroyed, then it's a leak.

 

[mckill2009]

Sorry but what you are saying doesn't make sense.

you already answered the non-sense statement >>> "Technically a leak it's when there is some memory hold"...all objects in WC3 creates memory allocations, intended or not...

I said not the position itself coz XY coordinates doesnt create a location...

 

[Troll-Brain]

No, no, no, allocated useful memory is hardly a leak ... Your quote is not long enough, it's out of context without "when it's no more necessary".
Call a cat, a cat, not a dog.

 

[mckill2009]

Your quote is not long enough, it's out of context without "when it's no more necessary".

--->

all objects in WC3 creates memory allocations, intended or not

 

[Troll-Brain]

But it's not a leak.

 

[mckill2009]

well I just define leak==memory allocation, a user is creating destructables for example in a certain point needed or not, I call it leak ...

 

[Troll-Brain]

It's fine if you speak at yourself only.

Even when i talk to a 100 % GUI user i use the right terms, because he can't progress with only approximations of facts.

Now sure, it's really easy to get a memory leak when you use GUI, there are even some within GUI functions, such as PolledWait, and there is not any garbage collector.

And yes if you create a location and don't store it in a variable, then it's 100 % sure you will have a leak since you can't get anymore this location, so it will use some memory space for nothing.

A memory leak, in computer science (or leakage, in this context), occurs when a computer program consumes memory but is unable to release it back to the operating system. In object-oriented programming, a memory leak happens when an object is stored in memory but cannot be accessed by the running code.[1] A memory leak has symptoms similar to a number of other problems (see below) and generally can only be diagnosed by a programmer with access to the program source code; however, many people refer to any unwanted increase in memory usage as a memory leak, though this is not strictly accurate from a technical perspective.

Because they can exhaust available system memory as an application runs, memory leaks are often the cause of or a contributing factor to software aging.

 

[gorillabull]

hey what if you just save something's handle (probably location handle in this case) in a hashtable so later you can use it or remove it so that wont leak because the memory address is not lost

 

[Cokemonkey11]

That would (genearlly) be very inefficient. If you intend to re-use data, there are much better ways, for example:

globals
    location point=Location(0,0)
endglobals

and later when you need a location:

call MoveLocation(point,newX,newY)

then refer to point again.

Similarly, you can re-use a group if it never retains contents.