Does this ACTION leak?

[TheWhiteWolf]

Okay, I have a single action and I would like to know if it leaks.
(temp is a point variable)

• Create a unit at (Point((X of temp), ((Y of temp) + 300))) facing...

 

[MasterTrainer]

Okay, I have a single action and I would like to know if it leaks.
(temp is a point variable)

• Create a unit at (Point((X of temp), ((Y of temp) + 300))) facing...

I recommend you store X of temp and Y of temp in a variable and remove and null that variable after use (along with temp)

 

[Binsu]

It doesn not leak maybe but try MT's suggestion. And I also suggest make your trigger clearer because I cant see a trigge like that in WE so far.

 

[HesitationSnow]

I just tested, it does leak.

 

[MasterTrainer]

I just tested, it does leak.

I told you people it does leak.

So he/she should store X and Y of temp in a variable and remove and null the variable after use.

 

[Maker]

The Point function converts the given coordinates into a point (location). Use another point variable for that.

temp = some location
temp2 = temp offset by 300 towards 90 degrees
create unit at temp2

or

temp = some location
temp2 = Point(x of temp, y of temp + 300)
create unit at temp2

 

[TheWhiteWolf]

If I only remove the point variable via call RemoveLocation, will it leak if I don't null it?

 

[deathismyfriend]

If I only remove the point variable via call RemoveLocation, will it leak if I don't null it?

no it will not nulling only removes the pointer. a variable is a pointer to the memory piece. RemoveLocation removes the memory from wc3. basically like deleting a file on ur pc. nulling it removes the shortcut to that file. hope that helps

 

[Maker]

WC3 process does take up more and more memory if you do not null them. Whether that is due to the operating system allocating more memory for some reason or it is a leak, is unclear. You'd have to have at least a hundred million unnulled globals for that to make any kind of difference, so don't worry about it.

 

[deathismyfriend]

WC3 process does take up more and more memory if you do not null them. Whether that is due to the operating system allocating more memory for some reason or it is a leak, is unclear. You'd have to have at least a hundred million unnulled globals for that to make any kind of difference, so don't worry about it.

although this is true i still like to null them. Whats one more simple line of code u know wat i mean ? Might as well make the map as efficient as possible lol. I even went back and nulled all my globals but that is easy with JNGP. for nulling going back to null them is really up to the coder.

 

[themerion]

Might as well make the map as efficient as possible lol.

Nulling a variable that doesn't have to be nulled is about as helpful as DoNothing()... it obfuscates your code, and actually requires another line to be read by the JASS parser.

So, if efficiency == speed, then nulling globals will actually be slower. Nobody will of course ever notice, but still. I would not use the term "efficient" for that sort of coding behaviour.