Item Shop System

[Izzetin]

Wow incredibly useful and the amout of Items you made for the System for showcase. awesome.
The handling is well done and i like the Big Shop Window.

You should add the ''stack count'' in the Hero's inventory though if the Shop Window is opened.
I clicked the Healthpotions and didnt knew how many i got until you close the Shop to look and reopen it to buy more.

 

[Aldeia]

Looks sick!

 

[Uncle]

That's awesome, good job! I've seen some pretty amazing item systems using custom UI but they've always lacked in aesthetic appeal, which this appears to have a lot of.

One minor thing that jumped out to me though was the Tooltip background is too transparent and makes it difficult to read the text when highlighting an Item. I'm basing this off of the above gif, so apologies if this is no longer the case.

 

[Wrda]

You can set a all points of a frame to another frame's points by using BlzFrameSetAllPoints, it looks like you're trying to do this in the play method of the components trigger, and in other places.

Create method of Item struct has a potential reference item leak when returning 0.
To be honest, I think you should swap "clear favourites" button with the "close" one, looks more intuitive.

There's room for minor optimizations, such as in show method of Inventory struct, specifically GetLocalPlayer and GetOwningPlayer.

Seems a bit tricky to interact with the first inventory slot of the unit (to sell the item) if it's at the far left position, collides with a minimap button.

Overall, this is a great system that expands completely the concept of shops in Warcraft 3. Perhaps you would like the icons of shift left and right to be in accordance to their direction? Up and down looks a bit confusing.
Brilliant.

Approved

 

[ColourWolfe]

Man this is just next level. Incredible work!

 

[emperor_d3st]

The amount of effort, creativity and competence that went into this is just insane.

 

[LeQuangVu]

CTD when save/load.

 

[Pyrogasm]

CTD when save/load.

What do you mean by this?

 

[LeQuangVu]

What do you mean by this?

I always get a crash to desktop (CTD) when saving and loading this save. I know I need save and load function. I read this tutorial of Tasyen: UI: Save&Load Frames but this Shop system too hard for me to modifier.

 

[Uncle]

I always get a crash to desktop (CTD) when saving and loading this save. I know I need save and load function. I read this tutorial of Tasyen: UI: Save&Load Frames but this Shop system too hard for me to modifier.

Don't you generate the entire shop using a single function call - and if not, couldn't you just wrap it all into one function? Because if I understand correctly, all you need to do is create your shop after a 0s delay when the game is loaded, as per the instructions in that tutorial you linked.

I simplified the tutorial code to make it even easier for you:

library FrameLoader initializer init_function
    private function timerAction takes nothing returns nothing
        // THIS IS THE ONLY THING YOU NEED TO EDIT:
        call CreateMyShop()
        call DestroyTimer(GetExpiredTimer())
    endfunction

    private function eventAction takes nothing returns nothing
        local timer t = CreateTimer()
        call TimerStart(t, 0, false, function timerAction) // This acts as a 1 frame delay
        set t = null
    endfunction

    private function init_function takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterGameEvent(t, EVENT_GAME_LOADED)
        call TriggerAddAction(t, function eventAction)
        set t = null
    endfunction
endlibrary

You would replace call CreateMyShop() with a function you've created that contains ALL of your Shop creation code.

 

[LeQuangVu]

Don't you generate the entire shop using a single function call - and if not, couldn't you just wrap it all into one function? Because if I understand correctly, all you need to do is create your shop after a 0s delay when the game is loaded, as per the instructions in that tutorial you linked.

I simplified the tutorial code to make it even easier for you:

library FrameLoader initializer init_function
    private function timerAction takes nothing returns nothing
        // THIS IS THE ONLY THING YOU NEED TO EDIT:
        call CreateMyShop()
        call DestroyTimer(GetExpiredTimer())
    endfunction

    private function eventAction takes nothing returns nothing
        local timer t = CreateTimer()
        call TimerStart(t, 0, false, function timerAction) // This acts as a 1 frame delay
        set t = null
    endfunction

    private function init_function takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterGameEvent(t, EVENT_GAME_LOADED)
        call TriggerAddAction(t, function eventAction)
        set t = null
    endfunction
endlibrary

You would replace call CreateMyShop() with a function you've created that contains ALL of your Shop creation code.

Thanks you so much.

 

[Produtor]

How do I change the shop's inventory position?