[Trigger] Integer A does not work. Need help..!

[Lord Marcus XVI]

So I have been categorizing units so that if a specific special unit attacks them it deals damage bonus. For example if a pikeman attacks a "cavalry" unit, it deals +7 damage.

Preparation Trigger

• Unit Categorization 01
  • Events
    • Map initialization
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
      • Then - Actions
        • Set A_Chal_UCag_Cavalry[1] = Troll Battlerider
        • Set A_Chal_UCag_Cavalry[2] = Blood Elf Pathfinder
        • Set A_Chal_UCag_Cavalry[3] = Town Scout
        • Set A_Chal_UCag_Cavalry[4] = Knight (Chalaguine)
        • Set A_Chal_UCag_Cavalry[5] = Knightess
        • Set A_Chal_UCag_Cavalry[6] = Elite Knight (Chalaguine - Tier 1)
        • Set A_Chal_UCag_Cavalry[7] = Elite Bashknight (Chalaguine)
        • Set A_Chal_UCag_Cavalry[8] = Grand Marshall (On Horse)
        • Set A_Chal_UCag_Cavalry[9] = Elite Knight (Chalaguine - Tier 2)
        • -------- ----------------------------TO BE UPDATED-------------------------- --------
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
      • Then - Actions
        • Set A_Chal_UCag_Siege[1] = War Catapult
        • Set A_Chal_UCag_Siege[2] = Blood Elf Arcane Golem
        • Set A_Chal_UCag_Siege[3] = Blood Elf Ballista
        • Set A_Chal_UCag_Siege[4] = Armored Ogre
        • Set A_Chal_UCag_Siege[5] = Ballista
        • Set A_Chal_UCag_Siege[6] = Battering Ram
        • Set A_Chal_UCag_Siege[7] = Catapult
        • Set A_Chal_UCag_Siege[8] = Ballistic Catapult
        • Set A_Chal_UCag_Siege[9] = Wheeled Cannon
        • Set A_Chal_UCag_Siege[10] = Mangonel
        • Set A_Chal_UCag_Siege[11] = Trebuchet
        • -------- ----------------------------TO BE UPDATED-------------------------- --------
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
      • Then - Actions
        • Set A_Chal_UCag_Flyer[1] = Siege Balloon
        • Set A_Chal_UCag_Flyer[2] = Staunch Jet N100 Series
        • Set A_Chal_UCag_Flyer[3] = Blood Elf Dragonhawk
        • Set A_Chal_UCag_Flyer[4] = Blood Elf Dragonhawk Windrider
        • Set A_Chal_UCag_Flyer[5] = Srcygon
        • -------- ----------------------------TO BE UPDATED-------------------------- --------
      • Else - Actions

Loop Trigger

• Chal Tic Tac Toe
  • Events
    • Unit - A unit Is attacked
  • Conditions
  • Actions
    • -------- ---> For Chalaguine Pikeman <--- --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Unit-type of (Attacking unit)) Equal to Pikeman (Chalaguine)
      • Then - Actions
        • For each (Integer A) from 1 to 100, do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Unit-type of (Attacked unit)) Equal to A_Chal_UCag_Cavalry[(Integer A)]
              • Then - Actions
                • Unit - Cause (Attacking unit) to damage (Attacked unit), dealing 7.00 damage of attack type Normal and damage type Enhanced
              • Else - Actions
      • Else - Actions

Nothing works and happens.

 

[LordDz]

Use For each Integer Variable instead of Integer A, Integer A is bad for performance.

If the Kill unit is just for testing, you should remove it from the triggers you upload here as it causes confusion when reading the trigger.

What's the unit type of the attacked unit? Is it included in the map init trigger?


But wouldn't it just be simplier for you to change the armors, so that units with spears deal Spear damage (Piercing) against cavarly (chaos armor). You do this in gameplay interface and gameplay constants.

 

[Lord Marcus XVI]

What's the unit type of the attacked unit? Is it included in the map init trigger?

yes I think I'll change the integer variable now as I've been scrolling the forums that many people say Integer A / B sucks up so bad haha

As what you asked, I'm answering that no, it's not put into the map init trigger.
I thought it will be considered in the second trigger I put.

 

[LordDz]

Erm, let's rephase that a bit.

Is your attacked unit-type one of these unit types?
Set A_Chal_UCag_Cavalry[1] = Troll Battlerider
Set A_Chal_UCag_Cavalry[2] = Blood Elf Pathfinder
Set A_Chal_UCag_Cavalry[3] = Town Scout
Set A_Chal_UCag_Cavalry[4] = Knight (Chalaguine)
Set A_Chal_UCag_Cavalry[5] = Knightess
Set A_Chal_UCag_Cavalry[6] = Elite Knight (Chalaguine - Tier 1)
Set A_Chal_UCag_Cavalry[7] = Elite Bashknight (Chalaguine)
Set A_Chal_UCag_Cavalry[8] = Grand Marshall (On Horse)
Set A_Chal_UCag_Cavalry[9] = Elite Knight (Chalaguine - Tier 2)

IF NOT, then it's quite obvious why it doesn't work, right?

 

[Lord Marcus XVI]

Erm, let's rephase that a bit.

Is your attacked unit-type one of these unit types?
Set A_Chal_UCag_Cavalry[1] = Troll Battlerider
Set A_Chal_UCag_Cavalry[2] = Blood Elf Pathfinder
Set A_Chal_UCag_Cavalry[3] = Town Scout
Set A_Chal_UCag_Cavalry[4] = Knight (Chalaguine)
Set A_Chal_UCag_Cavalry[5] = Knightess
Set A_Chal_UCag_Cavalry[6] = Elite Knight (Chalaguine - Tier 1)
Set A_Chal_UCag_Cavalry[7] = Elite Bashknight (Chalaguine)
Set A_Chal_UCag_Cavalry[8] = Grand Marshall (On Horse)
Set A_Chal_UCag_Cavalry[9] = Elite Knight (Chalaguine - Tier 2)

IF NOT, then it's quite obvious why it doesn't work, right?

Yes, one of them is the attacked unit and I don't know why my attacking unit does not do the additional damage.

Erm, let's rephase that a bit.

Is your attacked unit-type one of these unit types?
Set A_Chal_UCag_Cavalry[1] = Troll Battlerider
Set A_Chal_UCag_Cavalry[2] = Blood Elf Pathfinder
Set A_Chal_UCag_Cavalry[3] = Town Scout
Set A_Chal_UCag_Cavalry[4] = Knight (Chalaguine)
Set A_Chal_UCag_Cavalry[5] = Knightess
Set A_Chal_UCag_Cavalry[6] = Elite Knight (Chalaguine - Tier 1)
Set A_Chal_UCag_Cavalry[7] = Elite Bashknight (Chalaguine)
Set A_Chal_UCag_Cavalry[8] = Grand Marshall (On Horse)
Set A_Chal_UCag_Cavalry[9] = Elite Knight (Chalaguine - Tier 2)

IF NOT, then it's quite obvious why it doesn't work, right?

I guess fixing the variable integer will be the solution, will try it minutes from now. thanks

Thanks, man. The problem is fixed. I just changed the integer variable from being Integer A.

 

[Bribe]

You'll want to use a DDS like Weep's GDD to detect a real damage event. Right now, this can be abused by spamming the "stop" order.

 

[KILLCIDE]

You'll want to use a DDS like Weep's GDD to detect a real damage event. Right now, this can be abused by spamming the "stop" order.

In addition to what Bribe said:

The event "Unit - A unit Is attacked" will run before the actual attack is even made. That means that even if the unit misses, they will still deal the damage with your current setup. Also, it will look a little awkward to see damage being dealt before the actual attack even hit.

 

[Dr Super Good]

Use For each Integer Variable instead of Integer A, Integer A is bad for performance.

Performance difference is trivial. Reasons to use the other are purely flexibility and safety.

Integer A should work in his given example.

 

[KILLCIDE]

Integer A should work in his given example.

That's what I was thinking as well. I was extremely confused to how changing the loop integer actually fixed it. He most likely had another loop in his map that used Integer A running at the same time.

 

[Lord Marcus XVI]

You'll want to use a DDS like Weep's GDD to detect a real damage event. Right now, this can be abused by spamming the "stop" order.

I think DDS is very hard to setup same as the Knockback Systems. I don't know. All I know is just copying the triggers of those stuff and paste and nothing more.

 

[Bribe]

It's a little bit of copy and paste. With Weep's, you copy and paste some custom script and a trigger, then delete the trigger. I'll make a video of how to install stuff like that one day to reduce the learning curve.

 

[KILLCIDE]

I think DDS is very hard to setup same as the Knockback Systems. I don't know. All I know is just copying the triggers of those stuff and paste and nothing more.

Well thats why there are example triggers and readme sections.

However, I guess a video that Bribe suggested will be extremely helpful.

 

[Lord Marcus XVI]

Got it worked mons ! tnx!