Ice Shards 1.2

[Moderator]

Moderator: Pharaoh_ Date: 05:13, 26th Apr 2012 Changes made; while this is a bit basic use of hashtables, I will mark it as useful. Approved. Older review • Don't use a region, use Point with polar offset; if you want it random, then use (Point1 offset by X towards (Random angle) degrees). • (Random point in C_DamageArea_Area): Leaks. • Set C_DummyPosition[C_Integer] = (Position of C_Dummy[C_Integer]): No reason for this variable to be enhanced with array. • Use Create Special effect and destroy it right after; there's no reason to use a dummy for it. • Do you really need Skip remanining actions? • Cause C_Caster[C_Integer] to damage (Picked unit), dealing (Real(C_RealDamage)): 1) C_RealDamage should be a real variable, not an integer. 2) Reload C_RealDamage under the current index within the loop trigger, otherwise you are just loading a global variable from any instance. • Set C_DummyPosition[C_Integer] = (Position of C_Dummy[C_Integer]): if you had set Random point in region in a variable, then this would not be necessary.

 

[Tank-Commander]

Again with the tirggers on this one, please spread them out so it's overall easier to read. This one is about equal simplicity to your other, I'd like to see more configuration on this spell - like a Base and Per Level value for each configurable otherwise the spell may be underpowered early-game and overpowered late game and there wouldn't be much to do about it inbetween, Also you should temporarily store things in variables if they're constantly used (especially if it's in a loop) For instance the level of the ability being cast would be an example which'd apply to this spell

 

[Jay the Editor]

Don't use this

• Unit - A unit Begins casting an ability

You can easily skip the mana consumption by instantly pressing stop right after you click the spell.

 

[eubz]

• Don't use a region, use Point with polar offset; if you want it random, then use (Point1 offset by X towards (Random angle) degrees).

The shards are far away from the caster in this action therefore, the enemy close to the caster is never hit by any shards. As the AoE increases, the dummy moves farther.
What the spell suppose to be is that enemy units within reach of the caster should randomly be hit even those which are close to the caster.
I have tested the action

• Centered at position of (Caster[_integer]) offset by (AoE) towards (random angle) degrees

. The offset by (AoE) makes the shards move far away in circle at random angle from the caster and not randomly inside the circle around the caster which what I like.

• Set C_DummyPosition[C_Integer] = (Position of C_Dummy[C_Integer]): if you had set Random point in region in a variable, then this would not be necessary.

How will I identify which enemy units without setting the dummy position. I am using the dummy position as reference so that only those units around 100 of the position of the dummy to be affected by the spell, or be damaged.

• Cause C_Caster[C_Integer] to damage (Picked unit), dealing (Real(C_RealDamage)): 1) C_RealDamage should be a real variable, not an integer. 2) Reload C_RealDamage under the current index within the loop trigger, otherwise you are just loading a global variable from any instance.

1. Sorry, I forgot to change C_RealDamage to real.
2. C_RealDamage is already inside the loop.

• Set C_DummyPosition[C_Integer] = (Position of C_Dummy[C_Integer]): No reason for this variable to be enhanced with array.

Sorry, I haven't done this. Doing this right away.

• If ((C_Dummy[C_Integer] is dead) Equal to True) then do (Skip remaining actions) else do (Do nothing)

Should I delete this?

Don't use this

• Unit - A unit Begins casting an ability

Thank you for this.

NOTE:
Please point me in the right direction.

 

[xorkatoss]

Triggers

• -------- ---------------------------------------------------------------------------------------------------- --------
• -------- I have tried Points with polar offset but that doesn't fit what I like the spell to be. --------
• -------- The ice shards don't come close to the caster. It should come close so that --------
• -------- ramdom enemies closer to him can also be hit by the shards. --------
• -------- This action seems to work fine. --------
• Set C_DamagePoints = (C_CasterPosition[C_Integer] offset by (Real(C_AoE)) towards (Random angle) degrees)
• -------- ---------------------------------------------------------------------------------------------------- --------

lol what? in this action you are actually using a point with polar offset dude

The ice shards don't seem to come close to the caster.It should come close so that random enemies closer to him can also be hit by the shards.

well if you want the spell to damage units closer to the caster then you should use this:

• Set C_DamagePoints = (C_CasterPosition[C_Integer] offset by (Random real number between 100.00 and 300.00) towards (Random angle) degrees)

anyway the spell is MUI and leak-less gj 4/5 for now

 

[Pharaoh_]

You are creating the dummy at C_DamagePoints. Re-setting a variable to track the dummy's location is unnecessary. You already know it, by C_DamagePoints variable, because this is where you create it in the first place. So, use

C_DamageUnits = (Units within 100.00 of C_DamagePoints instead.

---

• Set C_RealDamage = (C_Damage + (Real((Level of Spirit Shards for C_Caster[C_Integer]))))

This will cause the spell to damage the enemies for the static damage a user can set in the map initialization + the level of the ability (which should be multiplied, actually, this is how most formulas work).
I'll give you an example:
A user wants to deal 20, 60, 100, 140 damage to a unit per level.
If the user configures C_Damage to 20, then the formula would result
(40 * (Level of (Ability being cast) for (Triggering unit)) - C_Damage).

When you are going to damage the units in your loop trigger (a.k.a. Sp Duration), you force the spell to deal C_Damage + (Level of ability) = 20 + 1 = 21 damage; for level 2 = 20 + 2 = 22 damage. See that?

What you should do is not leave the variable configurable in the Map Initialization, but in the trigger that detects the casting of the spell (a.k.a. Sp Cast). This would end up being
Set C_Damage[C_IndexSize] = (40 * (Level of (Ability being cast) for (Triggering unit)) - 20).

Now, in the Sp Duration, you will load it back to damage the units:

• Unit Group - Pick every unit in C_DamageUnits and do (Actions)
  • Loop - Actions
    • Unit - Cause C_Caster[C_Integer] to damage (Picked unit), dealing C_RealDamage[C_Integer] damage of attack type Spells and damage type Normal

---

• If ((C_Dummy[C_Integer] is dead) Equal to True) then do (Skip remaining actions) else do (Do nothing)

Yes, delete this.

 

[eubz]

Thanks. There you go, updated. I don't know if there are still somethings to be fixed in the triggers.

 

[Pharaoh_]

Position of caster is still with array
Finally, create the special effect at C_DamagePoints, instead of creating a dummy every 0.2 seconds.

Oh, and use starts the effect of an ability.

 

[eubz]

Spell updated with final fixes.

 

[Pharaoh_]

Thank you for your patience, eubz.

 

[eubz]

Well, if I want to learn, I have a lot of patience. Just like when I first learn the basics of creating maps and models. thanks to you, too in guiding me in creating this spell.

 

[Jay the Editor]

Remember that C_Loop and C_Integer can be replaced with a temp variables. Then, you can save up 2 variables for each spell that uses this Hanky's Dynamic Indexing System. =)

 

[eubz]

Thanks a lot.