[JASS] [How to]Smoothen missle

[Ribenamania]

EDIT: The question has been solved. No longer valid

 

[GhostWolf]

You don't get it, do you? You can either use globals, or use the H2I bug (which would only be efficient with vJass this days and then you'll already just use global structs instead of an array for each attribute). Don't like it? suicide.

 

[Element of Water]

Do it inside a function with a timer rather than a loop.

 

[Ribenamania]

Updated question.. anyone could help me?

 

[GhostWolf]

local unit u

//
//

set units = GetUnitsInRangeOfLocMatching(110.00, mmpoint,null)
loop
        set u = FirstOfGroup(units)
        exitwhen u == null
        call GroupRemoveUnit(units, u)

        if IsUnitEnemy(u,GetOwningPlayer(kd.u)) and IsUnitAliveBJ(u) then
              call UnitDamageTarget(kd.u,u, damage,true,false,ATTACK_TYPE_NORMAL,DAMAGE_TYPE_NORMAL,WEAPON_TYPE_WHOKNOWS)
              call KillUnit( md.u )
              call md.destroy()
              set Total = Total - 1
              set Missle[i] = Missle[Total]       
        endif

endloop

 

[Ribenamania]

local unit u

//
//

set units = GetUnitsInRangeOfLocMatching(110.00, mmpoint,null)
loop
        set u = FirstOfGroup(units)
        exitwhen u == null
        call GroupRemoveUnit(units, u)

        if IsUnitEnemy(u,GetOwningPlayer(kd.u)) and IsUnitAliveBJ(u) then
              call UnitDamageTarget(kd.u,u, damage,true,false,ATTACK_TYPE_NORMAL,DAMAGE_TYPE_NORMAL,WEAPON_TYPE_WHOKNOWS)
              call KillUnit( md.u )
              call md.destroy()
              set Total = Total - 1
              set Missle[i] = Missle[Total]       
        endif

endloop

Thanks =) It works now but wc3 crash after using once.

 

[Cokemonkey11]

then for some reason u is never equalling null. you might want to make a timeout for your loop. something like

exitwhen i > 300

 

[GhostWolf]

I made that code especially for your second loop, just copy and paste it, you changed it and it's obvious it won't work now.

You do "set hurt = FirstOfGroup(units)" only if the current unit is an enemy, so if it's an ally it gets into an infinite loop AND it tries to remove a unit that isn't in the group for infinite times (although it probably crashes at the first time... I guess).
You also destroy the projectile whether it's an enemy or an ally (I guess that isn't what you want?).

As to improving your code, remove all this BJs:
PolarProjectionBJ
IsTerrainPathableBJ
UnitDamageTargetBJ (I even gave you the freaking code for the non BJ...).

You also might as well use coordinates instead of locations.

if ( not ( IsUnitGroupEmptyBJ(units) == true ) ) then why not simply put != ? if IsUnitGroupEmptyBJ(units) != true then.

 

[Ribenamania]

^^ I've improved the code alot
Problem solved, the code works efficiently and doesn't has bugs. I may upload this code in spell section soon for all. =)
Btw, GhostWolf you've helped me alot. +rep =)