How to count buildings

[severed]

Im trying to make a trigger that goes something like:

If player 1 has no buildings than make Player 3 building (X) vulnerable

 

[Jampion]

• Count Units
  • Events
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of units in (Units owned by Player 1 (Red) matching (((Matching unit) is A structure) Equal to True))) Equal to 0
      • Then - Actions
      • Else - Actions

Keep in mind that you have to destroy unit groups to prevent leaks: Things That Leak

 

[severed]

cool thanks!

 

[Cuore]

Wanna destroy that group before it even begins.

 

[severed]

what?

 

[Cuore]

Just a pun.

From things that leak:

Trigger

• 
  
  Events
  • 
    
    
    Event
• 
  
  Conditions
  • 
    
    
    Conditions
• 
  
  Actions
  • 
    
    
    Custom script: set bj_wantDestroyGroup = true
  • 
    
    
    Unit Group - Pick every unit in (Playable Map Area) and do (Unit - Hide (Picked unit))

set bj_wantDestroyGroup = true
is the leak solver for unit groups and you have to write it before you even create the group.

 

[severed]

is there a way to test this? how do I know if its working or not

 

[Cuore]

I just check the code manually and add the leak-removing lines, then I consider it working fine if the code is correct.
I don't know of ulterior checks, sorry.

 

[severed]

seems to be working thanks!

 

[ZiBitheWand3r3r]

hey severed
much lighter is this solution:
put in map header in "Custom Script Code" section:
native GetBuilding takes player p returns unit
this native returns last buildings preplaced/constructed for given player, if returns null, that means player has no structures

to check if player red has no buildings use something like this trigger

• CheckPlayerRedBuildings
  • Events
  • Conditions
  • Actions
    • Custom script: if GetBuilding(Player(0))==null then
    • -------- -------------- --------
    • -------- means player red has no buildings (also no buildings under construction) --------
    • -------- do your actions here --------
    • -------- -------------- --------
    • Custom script: endif

 

[severed]

i put "native GetBuilding takes player p returns unit" into the map header/custom script

I added "Custom script: if GetBuilding(Player(0))==null" then but does 0=1? and 1=player2?
then I add Custom script: endif

but does that mean I should get rid of the suggestions from Cuore? they seem to be working so I dont want to mess anything up

 

[Dr Super Good]

Test out both. If both work then choose one to keep which most suits your style preferences.

 

[severed]

which most suits your style preferences

I dont really understand what these custom scripts do, they dont seem to change anything that I can see in-game

 

[Dr Super Good]

I dont really understand what these custom scripts do, they dont seem to change anything that I can see in-game

To test if they work, make the conditional statement print some game message if it passes. If no message appears in game then they do not work.

 

[Cuore]

I just want to say I'm personally in favor of the solution suggested by @ZiBitheWand3r3r because it's lightweight and elegant.

 

[severed]

• Count Units
  • Events
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of units in (Units owned by Player 1 (Red) matching (((Matching unit) is A structure) Equal to True))) Equal to 0
        • (Number of units in (Units owned by Player 2 (Blue) matching (((Matching unit) is A structure) Equal to True))) Equal to 0
      • Then - Actions
        • Unit - Remove Invulnerable (Neutral) from Resurrection Stone (Team 1) 0273 <gen>
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Number of units in (Units owned by Player 4 (Purple) matching (((Matching unit) is A structure) Equal to True))) Equal to 0
        • (Number of units in (Units owned by Player 5 (Yellow) matching (((Matching unit) is A structure) Equal to True))) Equal to 0
      • Then - Actions
        • Unit - Remove Invulnerable (Neutral) from Resurrection Stone (Team 2) 0274 <gen>
      • Else - Actions

Keep in mind that you have to destroy unit groups to prevent leaks: Things That Leak

this is the trigger I started with^ based on what Jampion suggested

then I created a new trigger for this:

From things that leak:
is the leak solver for unit groups and you have to write it before you even create the group.

• Custom script: set bj_wantDestroyGroup = true

• 
  
  
  Unit Group - Pick every unit in (Playable Map Area) and do (Unit - Hide (Picked unit))

At this point^ everything is working fine


So if I am going to switch it over to ZiBitheWand3r3r suggestion, should I erase the trigger with bj_wantDestroyGroup??

Also do I replace (Number of units in (Units owned by Player 1 (Red) matching (((Matching unit) is A structure) Equal to True))) Equal to 0
with Custom script: if GetBuilding(Player(0))==null or do I keep both?? and is 0 = player 1? so 1 = player2?

 

[Jampion]

So if I am going to switch it over to ZiBitheWand3r3r suggestion, should I erase the trigger with bj_wantDestroyGroup??

Yes, you can just use the trigger ZiBitheWand3r3r posted. In between the two custom scripts you can do your actions, as he said.

Also do I replace (Number of units in (Units owned by Player 1 (Red) matching (((Matching unit) is A structure) Equal to True))) Equal to 0
with Custom script: if GetBuilding(Player(0))==null or do I keep both?? and is 0 = player 1? so 1 = player2?

Player(x)=Player x+1, so yes Player(0) = Player 1

You can't put custom script as a condition into an if-block. As you need two conditions you can either use two conditions or use the keyword "and".

• Count Units
  • Events
  • Conditions
  • Actions
    • -------- Use "and" --------
    • Custom script: if ( GetBuilding(Player(0))==null and GetBuilding(Player(1))==null ) then
    • Unit - Remove Invulnerable (Neutral) from Resurrection Stone (Team 1) 0273 <gen>
    • Custom script: endif
    • -------- Or use two if-conditions --------
    • Custom script: if ( GetBuilding(Player(3))==null ) then
    • Custom script: if ( GetBuilding(Player(4))==null ) then
    • Unit - Remove Invulnerable (Neutral) from Resurrection Stone (Team 2) 0274 <gen>
    • Custom script: endif
    • Custom script: endif

 

[severed]

i just screwed up all my triggers by adding this line

Custom script: if ( GetBuilding(Player(0))==null

it disabled like 5 different things idk why...

I deleted it, I think everything went back to normal (i hope)

 

[Jampion]

you forgot the closing bracket ")" and the keyword "then"
It has to be "if ( GetBuilding(Player(0))==null ) then"
Look at my trigger above and make sure that your custom scripts are looking like mine.
Alos make sure that "native GetBuilding takes player p returns unit" is in the map header.

 

[severed]

you forgot the closing bracket ")" and the keyword "then"
It has to be "if ( GetBuilding(Player(0))==null ) then"
Look at my trigger above and make sure that your custom scripts are looking like mine.
Alos make sure that "native GetBuilding takes player p returns unit" is in the map header.

Ok i double checked everything and now it says:

Script Errors
Line 2576: Expected end of Line

//***************************************************************************
//*
//* Custom Script Code
//*
//***************************************************************************
native GetBuilding takes player p returns unit

 

[Jampion]

You need a world editor that uses JassHelper.
You probably want to get SharpCraft World Editor Extended Bundle

From the JassHelper manual:

Native declaration Freedom
This feature (added in 0.9.I.0) is similar to global declarations, but it is for more advanced users, so if you do not understand a single thing of these few paragraphs, feel free to skip to the explanation about the debug keyword. Warcraft III supports declaration of natives in the map script, but it requires the natives to be declared just after the script's globals section. Jasshelper will detect these declarations along the map and move them to the correct place.

Why would you want to do this? And what native functions exactly? There are some few native functions that were created for AI scripts that are not declared in common.j, some of them are actually useful for Jass maps. There is also the possibility you are using a modded/hacked version of warcraft III, and importing a whole new common.j for the native functions is probably too annoying for you, in this case you can declare the new custom functions in the map as well.

There is a protection in this feature that will make jasshelper delete declarations of duplicate natives. (i.e if the native was already declared in common.j, it will remove the native from the map script, to ensure your map is actually playable). This heavily depends on the common.j version provided to jasshelper. This is something to consider if for some reason the common.j version you (or newgen pack) is passing to jasshelper is different to the common.j version you intend the map to be playable with.

 

[Cuore]

Hey severed it seems to me that your problem is the same as the one described in GetUnitGoldCost() and GetUnitWoodCost()

I'll assume you're not using JNGP (you should). If you don't want to, let's just revert to GUI. I'll post the trigger here briefly.

Edit: uups just read Jampion's answer. pardon.

 

[severed]

I saw that the other day, been reading somethings, so much to learn I'll try that sharpeditor later, but for now ill stick with my original triggers.

Thanks, I'll post again if the time comes

 

[ZiBitheWand3r3r]

if not AI native, so maybe this?

• CheckPlayerRedBuildings
  • Events
  • Conditions
    • (Count structures controlled by Player 1 (Red) (Include incomplete structures)) Equal to 0
  • Actions

 

[severed]

that looks useful! yes that should be much easier

 

[Cuore]

Well, I didn't even know that GetPlayerStructureCount(PLAYER, BOOL) existed. XD
It's indeed perfect for this job. Big Thank you to Zibi and Jampion for helping triggernoobs out

• ExampleTrigger
  • Events
    • Unit - A unit Dies
  • Conditions
    • ((Triggering unit) is A structure) Equal to True
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Count structures controlled by Player 1 (Red) (Include incomplete structures)) Equal to 0
        • (Count structures controlled by Player 2 (Blue) (Include incomplete structures)) Equal to 0
      • Then - Actions
        • Unit - Remove Invulnerable (Neutral) from Resurrection Stone (southeast facing) 0000 <gen>
      • Else - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Count structures controlled by Player 4 (Purple) (Include incomplete structures)) Equal to 0
        • (Count structures controlled by Player 5 (Yellow) (Include incomplete structures)) Equal to 0
      • Then - Actions
        • Unit - Remove Invulnerable (Neutral) from Resurrection Stone (southwest facing) 0001 <gen>
      • Else - Actions

 

[severed]

Big Thank you to Zibi and Jampion

Haha Zibi already has a big thank you in the description of my map