[Trigger] How can i fix this leak?

[ALiEN95]

I heard that this condition leaks but i don´t know how could i destroy the group if it is condition?

• ((Random unit from (some unit) is alive) Not equal to True

for example....

• ((Random unit from (Units owned by Player 12 (Brown) matching (((Matching unit) is A Hero) Equal to True))) is alive) Not equal to True

 

[Eleandor]

Put it under actions in an if/then/else action.

Or alternatively learn jass and fix it there.

 

[Reaper2008]

Add to your functions:

• Custom Script - "call DestroyGroup(GroupName)"

 

[Ralle]

Make a global variable called group and set the type to unitgroup.

Then in your trigger do this:

• Name
  • Set group = (Units owned by Player 12 (Brown) matching (((Matching unit) is A Hero) Equal to True))
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • ((Random unit from group is alive) Not equal to True)
    • Then - Actions
      • -------- whatever you want --------
    • Else - Actions
  • Custom Script - call DestroyGroup(group)

 

[Eleandor]

The actual unit group created is:
Units owned by Player 12 (Brown) matching (((Matching unit) is A Hero) Equal to True)

 

[Ralle]

Okay I have fixed my trigger to match what you said

 

[Eleandor]

Another mistake you made: the custom script must not be in quotation marks:

• Custom script: call DestroyGroup(udg_group)

 

[Ralle]

I just took what the other guy said
Anyway, yet again, fixed. I hope he sees this

 

[ALiEN95]

Make a global variable called group and set the type to unitgroup.

Then in your trigger do this:

• Name
  • Set group = (Units owned by Player 12 (Brown) matching (((Matching unit) is A Hero) Equal to True))
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • ((Random unit from group is alive) Not equal to True)
    • Then - Actions
      • -------- whatever you want --------
    • Else - Actions
  • Custom Script - call DestroyGroup(group)

i know that but its a bit annoying is there any other way to do that? xD

BTW i shure you will know this
i set the name of player 1 to player 1 + dead
and i want to return it to player 1 how can i do that?

 

[Reaper2008]

My bad, i set the "" to mark this as important. Got it fixed though, nevermind.