quite good (especially the height support) but there still are a few bugs
1. if you cast hook with the same unit it won't destroy the old dummys (best use the id of a dummy instead of the one of the caster)
2. if you jump shortly before the hook is over the target will just stay in the air (just reset the height after the spell is over)
3. it fucks up with unpathable terrain so you can make units stuck (either check the pathing using an item or the worse blizzard alternative)
4. the jump will make units get outside of the map, make them stuck and might cause critical errors (add bound checking)
other things:
- your loop trigger is rather unefficient (picking ALL units in the map every 0.03 seconds WILL lag if there are enough of them, better only pick the units which are necessary)
- destroying the group should be done after every unit in the group was picked
- you don't have to set booleans/integers to 0/false after u used them
- you are leaking stuff in the hashtable (use "clear all childs of handle id of unit)
- add documentation to the code so everyone knows what's going on in it
- SetUnitX/Y does ignore pathing so you don't have to disable it manually
- since you are using coordinates for SetUnitX/Y you should avoid locations since they are a little bit slower
- there are more realistic ways of making a jump spell (search for "parabola", "jump parabola", "GetParabolaZ" etc)
- you don't have to add and remove the fly ability everytime you change the height, once is enough
- you are leaking a special effect in the hook loop trigger
- avoid using custom values since you can easily store everything in a hashtable
- avoid using IntegerA/B since they might be used for other things and fuck up everything (better create your own counter variable)
all in all one can say that on the one hand there are still many things to improve and the idea is old but on the other hand a hook spell is rather complex so it's not suprising that one makes mistakes
Hooks
Jumps
Leaps
Approved
But meh.
