Holy Retaliation

[Daffa]

Thank you for submitting a wonderful spell to Hive! Here are my feedbacks for this resources:

• Resource Submission Rules (Models, skins, icons, spells) the spell must be MUI, where multiple units can use the ability at the same time with no bugs whatsoever. This spell does not function properly if there is more than one unit using this ability.
• • (Ability being cast) Equal to Holy Retaliation
  Wrap the Holy Retaliation into a variable. There's a very large chance that the ability changes when copied to another map due to rawdata difference that Warcraft III uses internally.
• As before, please do not use waits. One major reason it is not allowed is because in GUI and Jass (LUA has PreciseWait resource to circumvent this specific issue), waits have precision issue where it is internally has offset range. Refer to the Pros and Cons section of MUI Triggers with Waits (especially Cons)

Cons

• They are inaccurate (The actual wait time depends on the latency meaning that waits on Garena take much longer than waits on LAN)
• Wait times vary with an offset range of [+0.098 ... +0.2] seconds in the best case.
• Waits don't 'wait' when the game is paused. (Disputable)
• In JASS, when called inside Conditions, they crash the thread.
• The wait time with this method must be a constant. (Thank you IcemanBo for pointing this out)
• You either store all state and every last bit of event-response data that you want to use after the wait code, or you store absolutely nothing and depend on the current execution context of the trigger.
  (This means that using something like (Triggering Unit) after the wait action will give you incorrect results if you used a buffer to store data for the instances. You either use the buffers to store absolutely everything, or you use no buffers at all.) (Thank you again, IcemanBo for helping me make this realization)

• • Trigger - Add to (This trigger) the event (Unit - Damage_Source Takes damage)
  Please use Damage Engine 3A.0.0.0 and 3.8.0.0 instead, or even better if you use patch 1.31/Reforged where you can use Damage Engine 5.A.0.0 (if you have Reforged, there's an option for generic takes damage event)

 

[Arthourias]

Thanks for the feedbacks. I try to fix them as soon as possible.
About the waits, it is not important in this spell to be accurate so there is no need to change that
About the damage engine, Im trying to find a way to make this spell standalone rightnow.

 

[Daffa]

Thanks for the feedbacks. I try to fix them as soon as possible.
About the waits, it is not important in this spell to be accurate so there is no need to change that
About the damage engine, Im trying to find a way to make this spell standalone rightnow.

Regarding wait, it was a convention from 2013 era that, as far as I remember, always applied for Spell Section despite not explicitly stated in the current rules. Refer to the MUI Triggers with Waits thread about using Waits.

Disclaimer: This is not an acceptable form for Spell/System resources.
It is only meant for map-making.

Regarding the Damage Engine, it is ideally a standard and one of the most used Damage Detection System out there. If the user also imported other spells that requires the system (usually barricade/shield based spells), it will already become part of their map and they do not need re-importing the system.

 

[Arthourias]

Regarding wait, it was a convention from 2013 era that, as far as I remember, always applied for Spell Section despite not explicitly stated in the current rules. Refer to the MUI Triggers with Waits thread about using Waits.



Regarding the Damage Engine, it is ideally a standard and one of the most used Damage Detection System out there. If the user also imported other spells that requires the system (usually barricade/shield based spells), it will already become part of their map and they do not need re-importing the system.

Still Im using waits with no problem because accuracy is not important in this spell so there is no need to change.
Damage engine is a useful tool in every regard I kept in my mind that finally when there was no hope I can use it.

 

[Wrda]

Holy Retaliation Initials trigger:
No need to have the custom scripts there.

Holy Retaliation trigger:

• (Damage taken) Greater than 0.99
• (Damage_Source has buff Immolation) Equal to True
• HR_Cooldown_Integer Equal to 1

All of these conditions and the following actions should be in another trigger, when the unit takes damage. Recent patches allow now for "Any unit takes damage" event.
Cooldown Timer trigger and the whole spell needs to be reworked to function as per unit (using unit custom value). Easiest way to deal with unit custom values is to use a unit indexer, like this one: GUI Unit Indexer 1.4.0.0