Holy Bolt 1.0

[Moderator]

Spell v1.0 | Reviewed by Maker | 29th Sep 2013

APPROVED

The bolt looks good but the triggering could be a bit better Don't use two loops in HB Cast Put the dummy SetUnitX/Y actions into a loop Merge the two first 1 to 6 loops in HB Loop You don't need a unit group array. Use a non array for the casters and bj_wantDestroyGroup = true

[tr]

 

[Golden-Drake]

Changes Made

• All leaks is now removed with loops
• All integerA is now replaced with a custom Variable (HB_Integer)
• All movement for dummies/effects are now done with coordinates


• Thanks to jakeZinc and Daffa the Mage

 

[FUJI]

Too many REMOVE LOCATION CALLS XD!

EDIT:

1st download.

EDIT2:

*Use

set udg_X = GetUnitX ( udg_Unit )

set udg_Y = GetUnitY ( udg_Unit )

coordinates when moving a units and do not use locations for moving the unit. You can use like this:

set udg_Unit = GetTriggerUnit()
set udg_X = GetUnitX ( udg_Unit )
set udg_Y = GetUnitY ( udg_Unit )
set udg_MX = udg_X + udg_offset * Cos ( udg_Angle * 0.01747 )
set udg_MY = udg_Y + udg_offset * Sin ( udg_Angle * 0.01747 )
call SetUnitX ( udg_Unit , udg_MX )
call SetUnitY ( udg_Unit , udg_MY )
// Using coordinates will greatly reducing leaks and lags of the spell.

* Don't Use

• For each (Integer A) from 1 to 6, do (Actions)
  • Loop - Actions
    • Set HB_LPUnit[(Integer A)] = (Load (Integer A) of (Key HB_Handle) in HB_Table)

because it can cause some bugs. Use your own integer variable in this.

* Use this Custom script: set udg_Handle = GetHandleId ( udg_Unit )


* If you're removing location arrays then use integer loop variable for that so it is faster than writing that remove location calls
Like this:

• For each (Integer HB_MyOwnIntegerVariable) from 1 to 15, do (Actions)
  • Loop - Actions
    • Custom script: call RemoveLocation(udg_HB_Point[udg_HB_MyOwnIntegerVariable])

It is a quick review ^^ .

EDIT3:

I''ll rate it 3.5/5 ( because I know that this is your first spell ^^ ) but Needs Fix
This tutorial will help you Things a GUI User Should Know

 

[Daffa]

Use your own Integer instead of Integer A.

 

[Golden-Drake]

quote (jakezinc)

Too many REMOVE LOCATION CALLS XD!

EDIT:

1st download.

EDIT2:

*Use

set udg_X = GetUnitX ( udg_Unit )

set udg_Y = GetUnitY ( udg_Unit )

coordinates when moving a units and do not use locations for moving the unit. You can use like this:

set udg_Unit = GetTriggerUnit()
set udg_X = GetUnitX ( udg_Unit )
set udg_Y = GetUnitY ( udg_Unit )
set udg_MX = udg_X + udg_offset * Cos ( udg_Angle * 0.01747 )
set udg_MY = udg_Y + udg_offset * Sin ( udg_Angle * 0.01747 )
call SetUnitX ( udg_Unit , udg_MX )
call SetUnitY ( udg_Unit , udg_MY )
// Using coordinates will greatly reducing leaks and lags of the spell.

* Don't Use

• For each (Integer A) from 1 to 6, do (Actions)
  • Loop - Actions
    • Set HB_LPUnit[(Integer A)] = (Load (Integer A) of (Key HB_Handle) in HB_Table)

because it can cause some bugs. Use your own integer variable in this.

* Use this Custom script: set udg_Handle = GetHandleId ( udg_Unit )


* If you're removing location arrays then use integer loop variable for that so it is faster than writing that remove location calls
Like this:

• For each (Integer HB_MyOwnIntegerVariable) from 1 to 15, do (Actions)
  • Loop - Actions
    • Custom script: call RemoveLocation(udg_HB_Point[udg_HB_MyOwnIntegerVariable])

It is a quick review ^^ .

EDIT3:

I''ll rate it 3.5/5 ( because I know that this is your first spell ^^ ) but Needs Fix
This tutorial will help you Things a GUI User Should Know

i'd rather not copy something i don't understand and i do not understand any jazz-code you write (though i am working on learning it) but as 'Daffa the Mage' said i can do something about the integer

 

[Rheiko]

what does he mean is use coordinates

 

[FUJI]

quote (jakezinc)

i'd rather not copy something i don't understand and i do not understand any jazz-code you write (though i am working on learning it) but as 'Daffa the Mage' said i can do something about the integer

Ofc, It is a polar projection in GUI and this is recommended in moving units, but as you said you don't understant JASS then It's okay but this can be written in GUI custom script lines. Having a little knowledge in custom scripts must be needed not just by removing leaks.

 

[Rheiko]

i have a little knowledge at custom scripts, so? how about that?
jakeZinc?

 

[FUJI]

Then Good xD.

 

[Golden-Drake]

@jakeZinc
working hard on learning the "move unit"-scrips you showed me.
your link didn't work but i found it in the tutorial section (that is ofc if it was deathismyfriend's tutorial), even so it is helpfull and i will see if i can make it today

 

[Golden-Drake]

* Use this Custom script: set udg_Handle = GetHandleId ( udg_Unit )

This part is the only one i can't figure out (changed everything else)

 

[deathismyfriend]

Handle in the above custom script is actually an integer variable.
It should be named tempKey or tempInt not Handle as Handle is misleading.

Also anything used twice or more should be stored into a temp variable.
Example: store this (Key HB_Handle) into an integer variable.

 

[FUJI]

Anyway About 0.01747, it is bj_DEGTORAD.

 

[Shanesgp]

It looks really good. Pretty easy to import. Simple but very useful.