[JASS] Help With Creating an Event in Jass

[Gigakar]

I'm trying to make a function that detects when a key (for instance "down" key) is pressed by any player. I'm trying to write it in Jass, not in GUI. Can somebody help me write the code for one key as I am not that experienced with Jass.

I need the native GetTriggerPlayer to work as a reference in the code, what I have now isn't working so I won't bother posting it.

 

[Mcasdf]

scope GigakarFunction initializer InitFunc

    function DoStuff takes nothing returns nothing
        call BJDebugMsg("I'm alive")
    endfunction
    
    function InitFunc takes nothing returns nothing
        local trigger keyPressTrg = CreateTrigger()
        
        call TriggerRegisterPlayerEvent(keyPressTrg, Player(0), EVENT_PLAYER_ARROW_DOWN_DOWN)
        call TriggerAddAction(keyPressTrg, function DoStuff)
    endfunction
endscope

 

[Gigakar]

Thanks, that made things much simpler. However, I've stumbeled upon another problem. Why does this show two messages showing two "1" when I test the map as player 1? I want player 1 to n to be able to call function PressDown individually.

scope PressDown initializer InitPressDown

    function PressDown takes nothing returns nothing
        set udg_Down[GetPlayerId(GetTriggerPlayer())+1] = true
        call BJDebugMsg("1")
    endfunction
    
    function InitPressDown takes nothing returns nothing
        
        local integer i = 0
        local trigger keyPressTrg = CreateTrigger()
        
        loop
        
        call TriggerRegisterPlayerEvent(keyPressTrg, Player(i), EVENT_PLAYER_ARROW_DOWN_DOWN)
        call TriggerAddAction(keyPressTrg, function PressDown)
        
        //loopcount
        
        set i = i + 1
        
        if i == 2 then
            exitwhen true
        endif
        
        endloop
        
    endfunction
endscope

 

[mckill2009]

your TriggerAddAction should be outside the loop and exitwhen i==2...

 

[Gigakar]

Hmm, I can't seem to get this to work:

scope PressDown initializer InitPressDown

    function PressDown takes nothing returns nothing
        set udg_Down[GetPlayerId(GetTriggerPlayer())] = true
        call BJDebugMsg("1")
    endfunction
    
    function InitPressDown takes nothing returns nothing
        
        local integer i
        local trigger keyPressTrg = CreateTrigger()
        
        loop
        
        call TriggerRegisterPlayerEvent(keyPressTrg, Player(i), EVENT_PLAYER_ARROW_DOWN_DOWN)
        
        set i = i + 1
        
        exitwhen i == 9
        
        endloop
        
        call TriggerAddAction(keyPressTrg, function PressDown)
        
    endfunction
endscope

 

[Magtheridon96]

It's because i is uninitialized.

You should declare it like this:

local integer i = 0

edit
Also dude, I would really recommend indenting to make your code more readable

scope PressDown initializer InitPressDown

    function PressDown takes nothing returns nothing
        set udg_Down[GetPlayerId(GetTriggerPlayer())] = true
        call BJDebugMsg("1")
    endfunction
    
    function InitPressDown takes nothing returns nothing
        local integer i
        local trigger keyPressTrg = CreateTrigger()
        
        loop
            call TriggerRegisterPlayerEvent(keyPressTrg, Player(i), EVENT_PLAYER_ARROW_DOWN_DOWN)
            set i = i + 1
            exitwhen i == 9
        endloop
        
        call TriggerAddAction(keyPressTrg, function PressDown)
    endfunction
endscope

That looks much better ^.^

And don't forget to null the trigger at the end of the InitPressDown function, else it will leak. (Well, triggers aren't much of a problem in these cases, but it's always better to null all handles.)

set keyPressTrg = null

You should also do this for all units, players, destructables, widgets, and every other handle.
(Well, technically, not every handle, just the things that extend the 'agent' in common.j and things that extend things that extend the agent and so on )

For example, images don't need to be nulled because they directly extend the handle and not the agent. (type image extends handle).
playerstates also don't need to be nulled.

 

[Troll-Brain]

You should also do this for all units, players, destructables, widgets, and every other handle.
(Well, technically, not every handle, just the things that extend the 'agent' in common.j and things that extend things that extend the agent and so on )

For example, images don't need to be nulled because they directly extend the handle and not the agent. (type image extends handle).
playerstates also don't need to be nulled.

Just a guess, or it is something well tested ?

 

[Magtheridon96]

I know this because of what's been said previously, not from experimentation.
Yes, I know you're against that, but really I don't have time for experimentation D:

 

[Troll-Brain]

Then at least don't claim it as the absolute truth since it could be wrong, that's how many jass legends born.

 

[mckill2009]

your i shold start at '0' local integer i >>> local integer i = 0